DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	stable@dpdk.org, Yury Kylulin <yury.kylulin@intel.com>,
	helin.zhang@intel.com, "Ananyev,
	Konstantin" <konstantin.ananyev@intel.com>,
	jingjing.wu@intel.com, wenzhuo.lu@intel.com, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 0/2] fix mbufs leakage during Rx queue release on ixgbe/i40e
Date: Mon, 19 Sep 2016 22:47:43 +0800	[thread overview]
Message-ID: <20160919144743.GK10323@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <CAATJJ0Jw3FGczyhtX035erAE3q_2zw=KBgPWjS3ZNRT61Fx1Ug@mail.gmail.com>

On Mon, Sep 19, 2016 at 03:52:25PM +0200, Christian Ehrhardt wrote:
> On Mon, Sep 19, 2016 at 3:29 PM, Bruce Richardson <
> bruce.richardson@intel.com> wrote:
> 
> > > This patch set fixes problem when mbufs are not released back to the
> > > original memory pool during Rx queue relese call leading to mbufs
> > > "leakage".
> > >
> > > This issue happens when device stop (rte_eth_dev_stop()) will be called
> > > after device start (rte_eth_dev_start()) without any incoming packets
> > > received since device start. In this case both rxq->rx_tail and
> > > rxq->rxrearm_start equal to 0 and release cycle will not be executed.
> > > On the next device start (rte_eth_dev_start()) new set of mbufs for the
> > > RX queue will be allocated.
> > >
> > > Yury Kylulin (2):
> > >   net/ixgbe: fix mbufs leakage during Rx queue release
> > >   net/i40e: fix mbufs leakage during Rx queue release
> > >
> > Applied to dpdk-next-net/rel_16_11
> >
> 
> I don't know the underlying code well enough,

Me, neither.

> but given the description I'd
> expect that qualifies for the stable tree?

But, yes, I agree with Christian.

> Set stable@dpdk on cc.

Thanks for doing that.

	--yliu

      reply	other threads:[~2016-09-19 14:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-29 16:50 [dpdk-dev] " Yury Kylulin
2016-08-29 16:50 ` [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mbufs leakage during Rx queue release Yury Kylulin
2016-08-30  2:00   ` Lu, Wenzhuo
2016-08-29 16:50 ` [dpdk-dev] [PATCH 2/2] net/i40e: " Yury Kylulin
2016-09-01  2:38   ` Xing, Beilei
2016-09-19 13:29 ` [dpdk-dev] [PATCH 0/2] fix mbufs leakage during Rx queue release on ixgbe/i40e Bruce Richardson
2016-09-19 13:52   ` Christian Ehrhardt
2016-09-19 14:47     ` Yuanhan Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160919144743.GK10323@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    --cc=yury.kylulin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).