* [dpdk-dev] [PATCH] net/bnxt: make driver less verbose @ 2016-08-25 11:05 Ferruh Yigit 2016-08-25 19:03 ` Ajit Khaparde 2016-09-11 12:25 ` Yuanhan Liu 0 siblings, 2 replies; 7+ messages in thread From: Ferruh Yigit @ 2016-08-25 11:05 UTC (permalink / raw) To: dev; +Cc: Stephen Hurd This line printed for every application even if driver is not used at all. Removing the line to reduce the noise. Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> --- drivers/net/bnxt/bnxt_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 3795fac..37d0322 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1056,7 +1056,6 @@ static struct eth_driver bnxt_rte_pmd = { static int bnxt_rte_pmd_init(const char *name, const char *params __rte_unused) { - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", name); rte_eth_driver_register(&bnxt_rte_pmd); return 0; } -- 2.7.4 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: make driver less verbose 2016-08-25 11:05 [dpdk-dev] [PATCH] net/bnxt: make driver less verbose Ferruh Yigit @ 2016-08-25 19:03 ` Ajit Khaparde 2016-08-26 8:39 ` Ferruh Yigit 2016-09-11 12:25 ` Yuanhan Liu 1 sibling, 1 reply; 7+ messages in thread From: Ajit Khaparde @ 2016-08-25 19:03 UTC (permalink / raw) To: Ferruh Yigit; +Cc: dev, Stephen Hurd On Thu, Aug 25, 2016 at 6:05 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote: > This line printed for every application even if driver is not used at > all. Removing the line to reduce the noise. > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > --- > drivers/net/bnxt/bnxt_ethdev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ > ethdev.c > index 3795fac..37d0322 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1056,7 +1056,6 @@ static struct eth_driver bnxt_rte_pmd = { > > static int bnxt_rte_pmd_init(const char *name, const char *params > __rte_unused) > { > - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", name); > How about changing the log level to DEBUG? - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", name); + RTE_LOG(DEBUG, PMD, "bnxt_rte_pmd_init() called for %s\n", name); That should reduce the noise till the user explicitly changes the log level. Thanks > rte_eth_driver_register(&bnxt_rte_pmd); > return 0; > } > -- > 2.7.4 > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: make driver less verbose 2016-08-25 19:03 ` Ajit Khaparde @ 2016-08-26 8:39 ` Ferruh Yigit 2016-08-26 15:31 ` Ajit Khaparde 0 siblings, 1 reply; 7+ messages in thread From: Ferruh Yigit @ 2016-08-26 8:39 UTC (permalink / raw) To: Ajit Khaparde; +Cc: dev, Stephen Hurd On 8/25/2016 8:03 PM, Ajit Khaparde wrote: > > > On Thu, Aug 25, 2016 at 6:05 AM, Ferruh Yigit <ferruh.yigit@intel.com > <mailto:ferruh.yigit@intel.com>> wrote: > > This line printed for every application even if driver is not used at > all. Removing the line to reduce the noise. > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com > <mailto:ferruh.yigit@intel.com>> > --- > drivers/net/bnxt/bnxt_ethdev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > b/drivers/net/bnxt/bnxt_ethdev.c > index 3795fac..37d0322 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1056,7 +1056,6 @@ static struct eth_driver bnxt_rte_pmd = { > > static int bnxt_rte_pmd_init(const char *name, const char *params > __rte_unused) > { > - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", name); > > How about changing the log level to DEBUG? > > - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", name); > + RTE_LOG(DEBUG, PMD, "bnxt_rte_pmd_init() called for %s\n", name); > > That should reduce the noise till the user explicitly changes the log level. This will give similar result, this log is useless if you are not debugging this driver, but debug log level can be enabled for many reasons. Other drivers use PMD_INIT_FUNC_TRACE() macros, which requires specifically enabled in config for that driver. > > Thanks > > > > rte_eth_driver_register(&bnxt_rte_pmd); > return 0; > } > -- > 2.7.4 > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: make driver less verbose 2016-08-26 8:39 ` Ferruh Yigit @ 2016-08-26 15:31 ` Ajit Khaparde 0 siblings, 0 replies; 7+ messages in thread From: Ajit Khaparde @ 2016-08-26 15:31 UTC (permalink / raw) To: Ferruh Yigit; +Cc: dev, Stephen Hurd On Fri, Aug 26, 2016 at 3:39 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote: > On 8/25/2016 8:03 PM, Ajit Khaparde wrote: > > > > > > On Thu, Aug 25, 2016 at 6:05 AM, Ferruh Yigit <ferruh.yigit@intel.com > > <mailto:ferruh.yigit@intel.com>> wrote: > > > > This line printed for every application even if driver is not used at > > all. Removing the line to reduce the noise. > > > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com > > <mailto:ferruh.yigit@intel.com>> > > --- > > drivers/net/bnxt/bnxt_ethdev.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > > b/drivers/net/bnxt/bnxt_ethdev.c > > index 3795fac..37d0322 100644 > > --- a/drivers/net/bnxt/bnxt_ethdev.c > > +++ b/drivers/net/bnxt/bnxt_ethdev.c > > @@ -1056,7 +1056,6 @@ static struct eth_driver bnxt_rte_pmd = { > > > > static int bnxt_rte_pmd_init(const char *name, const char *params > > __rte_unused) > > { > > - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", > name); > > > > How about changing the log level to DEBUG? > > > > - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", name); > > + RTE_LOG(DEBUG, PMD, "bnxt_rte_pmd_init() called for %s\n", name); > > > > That should reduce the noise till the user explicitly changes the log > level. > > This will give similar result, this log is useless if you are not > debugging this driver, but debug log level can be enabled for many reasons. > > Other drivers use PMD_INIT_FUNC_TRACE() macros, which requires > specifically enabled in config for that driver. > There are other messages to aid tracing and debugging elsewhere in the code. So here goes.. Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> > > > > > Thanks > > > > > > > > rte_eth_driver_register(&bnxt_rte_pmd); > > return 0; > > } > > -- > > 2.7.4 > > > > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: make driver less verbose 2016-08-25 11:05 [dpdk-dev] [PATCH] net/bnxt: make driver less verbose Ferruh Yigit 2016-08-25 19:03 ` Ajit Khaparde @ 2016-09-11 12:25 ` Yuanhan Liu 2016-09-12 14:23 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit 1 sibling, 1 reply; 7+ messages in thread From: Yuanhan Liu @ 2016-09-11 12:25 UTC (permalink / raw) To: Ferruh Yigit; +Cc: dev, Stephen Hurd On Thu, Aug 25, 2016 at 12:05:47PM +0100, Ferruh Yigit wrote: > This line printed for every application even if driver is not used at > all. Removing the line to reduce the noise. > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > --- > drivers/net/bnxt/bnxt_ethdev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 3795fac..37d0322 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1056,7 +1056,6 @@ static struct eth_driver bnxt_rte_pmd = { > > static int bnxt_rte_pmd_init(const char *name, const char *params __rte_unused) > { > - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", name); Hi, FYI, my testrobot caught some errors when this patch is applied. --yliu --- /root/dpdk/drivers/net/bnxt/bnxt_ethdev.c:1057:42: error: unused parameter 'name' [-Werror,-Wunused-parameter] static int bnxt_rte_pmd_init(const char *name, const char *params __rte_unused) ^ 1 error generated. make[6]: *** [bnxt_ethdev.o] Error 1 make[5]: *** [bnxt] Error 2 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [net] Error 2 make[3]: *** [drivers] Error 2 make[2]: *** [all] Error 2 make[1]: *** [pre_install] Error 2 make: *** [install] Error 2 error: build failed ^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH v2] net/bnxt: make driver less verbose 2016-09-11 12:25 ` Yuanhan Liu @ 2016-09-12 14:23 ` Ferruh Yigit 2016-09-19 15:04 ` Bruce Richardson 0 siblings, 1 reply; 7+ messages in thread From: Ferruh Yigit @ 2016-09-12 14:23 UTC (permalink / raw) To: dev; +Cc: Ajit Khaparde, Stephen Hurd, Yuanhan Liu This line printed for every application even if driver is not used at all. Removing the line to reduce the noise. Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> --- drivers/net/bnxt/bnxt_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 3795fac..d4aa2eb 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1054,9 +1054,9 @@ static struct eth_driver bnxt_rte_pmd = { .dev_private_size = sizeof(struct bnxt), }; -static int bnxt_rte_pmd_init(const char *name, const char *params __rte_unused) +static int bnxt_rte_pmd_init(const char *name __rte_unused, + const char *params __rte_unused) { - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", name); rte_eth_driver_register(&bnxt_rte_pmd); return 0; } -- 2.7.4 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/bnxt: make driver less verbose 2016-09-12 14:23 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit @ 2016-09-19 15:04 ` Bruce Richardson 0 siblings, 0 replies; 7+ messages in thread From: Bruce Richardson @ 2016-09-19 15:04 UTC (permalink / raw) To: Ferruh Yigit; +Cc: dev, Ajit Khaparde, Stephen Hurd, Yuanhan Liu On Mon, Sep 12, 2016 at 03:23:43PM +0100, Ferruh Yigit wrote: > This line printed for every application even if driver is not used at > all. Removing the line to reduce the noise. > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> > --- Applied to dpdk-next-net/rel_16_11 /Bruce ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-09-19 15:04 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-08-25 11:05 [dpdk-dev] [PATCH] net/bnxt: make driver less verbose Ferruh Yigit 2016-08-25 19:03 ` Ajit Khaparde 2016-08-26 8:39 ` Ferruh Yigit 2016-08-26 15:31 ` Ajit Khaparde 2016-09-11 12:25 ` Yuanhan Liu 2016-09-12 14:23 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit 2016-09-19 15:04 ` Bruce Richardson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).