From: Bruce Richardson <bruce.richardson@intel.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: fix possible NULL deref in Rx path
Date: Mon, 19 Sep 2016 16:06:11 +0100 [thread overview]
Message-ID: <20160919150611.GE45548@bricha3-MOBL3> (raw)
In-Reply-To: <1470148881-24115-1-git-send-email-sagi@grimberg.me>
On Tue, Aug 02, 2016 at 05:41:21PM +0300, Sagi Grimberg wrote:
> The user is allowed to call ->rx_pkt_burst() even without free
> mbufs in the pool. In this scenario we'll fail allocating a rep mbuf
> on the first iteration (where pkt is still NULL). This would cause us
> to deref a NULL pkt (reset refcount and free).
>
> Fix this by checking the pkt before freeing it.
>
> Fixes: a1bdb71a32da ("net/mlx5: fix crash in Rx")
>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> ---
Applied to dpdk-next-net/rel_16_11
/Bruce
prev parent reply other threads:[~2016-09-19 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 14:41 Sagi Grimberg
2016-09-19 15:06 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919150611.GE45548@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).