From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0063.outbound.protection.outlook.com [104.47.33.63]) by dpdk.org (Postfix) with ESMTP id 9123329D1 for ; Mon, 19 Sep 2016 18:06:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xHbyDf7ZWpMrZRz4a6V/d5sUvNCyZ+M3MtG0bNlc2Vk=; b=lvUq1kFHNLt60H0PbtKfEOgOSm8xwNsbEp2Sfukq+u45ukm4MtGfo2qXBD+XKZw1u3aEWEIo/SSPdt7AfeGe1qbXb4UYlZct5WJRGOr370w1CXPaAhbf4rGJBtW4E7mStWO9mkAkFU082TL0XFHZYzsA9vpEVrE+rTp84oIe958= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.179.68.111) by BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.609.9; Mon, 19 Sep 2016 16:06:53 +0000 Date: Mon, 19 Sep 2016 21:36:31 +0530 From: Jerin Jacob To: "Kulasek, TomaszX" CC: "Ananyev, Konstantin" , "dev@dpdk.org" Message-ID: <20160919160630.GA18610@localhost.localdomain> References: <1472228578-6980-1-git-send-email-tomaszx.kulasek@intel.com> <1473691487-10032-1-git-send-email-tomaszx.kulasek@intel.com> <1473691487-10032-2-git-send-email-tomaszx.kulasek@intel.com> <2601191342CEEE43887BDE71AB9772583F0B583F@irsmsx105.ger.corp.intel.com> <3042915272161B4EB253DA4D77EB373A14F1A294@IRSMSX102.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <3042915272161B4EB253DA4D77EB373A14F1A294@IRSMSX102.ger.corp.intel.com> User-Agent: Mutt/1.6.2 (2016-07-01) X-Originating-IP: [122.179.68.111] X-ClientProxiedBy: PN1PR01CA0053.INDPRD01.PROD.OUTLOOK.COM (10.164.136.153) To BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) X-MS-Office365-Filtering-Correlation-Id: fff2f339-cd05-4cc6-0d00-08d3e0a6f9d5 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 2:CN8GrG7W2bpoPiOauLxGNL+xKRTzWPaI818gZyAmyPXheyysc0rWmrsn4as8Rcn5XC3hbPmJ1kHyeCpL/OaJAAlLxIpowIkWdKIiomPz6/46vjftvDQxMvK1CWH3Kt5WN7E0Do+c0owgBToOoZjvr9FcEebnw7zKiIS4iZPloa5RUBTdHqn/I4C5l48rO7ck; 3:TGfW9/jiUhB/D5T4s2Yne5vJoYJpdgw2yQZSNrxBVwX8Sg7/zKflLSCFkYXGFI53+5enH904vu/JoDexTw7+dmd2p0k3eHx+gkbZ91JNN/dfYOu7I7+H9+pzx9y2R+BS X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 25:93qn7/p4zZUbwSTJxWeDH3fqaMRvC3VAlTM8pAMaedjjhBeccF0auIP4VpyvdrI55S2x1xyzfMhP0YRO8iACAqLuiyYWs7Bom5ysYXtRYmjrwvtyjZkP9chSQlzR1CmIf2uBSez61DeyJctncxHy0qdVmmESaBHKGJ5WyoAbkHOkgfnFlI+y3ZHlrsmvZftHL4cwE0yYO0fHmyWA0aRI6YeU3kl4ZqoHLZZ3LYxNPWfj4iORDG8wnL5n2Xq6t2IMo+mwYQ2xkxBGP2AjeFp9PafxWX4HjhmzSUHJCTATtzGGD7rwN3lKqkGd1X0F14g8Mck55NeLSLWyhv//AMTqZnJMkgoqRY5kgpm9/mMANjMPxNf3ct5viDffnFTgQMu51+JjXqa+f3JUDAmEISLGb7MSWrmdmfLEF1GU0uTTU/RZ804eK+o8B0nMh6YFyTx6r1n6pbZy6/RFwNavocK+9ql0RirAzr6RIHQXLXwlk6q0cFPbUOW4BugYG78Rsm6/5zckZuAebBLX+g9Ec3KWfBZ3sUqtkjeDttZJdMTDDigN2sjsJNbzTLIzUWLxQoTn+iN3amEZlzEwhyO3rr6u7bHX3ETr9U556cTtPtTVt3HK94KrR7T0tAtWNNg6NXYMKVLIv0eLKPMzmfrshaoWnB1IHW/621+DEvEQhda3vae5Prcn4vzzGhYoHcY1q9nSCrFST+HdVB6MNheEoU4OyUFNIi/KJriqb7W5NjYiHQ0pvyd2KPNPg8imwJtTQZPIQLz8xLkzNlvkSZZIuC5nfkb682I9nwCSFoePa5cqTOEdE9Fw1tfvwVVj12Q627Ur6dJl19OhPO2PYLg7y4cg6UO3bXPhneb5E/5vYyBKnHM= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 31:BC93ThSaT29z8ABXZsleeGem0mN1FhvdcHXtnMUt9Y8y7b4u5obk6Of+DIOYVnvh3mGXUpOaDs7SMMgukpPkhPj1I50KXXEnf1i20bBnjCnZCjOc0yGmRtbZF1eEscQeirZGoY08M5hWr9N1imq5vamLOvVCAqY37lfxtKbOZodntDVJ1Cj3NECAInhjklQZ7+QkEtipUv17MJi8LE+MkTokgFxllSh7VOyrDcnxRGU=; 20:tSm/jVREqpcBeCYVgf33+jPv9jMZ6hriwRgcMLouY9hJvoqNwnjOW84rV8b79VjceaMIqg87Sdrdx+W704N7Lrxtt8ZiXOPxeoRw+duJ5THQMuOYhhcngI5iAOg6Crft8JZkFqld3LPbf4YA9Ubfvy0t2vMvh6djZNpc+dPQOtzRWcu7KcnaGMGhhE7ultjTTBQZS0H1J+UaRCB0OD8dovmQZ4qa8/14nbf3XqakHEkTp1wjYXXwaItbAaXqK9zan5Abb+/SJla2PB2aZLRMvVWWEyLrluXR8M1L8htlN9+4q8y3Rwu1hBJHbCO3D6olBlV1lfI9VFZWeWecpKPyPU6+K92OmDCdSURk2SocnUROmd65ru/5kx2O6/ipU+l5gQ2XVnxSObzEz3ALHCgGtwa2TuhgXRLubt/yjNnw4C9O+Uf0aEHInQwXNMDdXbYie6m6UMCJEHhSvpu3d4dU+WplJrm2FSCexZYdRUnWhiIBRTShnCoVQjoLSBBFLoMqAlNKqkC2tKbXGRtbktDOQ5mzkknaIKNMvbKBWXsLrBvUUF1Cyrfruz5d3GnJvJjk7TejxcI3v8bKdgVUNiuKYur2VZUJwX8tABeI/AkGHjE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:BLUPR0701MB1715; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 4:RyVJy66HPGhMJDZdrMvhsXeKi4/6E/WTYIkDaK0velE1VwmerXRmLD7veNq+UqZt6aBiAfc50GpfY9TslJS+BJF2i0/bp5lHrwPRGCPn7fpI2tfhPrehg+VpnZzc+29PCu7Acyf7jEB44YJemKvJpHSF1UeTw+pdI2YUUckhDOgckJZiDrV69IPLKbQJqWTes5zE1GsQqJZ7SZzudi2idg2xjIj8oIc5SNkRWA9jDmf6prlD1LYB58seEd7vt1c9Au9RQ51X/MbtA6LBm89G11TDLMNNHJue7iaypubq0RQLnqqUH5N/vbMkoqBjkbne71c+eru7qKzcFYeKofoQmERtFUZYQ7ozI6TEhcUmReOXvjOPmJhL1A2Qb4VsLcWrD07DQmxBN8LLMRwcL8qbqYL38pqR5JRSo9cZcLbQwtzUE+gAMTWekGTTw0xiCp6R X-Forefront-PRVS: 0070A8666B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(979002)(6009001)(6069001)(7916002)(13464003)(189002)(24454002)(199003)(1076002)(61506002)(5660300001)(81156014)(8676002)(77096005)(15975445007)(101416001)(97736004)(50466002)(106356001)(19580395003)(19580405001)(110136003)(4001350100001)(92566002)(2950100001)(83506001)(105586002)(3900700001)(76176999)(50986999)(54356999)(68736007)(305945005)(47776003)(586003)(46406003)(2906002)(93886004)(42186005)(15395725005)(3846002)(189998001)(6116002)(9686002)(81166006)(97756001)(4326007)(23726003)(7846002)(66066001)(33656002)(7736002)(18370500001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1715; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1715; 23:6YQLgRPxZfWRVwDuLKauTFE8tO0gKS6054X+wv6?= =?us-ascii?Q?B64KAF3hQ3qGXqHMDgoMfjhEtnyCd+0mqE0p2diCAXqgVVty8p/p8FjX/LCa?= =?us-ascii?Q?nd0CQvHOM0blFeMl0drozUSz4lPvzR892lZPtsNXkguYqZncdbQTXzdK5mwn?= =?us-ascii?Q?h1L8ct1yL4OfFGX1+oqn3TI06v/PpI9psYlxBQKJTSTIH+8V0mWMNydSgNiS?= =?us-ascii?Q?7+nVbm+iG2AVj4bo9AbQg6B12i//b0ORjb6H1z+p1eLQDpyM9wp0ITqTwUJ4?= =?us-ascii?Q?moxbad+qixo6RWrQniPAtJGr/UfcL9PhOuOw8BtKqdxrvOJzkMp06OWK281P?= =?us-ascii?Q?RLvIz/Gt4NGm8gJ/vaVpzpA28SJN7KA59S65OnhSn5Zp5CzbPimipiS42518?= =?us-ascii?Q?BFDKRcV9XAAzR5b45LyCrLzlg9Yh2sOTEhIfp+cIrEJEjdw4r4h3MYLYwtzd?= =?us-ascii?Q?XX7NAYk4CbnPuPD82ogdOl+z6YMx7JocsjLDMshE3RoHxhu5P2mZsg23asus?= =?us-ascii?Q?b+Dt0DVF58SbHxLePYOfYOO7m/EyGKlVhMjybrtQjaFuzlkLlt9Nf2VCZRSk?= =?us-ascii?Q?ghJ+iLIIgRD138FI6Mbl7wV3K6dlafuwNSEXJJBqzsZ0leE1CboE6G9WUoGT?= =?us-ascii?Q?IpPvKv3zD8T1vQ7k/1itW84Cij18IagIHBHYfySJxk9Y2YBa8WhWla8Dm+6q?= =?us-ascii?Q?jhHuiMHu8PO0fp9bwYKg0LXLrJHXOpQ7ygejMbXeWsz02yya17XtBL+5MgVs?= =?us-ascii?Q?yei+0E/iilCANkZJ08JShX0j5Uqk2UHdMLjdu96fKiHIVsymhwz/zVA67WWG?= =?us-ascii?Q?b2f6AEzmR192cMN3oOdDSfgZjal8RQHh3bmJR3CEh0/a8+VYl+VdVISFzWbw?= =?us-ascii?Q?GbUY5Yz3+8DV/ZZyjYrOk4qbwFeGRZjTqQAEJpVExS4D9Pm1Ucmv0iFrXHz/?= =?us-ascii?Q?gjimbPBXu2EQcHAO/rFrRse32MeGzREEfIGkbXqld+I19GsHOakr/cEMmvLH?= =?us-ascii?Q?6M0WxteaKivC1MlkJNKS2Y1B03ZSufMF40O4Avqq5PYsEEJmq3Z2SEpIhGu4?= =?us-ascii?Q?k2E8gqopJ4pXk5gdnM32OrvxtprETB+vtNqpBLk4lEojpYj2pmDcS5mQQ2+n?= =?us-ascii?Q?P8EKA+B1TLZTnDJvHZurrQwcmprAoAXFVfOs+YJvjCRzzRU13PzaEa2WrPWF?= =?us-ascii?Q?9v9nqec63XL2ozhsfn+s6o4KDNNMs4ogyIBEESR7JxzxdQLWd46kSgASPb7S?= =?us-ascii?Q?GwzykCmAvC4xwC5kPhTjYFSkuR9+8ScyDQSClUH35+vPVjvBSe5GhwdYmgT1?= =?us-ascii?Q?ZGCZwYPPzwYosS04aKcrj29sHyS8ax37qnxzeB1xHhsgtFTvtaPcPXtJAHdX?= =?us-ascii?Q?wCvLl9JBB6GfL2ODaVD1CRj6BW91UpzBBl94mF/IbwqfE+F0NiJLkBjTtJrJ?= =?us-ascii?Q?bpJLwb4oqkg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 6:OUi7SdA+gnHPjA4jHmVHp78jgC8piMdEXL/jk39MGTUYF2tCtzCeRAmtosBui6mhwBrLBVytAYpZwNG5VaHtFkIkJRb6s4epnN5TWubRT0GfDlFW31Gi6fB8Z/yIkdahEWi5rMrG8ERks+TBldKgswIg+2SSv8SONwh+oEglv5NnzkeEg6b/pKnibUmS5vvmP2Q1upWuSquzGI6mL8M9PVDafVhUohRnswL9m+ie57n1RamWB//szE6AZpBwCVelcJVxTwcIJ80PSzDdX+gsMOLL028Xf80v35SLsE5J1dg=; 5:AwRyOjCf2tQs8EqjMmvucY/fRiwXqzFkTeaRbD/WO1RkdCJCrfA9zGE4P5CGWu/qm1Jf1z2Uw6361lR9dKH4Dcrv91pAYgD7i/PbmLm0OVitbh97gc+nBbojeA1BC56Fq+RCMw+YdmRvTgJgrrw6bA==; 24:pRkMDr+7wWacsu0DxL5/LMZ2/r6JfgjPIBO/BSJndTacj5K4vzBLSiSz5aG/+lfsRKn4P8idEfrZ3sZYlJGA7k95rHCblpWWIvUO5K3Iyc8=; 7:XmOq3K+ft21F8OHsniFYAj/kKtdM2z2J7Z35pBVeOlt8ZU8YfPolPUfFt6Rmn6DZkjKGiv2ye4FxDqZk3KhnIqTY4EeCHbmx/uxCCXJkcjA2GX1T0HCyiQBwsBOet8jru+0/LgEA/T2gguQ5a2CQD4jAvTx/+eSN53NSgwfoBqu3zOIuVelgOWIv24y3uBpYZmyFdAI8agiIjWjTHqXVCsQRczU+YRI4gbKYnCq0Tpys6Thzv15zS9T1+cXAKtNNhwJ4hBg3DT1WwvIB+PeZYds+Nn4+G902KiNy4bWrdplkT+AZzzPLd5qfqLwg+ye4 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2016 16:06:53.2338 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1715 Subject: Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add Tx preparation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2016 16:06:57 -0000 On Mon, Sep 19, 2016 at 03:29:07PM +0000, Kulasek, TomaszX wrote: > Hi Konstantin, > > > -----Original Message----- > > From: Ananyev, Konstantin > > Sent: Monday, September 19, 2016 15:03 > > To: Kulasek, TomaszX ; dev@dpdk.org > > Cc: jerin.jacob@caviumnetworks.com > > Subject: RE: [dpdk-dev] [PATCH v2 1/6] ethdev: add Tx preparation > > > > Hi Tomasz, > > > > > > > [...] > > > > + > > > +#ifdef RTE_ETHDEV_TX_PREP > > > > Sorry for being a bit late on that discussion, but what the point of > > having that config macro (RTE_ETHDEV_TX_PREP ) at all? > > As I can see right now, if driver doesn't setup tx_pkt_prep, then nb_pkts > > would be return anyway... > > > > BTW, there is my another question - should it be that way? > > Shouldn't we return 0 (and set rte_errno=ENOTSUP) here if dev->tx_pk_prep > > == NULL? > > > > It's an answer to the Jerin's request discussed here: http://dpdk.org/ml/archives/dev/2016-September/046437.html > > When driver doesn't support tx_prep, default behavior is "we don't know requirements, so we have nothing to do here". It will simplify application logic and improve performance for these drivers, I think. Catching this error with every burst may be problematic. > > As for RTE_ETHDEV_TX_PREP macro, suggested by Jerin in the same thread, I still don't think It's the best solution of the problem described by him. I have added it here for further discussion. > > Jerin, have you something to add? Nothing very specific to add here. I think, I have tried to share the rational in, http://dpdk.org/ml/archives/dev/2016-September/046437.html > > Tomasz.