From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id D497D6CBB for ; Tue, 20 Sep 2016 14:51:33 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id l132so207591556wmf.0 for ; Tue, 20 Sep 2016 05:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=1W7AJFT0/V1wWxa8Vj5tNZKHz0ilpk51LNZMfumLtKc=; b=eU7tLfobb7gKqQb+NNpsrMm1hgtWjrbJTZRY+5WsMUVW8DBCvH3mWmKjNjQkY3fukK /QygylVVY4diGp9AqMP7Jl7ScgzH4pO/pUylCwXUgpUYgWypLCFUeMzTOadTSIsTB8g3 miof1NCGT4tSpE1NJ2qW6tZ5s0kxQ9CGqqVzKYg2GC8RXRnCzMN5Yyny7O1XGNx9w3xB qdN6AVrK3P+1meA/YHUpl2y0hWdOWZV8vUgQxBbHBTX5egCLSsLIvQYPcomFNDcwlJEO ncb/mY8V6k4B0WWxjiL0vDj1WJkg+rVZ22z849uBASN0slDKZKr2qJwBffKKgIWz4cSA T+tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=1W7AJFT0/V1wWxa8Vj5tNZKHz0ilpk51LNZMfumLtKc=; b=aOjOaFoRSNLNFmDzs14vHECC/UtWm0QCGxU5an+2umuJoXNrTc2ZCOApzZzEfSchyt 6isZ+36/GzWQBjYOTDekdlDdRWCil59Pn8nSewZLLNKb39D9HeuDpevLm3K+r8bwFTD+ h6PMqupLQ5/3+92rSENbD++Gd6v+4bdmlGC69ukWklm/WqSJ39Z8MDPrLODgxK9LsbiT Oz/bAUjiESz9db0Hc3kaprt5cvYanoKfAMJ53OsGJxolkUY5LMotnTiKSm4LgKyi/eJd jDeWvhviU1Ta4286cMueRXV+ZuOMbaKMLWeehBbiLZZ9I37rA+RyZmxTqM0CaUjwyDYi dqkw== X-Gm-Message-State: AE9vXwOREZ8j9a7Iohd/g1GPfM+6wCGQeQQu5p2hb2nO+YgqSZN0KsEyHVEKuy4fKhuHQl2p X-Received: by 10.28.199.14 with SMTP id x14mr3409185wmf.106.1474375893587; Tue, 20 Sep 2016 05:51:33 -0700 (PDT) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id p13sm27306213wmd.1.2016.09.20.05.51.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Sep 2016 05:51:33 -0700 (PDT) Date: Tue, 20 Sep 2016 14:51:27 +0200 From: Adrien Mazarguil To: Bruce Richardson Cc: dev@dpdk.org Message-ID: <20160920125126.GG17252@6wind.com> References: <1474295814-4879-1-git-send-email-bruce.richardson@intel.com> <20160919145959.GB17252@6wind.com> <20160919152605.GG45548@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160919152605.GG45548@bricha3-MOBL3> Subject: Re: [dpdk-dev] [PATCH] net/mlx: fix compile errors with ignore pedantic pragma X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 12:51:34 -0000 On Mon, Sep 19, 2016 at 04:26:05PM +0100, Bruce Richardson wrote: > On Mon, Sep 19, 2016 at 04:59:59PM +0200, Adrien Mazarguil wrote: > > Hi Bruce, > > > > On Mon, Sep 19, 2016 at 03:36:54PM +0100, Bruce Richardson wrote: > > > With recent gcc versions, e.g. gcc 6.1, compilation of mlx drivers with > > > debug enabled produces lots of errors complaining that "pedantic" is > > > not a warning level that can be ignored. > > > > > > error: ‘-pedantic’ is not an option that controls warnings [-Werror=pragmas] > > > #pragma GCC diagnostic ignored "-pedantic" > > > ^~~~~~~~~~~ > > > > > > These errors can be removed by changing the "-pedantic" to "-Wpedantic". > > > > Nice to have a workaround, I thought they did not keep the option at all. > > However after testing: > > > > - It does not seem to work with GCC 4.6 and older, they prefer -pedantic: > > "warning: unknown option after `#pragma GCC diagnostic' kind". > > > > - GCC 4.9 (possibly 5.x as well) does not care, can use either -pedantic or > > -Wpedantic. > > > > - GCC 6 can only supports -Wpedantic. > > > > Note we're working toward removing the need for these #pragma in the first > > place as soon as possible, however in the meantime I fear that checking the > > GCC version is necessary. > > > Depends on how old of GCC version we need to support. From the release notes > it appears that -Wpedantic was introduced in GCC 4.8 (3 1/2 years ago). > > https://gcc.gnu.org/gcc-4.8/changes.html > > Do we need to support compilation on gcc versions older than this? I'm all for upgrading so I do not really mind if we stop caring about older GCC versions (especially considering this problem only occurs in debugging mode which is seldom used by non-developers). The version check is necessary if we want to keep full compatibility with at least: - RHEL <= 6.x - Debian <= 7.x - Ubuntu <= 13.04 Works for me either way, thus: Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND