From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id CAEC4968 for ; Wed, 21 Sep 2016 12:59:43 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 21 Sep 2016 03:59:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,373,1470726000"; d="scan'208";a="882243010" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.210.133]) by orsmga003.jf.intel.com with SMTP; 21 Sep 2016 03:59:41 -0700 Received: by (sSMTP sendmail emulation); Wed, 21 Sep 2016 11:59:40 +0025 Date: Wed, 21 Sep 2016 11:59:40 +0100 From: Bruce Richardson To: Nelson Escobar Cc: dev@dpdk.org Message-ID: <20160921105940.GF16464@bricha3-MOBL3> References: <1470778924-6794-1-git-send-email-neescoba@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470778924-6794-1-git-send-email-neescoba@cisco.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] net/enic: move link checking init to probe time X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2016 10:59:44 -0000 On Tue, Aug 09, 2016 at 02:42:04PM -0700, Nelson Escobar wrote: > The enic DMAs link status information to the host and this requires a > little setup. This setup was being done as a result of calling > rte_eth_dev_start(). But applications expect to be able to check link > status before calling rte_eth_dev_start(). > > This patch moves he link status setup to enic_init() which is called > at device probe time so that link status can be checked anytime. > > Fixes: fefed3d1e62c ("enic: new driver") > > Signed-off-by: Nelson Escobar > Reviewed-by: John Daley Applied to dpdk-next-net/rel_16_11 /Bruce