From: Bruce Richardson <bruce.richardson@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/5] bnxt: Add support for new HWRM version
Date: Wed, 21 Sep 2016 12:07:20 +0100 [thread overview]
Message-ID: <20160921110719.GG16464@bricha3-MOBL3> (raw)
In-Reply-To: <1471302415-12019-4-git-send-email-ajit.khaparde@broadcom.com>
On Mon, Aug 15, 2016 at 06:06:53PM -0500, Ajit Khaparde wrote:
> Update HWRM specification to 1.3.0 release.
> Hardware Resource Manager or HWRM in short, is a set of API provided
> by the firmware running in the ASIC to manage the various resources.
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> drivers/net/bnxt/hsi_struct_def_dpdk.h | 4731 +++++++++++++++++---------------
> 1 file changed, 2445 insertions(+), 2286 deletions(-)
>
Hi Ajit,
this patch is large, but seems to have quite a number of changes for indentation
e.g. indentation of comments, and other whitespace changes. Can these changes
be split out to make the diff smaller and code changes easier to see?
Regards,
/Bruce
next prev parent reply other threads:[~2016-09-21 11:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 23:06 [dpdk-dev] [PATCH 0/5] bnxt patchset Ajit Khaparde
2016-08-15 23:06 ` [dpdk-dev] [PATCH 1/5] bnxt: Add support for Broadcom StrataGX Communication Processors Ajit Khaparde
2016-08-15 23:06 ` [dpdk-dev] [PATCH 2/5] bnxt: Enable support for NPAR 1.0 feature Ajit Khaparde
2016-08-15 23:06 ` [dpdk-dev] [PATCH 3/5] bnxt: Add support for new HWRM version Ajit Khaparde
2016-09-21 11:07 ` Bruce Richardson [this message]
2016-09-21 15:37 ` Ajit Khaparde
2016-08-15 23:06 ` [dpdk-dev] [PATCH 4/5] bnxt: Add support for new DIDs Ajit Khaparde
2016-08-15 23:06 ` [dpdk-dev] [PATCH 5/5] bnxt: Update Broadcom PMD driver documentation Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921110719.GG16464@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).