From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4E98F2142 for ; Wed, 21 Sep 2016 13:07:23 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 21 Sep 2016 04:07:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,373,1470726000"; d="scan'208";a="882245849" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.210.133]) by orsmga003.jf.intel.com with SMTP; 21 Sep 2016 04:07:20 -0700 Received: by (sSMTP sendmail emulation); Wed, 21 Sep 2016 12:07:20 +0025 Date: Wed, 21 Sep 2016 12:07:20 +0100 From: Bruce Richardson To: Ajit Khaparde Cc: dev@dpdk.org Message-ID: <20160921110719.GG16464@bricha3-MOBL3> References: <1471302415-12019-1-git-send-email-ajit.khaparde@broadcom.com> <1471302415-12019-4-git-send-email-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471302415-12019-4-git-send-email-ajit.khaparde@broadcom.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 3/5] bnxt: Add support for new HWRM version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2016 11:07:23 -0000 On Mon, Aug 15, 2016 at 06:06:53PM -0500, Ajit Khaparde wrote: > Update HWRM specification to 1.3.0 release. > Hardware Resource Manager or HWRM in short, is a set of API provided > by the firmware running in the ASIC to manage the various resources. > > Signed-off-by: Ajit Khaparde > --- > drivers/net/bnxt/hsi_struct_def_dpdk.h | 4731 +++++++++++++++++--------------- > 1 file changed, 2445 insertions(+), 2286 deletions(-) > Hi Ajit, this patch is large, but seems to have quite a number of changes for indentation e.g. indentation of comments, and other whitespace changes. Can these changes be split out to make the diff smaller and code changes easier to see? Regards, /Bruce