From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 841442716 for ; Wed, 21 Sep 2016 13:19:41 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 21 Sep 2016 04:19:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,373,1470726000"; d="scan'208";a="1034140026" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.210.133]) by orsmga001.jf.intel.com with SMTP; 21 Sep 2016 04:19:38 -0700 Received: by (sSMTP sendmail emulation); Wed, 21 Sep 2016 12:19:38 +0025 Date: Wed, 21 Sep 2016 12:19:38 +0100 From: Bruce Richardson To: John Daley Cc: dev@dpdk.org Message-ID: <20160921111937.GJ16464@bricha3-MOBL3> References: <1471472126-8103-1-git-send-email-johndale@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471472126-8103-1-git-send-email-johndale@cisco.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] net/enic: bad L4 checksum ptype set on ICMP packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2016 11:19:42 -0000 On Wed, Aug 17, 2016 at 03:15:26PM -0700, John Daley wrote: > The bad L4 checksum flag was set on IP packets which were not > also TCP or UDP packets. This includes ICMP, IGMP and OSPF packets. > > L4 ptypes were being treated as bits instead of values within the > L4 mask causing the code to check L4 checksum in the completion > queue and incorrectly set the L4 bad checksum flag. > > Fixes: 947d860c821f ("enic: improve Rx performance") > > Reviewed-by: Nelson Escobar > Signed-off-by: John Daley Applied to dpdk-next-net/rel_16_11 /Bruce