* [dpdk-dev] [PATCH] fix to use index to HW queue assigned to PF instead of queus 0 - nb_rx_queues which belong to VF in SR-IOV configuration
@ 2016-08-26 10:09 azelezniak
2016-08-26 10:55 ` Ferruh Yigit
2016-08-30 1:23 ` [dpdk-dev] [PATCH v2] net/ixgbe: use queues assigned to PF instad of VF Alex Zelezniak
0 siblings, 2 replies; 6+ messages in thread
From: azelezniak @ 2016-08-26 10:09 UTC (permalink / raw)
To: dev; +Cc: wenzhuo.lu, Alex Zelezniak
From: Alex Zelezniak <alexz@att.com>
Signed-off-by: Alex Zelezniak <alexz@att.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index bc2ad4b..d8d32f7 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -1779,6 +1779,7 @@ ixgbe_vlan_hw_strip_disable_all(struct rte_eth_dev *dev)
IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
uint32_t ctrl;
uint16_t i;
+ struct ixgbe_rx_queue *rxq;
PMD_INIT_FUNC_TRACE();
@@ -1789,9 +1790,10 @@ ixgbe_vlan_hw_strip_disable_all(struct rte_eth_dev *dev)
} else {
/* Other 10G NIC, the VLAN strip can be setup per queue in RXDCTL */
for (i = 0; i < dev->data->nb_rx_queues; i++) {
- ctrl = IXGBE_READ_REG(hw, IXGBE_RXDCTL(i));
+ rxq = dev->data->rx_queues[i];
+ ctrl = IXGBE_READ_REG(hw, IXGBE_RXDCTL(rxq->reg_idx));
ctrl &= ~IXGBE_RXDCTL_VME;
- IXGBE_WRITE_REG(hw, IXGBE_RXDCTL(i), ctrl);
+ IXGBE_WRITE_REG(hw, IXGBE_RXDCTL(rxq->reg_idx), ctrl);
/* record those setting for HW strip per queue */
ixgbe_vlan_hw_strip_bitmap_set(dev, i, 0);
@@ -1806,6 +1808,7 @@ ixgbe_vlan_hw_strip_enable_all(struct rte_eth_dev *dev)
IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
uint32_t ctrl;
uint16_t i;
+ struct ixgbe_rx_queue *rxq;
PMD_INIT_FUNC_TRACE();
@@ -1816,9 +1819,10 @@ ixgbe_vlan_hw_strip_enable_all(struct rte_eth_dev *dev)
} else {
/* Other 10G NIC, the VLAN strip can be setup per queue in RXDCTL */
for (i = 0; i < dev->data->nb_rx_queues; i++) {
- ctrl = IXGBE_READ_REG(hw, IXGBE_RXDCTL(i));
+ rxq = dev->data->rx_queues[i];
+ ctrl = IXGBE_READ_REG(hw, IXGBE_RXDCTL(rxq->reg_idx));
ctrl |= IXGBE_RXDCTL_VME;
- IXGBE_WRITE_REG(hw, IXGBE_RXDCTL(i), ctrl);
+ IXGBE_WRITE_REG(hw, IXGBE_RXDCTL(rxq->reg_idx), ctrl);
/* record those setting for HW strip per queue */
ixgbe_vlan_hw_strip_bitmap_set(dev, i, 1);
--
2.5.4 (Apple Git-61)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] fix to use index to HW queue assigned to PF instead of queus 0 - nb_rx_queues which belong to VF in SR-IOV configuration
2016-08-26 10:09 [dpdk-dev] [PATCH] fix to use index to HW queue assigned to PF instead of queus 0 - nb_rx_queues which belong to VF in SR-IOV configuration azelezniak
@ 2016-08-26 10:55 ` Ferruh Yigit
2016-08-26 15:57 ` Stephen Hemminger
2016-08-30 1:23 ` [dpdk-dev] [PATCH v2] net/ixgbe: use queues assigned to PF instad of VF Alex Zelezniak
1 sibling, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2016-08-26 10:55 UTC (permalink / raw)
To: azelezniak, dev; +Cc: wenzhuo.lu
Hi Alex,
On 8/26/2016 11:09 AM, azelezniak wrote:
> From: Alex Zelezniak <alexz@att.com>
>
> Signed-off-by: Alex Zelezniak <alexz@att.com>
> ---
Thank you for the patch, not related to the patch content but related to
the patch format:
patch subject is too long, it is expected to be around 50 characters,
can you please move some of information to the patch commit log?
Also since this is a fix, commit log requires a Fixes line.
More details on:
http://dpdk.org/doc/guides/contributing/patches.html#sending-patches
Thanks,
ferruh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] fix to use index to HW queue assigned to PF instead of queus 0 - nb_rx_queues which belong to VF in SR-IOV configuration
2016-08-26 10:55 ` Ferruh Yigit
@ 2016-08-26 15:57 ` Stephen Hemminger
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2016-08-26 15:57 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: azelezniak, dev, wenzhuo.lu
On Fri, 26 Aug 2016 11:55:40 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> Hi Alex,
>
> On 8/26/2016 11:09 AM, azelezniak wrote:
> > From: Alex Zelezniak <alexz@att.com>
> >
> > Signed-off-by: Alex Zelezniak <alexz@att.com>
> > ---
>
> Thank you for the patch, not related to the patch content but related to
> the patch format:
> patch subject is too long, it is expected to be around 50 characters,
> can you please move some of information to the patch commit log?
>
> Also since this is a fix, commit log requires a Fixes line.
>
> More details on:
> http://dpdk.org/doc/guides/contributing/patches.html#sending-patches
>
> Thanks,
> ferruh
>
The subject line of the patch email becomes the first line of the
git commit message. This also documented on 'git commit' man page.
DISCUSSION
Though not required, it’s a good idea to begin the commit message with
a single short (less than 50 character) line summarizing the change,
followed by a blank line and then a more thorough description.
Overly long summary lines are flagged as errors by tools like Debian lintian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] net/ixgbe: use queues assigned to PF instad of VF
2016-08-26 10:09 [dpdk-dev] [PATCH] fix to use index to HW queue assigned to PF instead of queus 0 - nb_rx_queues which belong to VF in SR-IOV configuration azelezniak
2016-08-26 10:55 ` Ferruh Yigit
@ 2016-08-30 1:23 ` Alex Zelezniak
2016-09-08 0:55 ` Lu, Wenzhuo
1 sibling, 1 reply; 6+ messages in thread
From: Alex Zelezniak @ 2016-08-30 1:23 UTC (permalink / raw)
To: dev; +Cc: wenzhuo.lu, ferruh.yigit, stephen, azelezniak
From: azelezniak <alexz@att.com>
v2:
* shorten Subject line
* added more thorough description
v1:
this patch uses queues which belong to PF instead of queus 0 -
nb_rx_queues which belong to VF0 in SR-IOV configuration
Signed-off-by: Alex Zelezniak <alexz@att.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index bc2ad4b..d8d32f7 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -1779,6 +1779,7 @@ ixgbe_vlan_hw_strip_disable_all(struct rte_eth_dev *dev)
IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
uint32_t ctrl;
uint16_t i;
+ struct ixgbe_rx_queue *rxq;
PMD_INIT_FUNC_TRACE();
@@ -1789,9 +1790,10 @@ ixgbe_vlan_hw_strip_disable_all(struct rte_eth_dev *dev)
} else {
/* Other 10G NIC, the VLAN strip can be setup per queue in RXDCTL */
for (i = 0; i < dev->data->nb_rx_queues; i++) {
- ctrl = IXGBE_READ_REG(hw, IXGBE_RXDCTL(i));
+ rxq = dev->data->rx_queues[i];
+ ctrl = IXGBE_READ_REG(hw, IXGBE_RXDCTL(rxq->reg_idx));
ctrl &= ~IXGBE_RXDCTL_VME;
- IXGBE_WRITE_REG(hw, IXGBE_RXDCTL(i), ctrl);
+ IXGBE_WRITE_REG(hw, IXGBE_RXDCTL(rxq->reg_idx), ctrl);
/* record those setting for HW strip per queue */
ixgbe_vlan_hw_strip_bitmap_set(dev, i, 0);
@@ -1806,6 +1808,7 @@ ixgbe_vlan_hw_strip_enable_all(struct rte_eth_dev *dev)
IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
uint32_t ctrl;
uint16_t i;
+ struct ixgbe_rx_queue *rxq;
PMD_INIT_FUNC_TRACE();
@@ -1816,9 +1819,10 @@ ixgbe_vlan_hw_strip_enable_all(struct rte_eth_dev *dev)
} else {
/* Other 10G NIC, the VLAN strip can be setup per queue in RXDCTL */
for (i = 0; i < dev->data->nb_rx_queues; i++) {
- ctrl = IXGBE_READ_REG(hw, IXGBE_RXDCTL(i));
+ rxq = dev->data->rx_queues[i];
+ ctrl = IXGBE_READ_REG(hw, IXGBE_RXDCTL(rxq->reg_idx));
ctrl |= IXGBE_RXDCTL_VME;
- IXGBE_WRITE_REG(hw, IXGBE_RXDCTL(i), ctrl);
+ IXGBE_WRITE_REG(hw, IXGBE_RXDCTL(rxq->reg_idx), ctrl);
/* record those setting for HW strip per queue */
ixgbe_vlan_hw_strip_bitmap_set(dev, i, 1);
--
2.5.4 (Apple Git-61)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/ixgbe: use queues assigned to PF instad of VF
2016-08-30 1:23 ` [dpdk-dev] [PATCH v2] net/ixgbe: use queues assigned to PF instad of VF Alex Zelezniak
@ 2016-09-08 0:55 ` Lu, Wenzhuo
2016-09-21 12:47 ` Bruce Richardson
0 siblings, 1 reply; 6+ messages in thread
From: Lu, Wenzhuo @ 2016-09-08 0:55 UTC (permalink / raw)
To: Alex Zelezniak, dev; +Cc: Yigit, Ferruh, stephen
Hi,
> -----Original Message-----
> From: Alex Zelezniak [mailto:alexz@att.com]
> Sent: Tuesday, August 30, 2016 9:23 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo; Yigit, Ferruh; stephen@networkplumber.org; azelezniak
> Subject: [PATCH v2] net/ixgbe: use queues assigned to PF instad of VF
>
> From: azelezniak <alexz@att.com>
>
> v2:
> * shorten Subject line
> * added more thorough description
>
> v1:
> this patch uses queues which belong to PF instead of queus 0 - nb_rx_queues
> which belong to VF0 in SR-IOV configuration
>
> Signed-off-by: Alex Zelezniak <alexz@att.com>
Acked-by: Wenzhuo Lu <Wenzhuo.lu@intel.com>
Thanks for the patch:)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/ixgbe: use queues assigned to PF instad of VF
2016-09-08 0:55 ` Lu, Wenzhuo
@ 2016-09-21 12:47 ` Bruce Richardson
0 siblings, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2016-09-21 12:47 UTC (permalink / raw)
To: Lu, Wenzhuo; +Cc: Alex Zelezniak, dev, Yigit, Ferruh, stephen
On Thu, Sep 08, 2016 at 12:55:00AM +0000, Lu, Wenzhuo wrote:
> Hi,
>
> > -----Original Message-----
> > From: Alex Zelezniak [mailto:alexz@att.com]
> > Sent: Tuesday, August 30, 2016 9:23 AM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo; Yigit, Ferruh; stephen@networkplumber.org; azelezniak
> > Subject: [PATCH v2] net/ixgbe: use queues assigned to PF instad of VF
> >
> > From: azelezniak <alexz@att.com>
> >
> > v2:
> > * shorten Subject line
> > * added more thorough description
> >
> > v1:
> > this patch uses queues which belong to PF instead of queus 0 - nb_rx_queues
> > which belong to VF0 in SR-IOV configuration
> >
> > Signed-off-by: Alex Zelezniak <alexz@att.com>
> Acked-by: Wenzhuo Lu <Wenzhuo.lu@intel.com>
> Thanks for the patch:)
>
Applied to dpdk-next-net/rel_16_11 with updated title "net/ixgbe: fix VF
reset to apply to correct VF".
Regards,
/Bruce
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-21 12:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-26 10:09 [dpdk-dev] [PATCH] fix to use index to HW queue assigned to PF instead of queus 0 - nb_rx_queues which belong to VF in SR-IOV configuration azelezniak
2016-08-26 10:55 ` Ferruh Yigit
2016-08-26 15:57 ` Stephen Hemminger
2016-08-30 1:23 ` [dpdk-dev] [PATCH v2] net/ixgbe: use queues assigned to PF instad of VF Alex Zelezniak
2016-09-08 0:55 ` Lu, Wenzhuo
2016-09-21 12:47 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).