From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: fix build error with clang
Date: Fri, 23 Sep 2016 14:43:05 +0800 [thread overview]
Message-ID: <20160923064305.GV23158@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20160923063513.GA4321@localhost.localdomain>
On Fri, Sep 23, 2016 at 12:05:14PM +0530, Jerin Jacob wrote:
> On Fri, Sep 23, 2016 at 02:15:09PM +0800, Yuanhan Liu wrote:
>
> Hi Yuanhan,
>
> Thanks for this patch.
>
> > Interestingly, clang and gcc has different prototype for _mm_prefetch().
> > For gcc, we have
> >
> > _mm_prefetch (const void *__P, enum _mm_hint __I)
> >
> > While for clang, it's
> >
> > #define _mm_prefetch(a, sel) (__builtin_prefetch((void *)(a), 0, (sel)))
> >
> > That how the following error comes with clang:
> >
> > error: cast from 'const void *' to 'void *' drops const qualifier
> > [-Werror,-Wcast-qual]
> > _mm_prefetch((const void *)rused, _MM_HINT_T0);
> > /usr/lib/llvm-3.8/bin/../lib/clang/3.8.0/include/xmmintrin.h:684:58:
> > note: expanded from macro '_mm_prefetch'
> > #define _mm_prefetch(a, sel) (__builtin_prefetch((void *)(a),
> > 0, (sel)))
> >
> > What's weird is that the build was actaully Okay before. I met it while
> > apply Jerin's vector support for ARM patch set: he just move this peiece
> > of code to another file, nothing else changed.
> >
> > This patch fix the issue when Jerin's patchset is applied. Thus, I think
> > it's still needed.
>
> The info notes can be moved under the "---" marker line to make git log
> clean.
Yes, kind of. The reason I want to put it here is to stree "how weird
this issue it is" :)
Without this piece, people may be confused why this patch is necessary,
because they may simply can't reproduce this issue.
> This patch review is holding the virtio arm NEON support. Appreciate any help
> in reviewing this patch.
>
> http://dpdk.org/dev/patchwork/patch/14567/
I meant to apply this series long time ago, until I found a build issue.
I tried to fix it once, as you saw. But it somehow broke the icc.
And here is my 2nd try (sorry for being a bit late though).
--yliu
next prev parent reply other threads:[~2016-09-23 6:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 7:40 [dpdk-dev] [PATCH] " Yuanhan Liu
2016-09-23 6:11 ` Yuanhan Liu
2016-09-23 6:15 ` [dpdk-dev] [PATCH v2] " Yuanhan Liu
2016-09-23 6:35 ` Jerin Jacob
2016-09-23 6:43 ` Yuanhan Liu [this message]
2016-09-23 8:31 ` Thomas Monjalon
2016-09-23 9:17 ` Yuanhan Liu
2016-09-26 4:29 ` [dpdk-dev] [PATCH v3] net: " Yuanhan Liu
2016-09-27 12:19 ` Yuanhan Liu
2016-09-27 17:24 ` Chen, Jing D
2016-09-28 0:09 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923064305.GV23158@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).