From: Stephen Hemminger <stephen@networkplumber.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
yuanhan.liu@linux.intel.com, huawei.xie@intel.com, dev@dpdk.org,
vkaplans@redhat.com
Subject: Re: [dpdk-dev] [PATCH v2] vhost: Add indirect descriptors support to the TX path
Date: Fri, 23 Sep 2016 13:28:05 -0700 [thread overview]
Message-ID: <20160923132805.3207f1fa@xeon-e3> (raw)
In-Reply-To: <20160923213055-mutt-send-email-mst@kernel.org>
On Fri, 23 Sep 2016 21:31:27 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Fri, Sep 23, 2016 at 11:24:16AM -0700, Stephen Hemminger wrote:
> > On Fri, 23 Sep 2016 09:16:49 +0200
> > Maxime Coquelin <maxime.coquelin@redhat.com> wrote:
> >
> > > Indirect descriptors are usually supported by virtio-net devices,
> > > allowing to dispatch a larger number of requests.
> > >
> > > When the virtio device sends a packet using indirect descriptors,
> > > only one slot is used in the ring, even for large packets.
> > >
> > > The main effect is to improve the 0% packet loss benchmark.
> > > A PVP benchmark using Moongen (64 bytes) on the TE, and testpmd
> > > (fwd io for host, macswap for VM) on DUT shows a +50% gain for
> > > zero loss.
> > >
> > > On the downside, micro-benchmark using testpmd txonly in VM and
> > > rxonly on host shows a loss between 1 and 4%.i But depending on
> > > the needs, feature can be disabled at VM boot time by passing
> > > indirect_desc=off argument to vhost-user device in Qemu.
> > >
> > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> >
> > What about supporting VIRTIO_F_ANY_LAYOUT?
>
> I thought it's already supported.
> That's required by virtio 1 and dpdk claims support for that.
>
I don't see the flag set in the DPDK vhost driver feature bits
(at least in the source).
/* Features supported by this lib. */
#define VHOST_SUPPORTED_FEATURES ((1ULL << VIRTIO_NET_F_MRG_RXBUF) | \
(1ULL << VIRTIO_NET_F_CTRL_VQ) | \
(1ULL << VIRTIO_NET_F_CTRL_RX) | \
(1ULL << VIRTIO_NET_F_GUEST_ANNOUNCE) | \
(VHOST_SUPPORTS_MQ) | \
(1ULL << VIRTIO_F_VERSION_1) | \
(1ULL << VHOST_F_LOG_ALL) | \
(1ULL << VHOST_USER_F_PROTOCOL_FEATURES) | \
(1ULL << VIRTIO_NET_F_HOST_TSO4) | \
(1ULL << VIRTIO_NET_F_HOST_TSO6) | \
(1ULL << VIRTIO_NET_F_CSUM) | \
(1ULL << VIRTIO_NET_F_GUEST_CSUM) | \
(1ULL << VIRTIO_NET_F_GUEST_TSO4) | \
(1ULL << VIRTIO_NET_F_GUEST_TSO6))
next prev parent reply other threads:[~2016-09-23 20:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 7:16 Maxime Coquelin
2016-09-23 7:29 ` Yuanhan Liu
2016-09-23 7:33 ` Maxime Coquelin
2016-09-23 18:24 ` Stephen Hemminger
2016-09-23 18:31 ` Michael S. Tsirkin
2016-09-23 20:28 ` Stephen Hemminger [this message]
2016-09-25 1:02 ` Michael S. Tsirkin
2016-09-25 1:50 ` Stephen Hemminger
2016-09-25 1:53 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923132805.3207f1fa@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=vkaplans@redhat.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).