From: Bruce Richardson <bruce.richardson@intel.com>
To: Wei Dai <wei.dai@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/test: reduce lpm test case size
Date: Mon, 26 Sep 2016 10:32:55 +0100 [thread overview]
Message-ID: <20160926093255.GB15224@bricha3-MOBL3> (raw)
In-Reply-To: <20160926091845.GA15224@bricha3-MOBL3>
On Mon, Sep 26, 2016 at 10:18:45AM +0100, Bruce Richardson wrote:
> On Mon, Sep 26, 2016 at 03:18:08PM +0800, Wei Dai wrote:
> > remove large file app/test/test_lpm_routes.h and
> > add code to auto-generate similar large route rule
> > talbe which keeps same depth and IP class distribution
> > as previous one in test_lpm_routes.h .
> > With the rule table auto-generated at run time,
> > the performance of looking up keep similar to that
> > from pervious constant talbe.
> >
> > Signed-off-by: Wei Dai <wei.dai@intel.com>
> > ---
> > app/test/test_lpm.c | 2 +-
> > app/test/test_lpm_perf.c | 268 +-
> > app/test/test_lpm_routes.h | 1076861 -----------------------------------------
> > 3 files changed, 266 insertions(+), 1076865 deletions(-)
> > delete mode 100644 app/test/test_lpm_routes.h
> >
>
> Hi,
>
> thanks for the work to shrink our release size! Since this patch is so huge due
> to the deleted file, can you please use "-D" flag when running "git format-patch"
> to generate any subsequent versions of this.
>
Also, since this patch is so big, it didn't make it to the list or patchwork.
Please regenerate using "git format-patch -D" and resubmit.
Thanks,
/Bruce
prev parent reply other threads:[~2016-09-26 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1474874288-43458-1-git-send-email-wei.dai@intel.com>
2016-09-26 9:18 ` Bruce Richardson
2016-09-26 9:32 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926093255.GB15224@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).