Re: [dpdk-dev] [PATCH] app/test: reduce lpm test case size

Re: [dpdk-dev] [PATCH] app/test: reduce lpm test case size

[Bruce Richardson]

On Mon, Sep 26, 2016 at 03:18:08PM +0800, Wei Dai wrote:
> remove large file app/test/test_lpm_routes.h and
> add code to auto-generate similar large route rule
> talbe which keeps same depth and IP class distribution
> as previous one in test_lpm_routes.h .
> With the rule table auto-generated at run time,
> the performance of looking up keep similar to that
> from pervious constant talbe.
> 
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> ---
>  app/test/test_lpm.c        |       2 +-
>  app/test/test_lpm_perf.c   |     268 +-
>  app/test/test_lpm_routes.h | 1076861 -----------------------------------------
>  3 files changed, 266 insertions(+), 1076865 deletions(-)
>  delete mode 100644 app/test/test_lpm_routes.h
> 

Hi,

thanks for the work to shrink our release size! Since this patch is so huge due
to the deleted file, can you please use "-D" flag when running "git format-patch"
to generate any subsequent versions of this.

Thanks,
/Bruce

Re: [dpdk-dev] [PATCH] app/test: reduce lpm test case size

[Bruce Richardson]

On Mon, Sep 26, 2016 at 10:18:45AM +0100, Bruce Richardson wrote:
> On Mon, Sep 26, 2016 at 03:18:08PM +0800, Wei Dai wrote:
> > remove large file app/test/test_lpm_routes.h and
> > add code to auto-generate similar large route rule
> > talbe which keeps same depth and IP class distribution
> > as previous one in test_lpm_routes.h .
> > With the rule table auto-generated at run time,
> > the performance of looking up keep similar to that
> > from pervious constant talbe.
> > 
> > Signed-off-by: Wei Dai <wei.dai@intel.com>
> > ---
> >  app/test/test_lpm.c        |       2 +-
> >  app/test/test_lpm_perf.c   |     268 +-
> >  app/test/test_lpm_routes.h | 1076861 -----------------------------------------
> >  3 files changed, 266 insertions(+), 1076865 deletions(-)
> >  delete mode 100644 app/test/test_lpm_routes.h
> > 
> 
> Hi,
> 
> thanks for the work to shrink our release size! Since this patch is so huge due
> to the deleted file, can you please use "-D" flag when running "git format-patch"
> to generate any subsequent versions of this.
> 
Also, since this patch is so big, it didn't make it to the list or patchwork.
Please regenerate using "git format-patch -D" and resubmit.

Thanks,
/Bruce