From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E8C3D12A8 for ; Tue, 27 Sep 2016 14:19:23 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP; 27 Sep 2016 05:19:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,405,1470726000"; d="scan'208";a="884249394" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga003.jf.intel.com with ESMTP; 27 Sep 2016 05:19:23 -0700 Date: Tue, 27 Sep 2016 20:19:51 +0800 From: Yuanhan Liu To: dev@dpdk.org Cc: Jerin Jacob , "Chen Jing D(Mark)" , Cunming Liang , Bruce Richardson , Thomas Monjalon Message-ID: <20160927121951.GP25823@yliu-dev.sh.intel.com> References: <1474611309-20325-1-git-send-email-yuanhan.liu@linux.intel.com> <1474864153-11847-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474864153-11847-1-git-send-email-yuanhan.liu@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3] net: fix build error with clang X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2016 12:19:24 -0000 Can any PMD guys review it? It blocks a virtio patchset apply... Thanks. --yliu On Mon, Sep 26, 2016 at 12:29:13PM +0800, Yuanhan Liu wrote: > Interestingly, clang and gcc has different prototype for _mm_prefetch(). > For gcc, we have > > _mm_prefetch (const void *__P, enum _mm_hint __I) > > While for clang, it's > > #define _mm_prefetch(a, sel) (__builtin_prefetch((void *)(a), 0, (sel))) > > That's how the following error comes with clang: > > error: cast from 'const void *' to 'void *' drops const qualifier > [-Werror,-Wcast-qual] > _mm_prefetch((const void *)rused, _MM_HINT_T0); > /usr/lib/llvm-3.8/bin/../lib/clang/3.8.0/include/xmmintrin.h:684:58: > note: expanded from macro '_mm_prefetch' > #define _mm_prefetch(a, sel) (__builtin_prefetch((void *)(a), > 0, (sel))) > > What's weird is that the build was actaully Okay before. I met it while > apply Jerin's vector support for ARM patch set: he just move this peiece > of code to another file, nothing else changed. > > This patch fix the issue when Jerin's patchset is applied. Thus, I think > it's still needed. > > Similarly, make the same change to other _mm_prefetch users, just in case > this weird issue shows up again somehow later. > > Fixes: fc3d66212fed ("virtio: add vector Rx") > Fixes: c95584dc2b18 ("ixgbe: new vectorized functions for Rx/Tx") > Fixes: 9ed94e5bb04e ("i40e: add vector Rx") > Fixes: 7092be8437bd ("fm10k: add vector Rx") > > Cc: Jerin Jacob > Cc: Chen Jing D(Mark) > Cc: Cunming Liang > Cc: Bruce Richardson > CC: Thomas Monjalon > Signed-off-by: Yuanhan Liu > --- > v3: make the similar replace to other PMD > --- > drivers/net/fm10k/fm10k_rxtx_vec.c | 2 +- > drivers/net/i40e/i40e_rxtx_vec.c | 2 +- > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 2 +- > drivers/net/virtio/virtio_rxtx_simple.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/fm10k/fm10k_rxtx_vec.c b/drivers/net/fm10k/fm10k_rxtx_vec.c > index 9ea747e..6b78c0f 100644 > --- a/drivers/net/fm10k/fm10k_rxtx_vec.c > +++ b/drivers/net/fm10k/fm10k_rxtx_vec.c > @@ -406,7 +406,7 @@ fm10k_recv_raw_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, > */ > rxdp = rxq->hw_ring + next_dd; > > - _mm_prefetch((const void *)rxdp, _MM_HINT_T0); > + rte_prefetch0(rxdp); > > /* See if we need to rearm the RX queue - gives the prefetch a bit > * of time to act > diff --git a/drivers/net/i40e/i40e_rxtx_vec.c b/drivers/net/i40e/i40e_rxtx_vec.c > index 51fb282..a9ca515 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec.c > +++ b/drivers/net/i40e/i40e_rxtx_vec.c > @@ -224,7 +224,7 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts, > */ > rxdp = rxq->rx_ring + rxq->rx_tail; > > - _mm_prefetch((const void *)rxdp, _MM_HINT_T0); > + rte_prefetch0(rxdp); > > /* See if we need to rearm the RX queue - gives the prefetch a bit > * of time to act > diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c > index 1c4fd7c..94dfbd6 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c > @@ -243,7 +243,7 @@ _recv_raw_pkts_vec(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_pkts, > */ > rxdp = rxq->rx_ring + rxq->rx_tail; > > - _mm_prefetch((const void *)rxdp, _MM_HINT_T0); > + rte_prefetch0(rxdp); > > /* See if we need to rearm the RX queue - gives the prefetch a bit > * of time to act > diff --git a/drivers/net/virtio/virtio_rxtx_simple.c b/drivers/net/virtio/virtio_rxtx_simple.c > index 6517aa8..d8dd17c 100644 > --- a/drivers/net/virtio/virtio_rxtx_simple.c > +++ b/drivers/net/virtio/virtio_rxtx_simple.c > @@ -200,7 +200,7 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, > sw_ring = &vq->sw_ring[desc_idx]; > sw_ring_end = &vq->sw_ring[vq->vq_nentries]; > > - _mm_prefetch((const void *)rused, _MM_HINT_T0); > + rte_prefetch0(rused); > > if (vq->vq_free_cnt >= RTE_VIRTIO_VPMD_RX_REARM_THRESH) { > virtio_rxq_rearm_vec(rxvq); > -- > 1.9.0