From: Bruce Richardson <bruce.richardson@intel.com>
To: Nelson Escobar <neescoba@cisco.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/3] net/enic: cleanup interrupt setup when stopping port
Date: Tue, 27 Sep 2016 15:24:57 +0100 [thread overview]
Message-ID: <20160927142457.GB36312@bricha3-MOBL3> (raw)
In-Reply-To: <1474311011-19978-1-git-send-email-neescoba@cisco.com>
On Mon, Sep 19, 2016 at 11:50:09AM -0700, Nelson Escobar wrote:
> enic_disable() wasn't calling rte_intr_disable() or
> rte_intr_callback_unregister(). If stopping/starting a port, the
> latter omission would result in the same interrupt callback being
> registered multiple times, which would then cause it to be called
> multiple times on every interrupt.
>
> Fixes: fefed3d1e62c ("enic: new driver")
>
> Signed-off-by: Nelson Escobar <neescoba@cisco.com>
> Reviewed-by: John Daley <johndale@cisco.com>
> ---
Patchset applied to dpdk-next-net/rel_16_11
/Bruce
prev parent reply other threads:[~2016-09-27 14:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 18:50 Nelson Escobar
2016-09-19 18:50 ` [dpdk-dev] [PATCH 2/3] net/enic: move code checking link status Nelson Escobar
2016-09-19 18:50 ` [dpdk-dev] [PATCH 3/3] net/enic: enable link check interrupts Nelson Escobar
2016-09-27 14:23 ` Bruce Richardson
2016-09-27 14:24 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927142457.GB36312@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=neescoba@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).