From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EF370968 for ; Tue, 27 Sep 2016 16:25:00 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP; 27 Sep 2016 07:25:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,405,1470726000"; d="scan'208";a="14216753" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.48]) by orsmga004.jf.intel.com with SMTP; 27 Sep 2016 07:24:58 -0700 Received: by (sSMTP sendmail emulation); Tue, 27 Sep 2016 15:24:57 +0025 Date: Tue, 27 Sep 2016 15:24:57 +0100 From: Bruce Richardson To: Nelson Escobar Cc: dev@dpdk.org Message-ID: <20160927142457.GB36312@bricha3-MOBL3> References: <1474311011-19978-1-git-send-email-neescoba@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474311011-19978-1-git-send-email-neescoba@cisco.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 1/3] net/enic: cleanup interrupt setup when stopping port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2016 14:25:01 -0000 On Mon, Sep 19, 2016 at 11:50:09AM -0700, Nelson Escobar wrote: > enic_disable() wasn't calling rte_intr_disable() or > rte_intr_callback_unregister(). If stopping/starting a port, the > latter omission would result in the same interrupt callback being > registered multiple times, which would then cause it to be called > multiple times on every interrupt. > > Fixes: fefed3d1e62c ("enic: new driver") > > Signed-off-by: Nelson Escobar > Reviewed-by: John Daley > --- Patchset applied to dpdk-next-net/rel_16_11 /Bruce