From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B1E5A5599 for ; Wed, 28 Sep 2016 10:41:58 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP; 28 Sep 2016 01:41:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,409,1470726000"; d="scan'208";a="14533278" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.108]) by orsmga004.jf.intel.com with SMTP; 28 Sep 2016 01:41:56 -0700 Received: by (sSMTP sendmail emulation); Wed, 28 Sep 2016 09:41:55 +0025 Date: Wed, 28 Sep 2016 09:41:55 +0100 From: Bruce Richardson To: Wei Dai Cc: dev@dpdk.org Message-ID: <20160928084154.GA43788@bricha3-MOBL3> References: <1474882625-67916-1-git-send-email-wei.dai@intel.com> <1474997907-24982-1-git-send-email-wei.dai@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474997907-24982-1-git-send-email-wei.dai@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2] app/test: remove large lpm test head file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2016 08:41:59 -0000 On Wed, Sep 28, 2016 at 01:38:27AM +0800, Wei Dai wrote: > remove the large file app/test/test_lpm_routes.h and add codes to > auto-generate similar large route rule talbe which keeps same depth > and IP class distribution as previous one in test_lpm_routes.h . > With the rule table auto-generated at run time, the performance > of looking up keep similar to that from pervious constant talbe. > > Signed-off-by: Wei Dai > --- Can you perhaps indicate what has changed between v1 and v2, it helps those of us looking to review the patch. [The best way to do so is to place details of diffs in each version underneath the cut line "---".] Regards, /Bruce