From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id C516B5679
 for <dev@dpdk.org>; Wed, 28 Sep 2016 13:35:31 +0200 (CEST)
Received: from cpe-2606-a000-111b-40ed-7aac-c0ff-fec2-933b.dyn6.twc.com
 ([2606:a000:111b:40ed:7aac:c0ff:fec2:933b] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1bpD96-0004gT-0Q; Wed, 28 Sep 2016 07:35:29 -0400
Date: Wed, 28 Sep 2016 07:35:19 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Message-ID: <20160928113519.GA28138@hmsreliant.think-freely.org>
References: <20160928100519.14885-1-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160928100519.14885-1-ferruh.yigit@intel.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Subject: Re: [dpdk-dev] [PATCH] pmdinfogen: fix clang build error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Sep 2016 11:35:32 -0000

On Wed, Sep 28, 2016 at 11:05:19AM +0100, Ferruh Yigit wrote:
> Compile error:
>   CC mlx5.o.pmd.o
> mlx5.o.pmd.c:1:227:
> error: no newline at end of file [-Werror,-Wnewline-eof]
>   ...__attribute__((used)) = "PMD_INFO_STRING= {...}";
>                                                       ^
> 
> Produced with clang 3.8.0 and MLX5_PMD and MLX5_DEBUG
> config options enabled.
> 
> Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  buildtools/pmdinfogen/pmdinfogen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c
> index e1bf2e4..59ab956 100644
> --- a/buildtools/pmdinfogen/pmdinfogen.c
> +++ b/buildtools/pmdinfogen/pmdinfogen.c
> @@ -386,7 +386,7 @@ static void output_pmd_info_string(struct elf_info *info, char *outfile)
>  			else
>  				fprintf(ofd, " ");
>  		}
> -		fprintf(ofd, "]}\";");
> +		fprintf(ofd, "]}\";\n");
>  		drv = drv->next;
>  	}
>  
> -- 
> 2.7.4
> 
> 

What was the error this produced?  It seems like a false positive to me to
require a newline at the end of a string, and it certainly doesn't provide any
benefit when pmdinfo reads it back later.

Neil