From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 840C55680 for ; Thu, 29 Sep 2016 15:04:21 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP; 29 Sep 2016 06:03:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,415,1470726000"; d="scan'208";a="14516598" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga006.fm.intel.com with ESMTP; 29 Sep 2016 06:03:55 -0700 Date: Thu, 29 Sep 2016 21:04:51 +0800 From: Yuanhan Liu To: Zhiyong Yang Cc: dev@dpdk.org, ciara.loftus@intel.com Message-ID: <20160929130451.GL1597@yliu-dev.sh.intel.com> References: <1475069208-137698-2-git-send-email-zhiyong.yang@intel.com> <1475152549-12295-1-git-send-email-zhiyong.yang@intel.com> <1475152549-12295-3-git-send-email-zhiyong.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475152549-12295-3-git-send-email-zhiyong.yang@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v8 2/2] net/vhost: add pmd xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2016 13:04:22 -0000 On Thu, Sep 29, 2016 at 08:35:49PM +0800, Zhiyong Yang wrote: > This feature adds vhost pmd extended statistics from per port perspective > in order to meet the requirements of the applications such as OVS etc. > RX/TX xstats count the bytes without CRC. This is different from physical > NIC stats with CRC. ... > net/virtio pmd xstats(the function virtio_update_packet_stats) is used > as reference when implementing the feature. > > Thanks for the patches Zhiyong. I've tested the size stats and they look > good to me. The above paragraph should not be in the commit log. > Tested-by: Ciara Loftus > > Signed-off-by: Zhiyong Yang There should be no whitespace line bewteen the Tested-by and your SoB. Fixed, and series applied to dpdk-next-virtio. --yliu