From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 501145597 for ; Thu, 29 Sep 2016 20:01:55 +0200 (CEST) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C23B43138; Thu, 29 Sep 2016 18:01:54 +0000 (UTC) Received: from redhat.com (vpn-57-22.rdu2.redhat.com [10.10.57.22]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id u8TI1rXQ003624; Thu, 29 Sep 2016 14:01:54 -0400 Date: Thu, 29 Sep 2016 21:01:53 +0300 From: "Michael S. Tsirkin" To: Yuanhan Liu Cc: dev@dpdk.org, Stephen Hemminger , Maxime Coquelin Message-ID: <20160929210110-mutt-send-email-mst@kernel.org> References: <1474872056-24665-1-git-send-email-yuanhan.liu@linux.intel.com> <1474872056-24665-3-git-send-email-yuanhan.liu@linux.intel.com> <20160929205815-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160929205815-mutt-send-email-mst@kernel.org> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 29 Sep 2016 18:01:54 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 2/2] net/virtio: enable any layout feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2016 18:01:55 -0000 On Thu, Sep 29, 2016 at 09:00:47PM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 26, 2016 at 02:40:56PM +0800, Yuanhan Liu wrote: > > The feature VIRTIO_F_ANY_LAYOUT was actually supported by commit > > dd856dfcb9e7 ("virtio: use any layout on Tx"). But it's not enabled. > > Here this patch enables it. > > > > Signed-off-by: Yuanhan Liu > > Well this will break cross-version migration if just done > unconditionally. > Let's add a protocol feature for this bugfix? Hmm OTOH the bug is in dpdk not qemu ... this needs some thought. > > --- > > drivers/net/virtio/virtio_ethdev.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h > > index 04d626b..3e31e6a 100644 > > --- a/drivers/net/virtio/virtio_ethdev.h > > +++ b/drivers/net/virtio/virtio_ethdev.h > > @@ -64,6 +64,7 @@ > > 1u << VIRTIO_NET_F_CTRL_VLAN | \ > > 1u << VIRTIO_NET_F_MRG_RXBUF | \ > > 1u << VIRTIO_RING_F_INDIRECT_DESC | \ > > + 1u << VIRTIO_F_ANY_LAYOUT | \ > > 1ULL << VIRTIO_F_VERSION_1) > > > > /* > > -- > > 1.9.0