From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 0E2F42935
 for <dev@dpdk.org>; Wed, 12 Oct 2016 18:19:37 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga104.jf.intel.com with ESMTP; 12 Oct 2016 09:19:37 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,336,1473145200"; d="scan'208";a="889315645"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.55])
 by orsmga003.jf.intel.com with SMTP; 12 Oct 2016 09:19:34 -0700
Received: by  (sSMTP sendmail emulation); Wed, 12 Oct 2016 17:19:34 +0025
Date: Wed, 12 Oct 2016 17:19:34 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Cc: John Daley <johndale@cisco.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Nelson Escobar <neescoba@cisco.com>
Message-ID: <20161012161933.GH104428@bricha3-MOBL3>
References: <20160929205505.31690-1-johndale@cisco.com>
 <B27915DBBA3421428155699D51E4CFE20262A85C@IRSMSX103.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <B27915DBBA3421428155699D51E4CFE20262A85C@IRSMSX103.ger.corp.intel.com>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] net/enic: update enic guide and add warning
 for	invalid conf
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Oct 2016 16:19:38 -0000

On Mon, Oct 10, 2016 at 03:16:09PM +0100, Mcnamara, John wrote:
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John Daley
> > Sent: Thursday, September 29, 2016 9:55 PM
> > To: Richardson, Bruce <bruce.richardson@intel.com>
> > Cc: dev@dpdk.org; Nelson Escobar <neescoba@cisco.com>
> > Subject: [dpdk-dev] [PATCH] net/enic: update enic guide and add warning
> > for invalid conf
> > 
> > From: Nelson Escobar <neescoba@cisco.com>
> > 
> > Update the enic guide to better explain how to setup vNIC parameters on
> > the Cisco VIC since the introduction of rx scatter and print an error
> > message for the case of having 1 RQ configured in the vNIC.
> > 
> > Signed-off-by: Nelson Escobar <neescoba@cisco.com>
> 
> Hi,
> 
> It would be better in the RST documentation to use ```` backticks to
> designate function and variable names as fixed width. Also, the documentation
> convention is to use Rx/Tx. However, these are minor so the patch is okay as
> it is.
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>
> 
Applied to dpdk-next-net/rel_16_11 as "document how to configure vNIC parameters"
so as to make it clear that this is one logical change, rather than two - which
would be implied by the use of "and" in the title.

/Bruce