From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by dpdk.org (Postfix) with ESMTP id EB97F9E3
for <dev@dpdk.org>; Wed, 12 Oct 2016 18:24:45 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by orsmga105.jf.intel.com with ESMTP; 12 Oct 2016 09:24:44 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,336,1473145200"; d="scan'208";a="889317327"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.55])
by orsmga003.jf.intel.com with SMTP; 12 Oct 2016 09:24:43 -0700
Received: by (sSMTP sendmail emulation); Wed, 12 Oct 2016 17:24:42 +0025
Date: Wed, 12 Oct 2016 17:24:42 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: "John Daley (johndale)" <johndale@cisco.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20161012162442.GI104428@bricha3-MOBL3>
References: <20160929205639.1175-1-johndale@cisco.com>
<20160929205639.1175-4-johndale@cisco.com>
<2f02ca98-8250-0c27-7ae4-5e23839521d6@intel.com>
<ac590003ef2e42b6a8d7af452da6b88a@XCH-RCD-007.cisco.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ac590003ef2e42b6a8d7af452da6b88a@XCH-RCD-007.cisco.com>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
=?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH 4/4] net/enic: extend fdir support for 1300
series adapters
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Oct 2016 16:24:46 -0000
On Tue, Oct 11, 2016 at 09:25:45AM +0000, John Daley (johndale) wrote:
>
>
> > -----Original Message-----
> > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> > Sent: Tuesday, October 11, 2016 2:22 AM
> > To: John Daley (johndale) <johndale@cisco.com>;
> > bruce.richardson@intel.com
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH 4/4] net/enic: extend fdir support for 1300
> > series adapters
> >
> > Hi John,
> >
> > On 9/29/2016 9:56 PM, John Daley wrote:
> > > 1300 series Cisco adapter firmware version 2.0(13) for UCS C-series
> > > servers and 3.1(2) for blade servers supports more filtering
> > > capabilities. The feature can be enabled via Cisco CIMC or USCM with
> > > the 'advanced filters' radio button. When enabled, the these
> > > additional flow director modes are available:
> > > RTE_ETH_FLOW_NONFRAG_IPV4_OTHER
> > > RTE_ETH_FLOW_NONFRAG_IPV4_SCTP
> > > RTE_ETH_FLOW_NONFRAG_IPV6_UDP
> > > RTE_ETH_FLOW_NONFRAG_IPV6_TCP
> > > RTE_ETH_FLOW_NONFRAG_IPV6_SCTP
> > > RTE_ETH_FLOW_NONFRAG_IPV6_OTHER
> > >
> > > Changes:
> > > - Detect and set an 'advanced filters' flag dependent on the adapter
> > > capability.
> > > - Implement RTE_ETH_FILTER_INFO filter op to return the flow types
> > > available dependent on whether advanced filters are enabled.
> > > - Use a function pointer to select how filters are added to the adapter:
> > > copy_fltr_v1() for older firmware/adapters or copy_fltr_v2() for
> > > adapters which support advanced filters.
> > > - Apply fdir global masks to filters when in advanced filter mode.
> > > - Update documentation.
> > >
> > > Signed-off-by: John Daley <johndale@cisco.com>
> > > Reviewed-by: Nelson Escobar <neescoba@cisco.com>
> > > ---
> >
> > <...>
> >
> > >
> > > +void enic_fdir_info_get(struct enic *enic, struct rte_eth_fdir_info
> > > +*info) {
> > > + info->mode = enic->fdir.modes;
> >
> > This cause a icc build error:
> > .../drivers/net/enic/enic_clsf.c(77):
> > error #188: enumerated type mixed with another type
> > info->mode = enic->fdir.modes;
> > ^
> >
> > Just casting to the enum fixes it:
> > + info->mode = (enum rte_fdir_mode)enic->fdir.modes;
> >
> > Since the modification is trivial, if you agree with the change, we can apply it
> > without needing a new version of the patch?
> >
>
> Looks good, thank you and sorry for the trouble.
> -john
>
Series applied to dpdk-next-net/rel_16_11
/Bruce