From: Bruce Richardson <bruce.richardson@intel.com>
To: John Daley <johndale@cisco.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/enic: remove assert which causes compile error
Date: Thu, 13 Oct 2016 14:37:42 +0100 [thread overview]
Message-ID: <20161013133742.GB138296@bricha3-MOBL3> (raw)
In-Reply-To: <20161013132215.GA138296@bricha3-MOBL3>
On Thu, Oct 13, 2016 at 02:22:16PM +0100, Bruce Richardson wrote:
> On Wed, Oct 12, 2016 at 11:09:35AM -0700, John Daley wrote:
> > Remove an RTE_ASSERT which will not compile if enabled and is not needed.
> >
> > Fixes: a1f7c7b3b5b2 ("net/enic: extend fdir support for 1300 series adapters")
> >
> > Signed-off-by: John Daley <johndale@cisco.com>
> > ---
> > Would have been nice if I caught this yesterday before you applied a1f7c7b3 :(
> >
> Since commit a1f7c7b3 has not been pulled into the dpdk.org mainline, I can still
> merge this commit into the origin one that has the bug. Unless you object, I
> shall do so now.
>
> /Bruce
Done. Fix merged into original commit
/Bruce
prev parent reply other threads:[~2016-10-13 13:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 20:56 [dpdk-dev] [PATCH 1/4] net/enic: fix fdir usage with scattered Rx John Daley
2016-09-29 20:56 ` [dpdk-dev] [PATCH 2/4] net/enic: fix segfault when restarting with fdir filters John Daley
2016-09-29 20:56 ` [dpdk-dev] [PATCH 3/4] net/enic: update VIC interface file John Daley
2016-09-29 20:56 ` [dpdk-dev] [PATCH 4/4] net/enic: extend fdir support for 1300 series adapters John Daley
2016-10-11 9:22 ` Ferruh Yigit
2016-10-11 9:25 ` John Daley (johndale)
2016-10-12 16:24 ` Bruce Richardson
2016-10-12 18:09 ` [dpdk-dev] [PATCH] net/enic: remove assert which causes compile error John Daley
2016-10-13 13:22 ` Bruce Richardson
2016-10-13 13:37 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013133742.GB138296@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).