From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
by dpdk.org (Postfix) with ESMTP id 8E4F12B97
for <dev@dpdk.org>; Thu, 13 Oct 2016 15:37:46 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by orsmga102.jf.intel.com with ESMTP; 13 Oct 2016 06:37:45 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,339,1473145200"; d="scan'208";a="1064321616"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.210.139])
by orsmga002.jf.intel.com with SMTP; 13 Oct 2016 06:37:44 -0700
Received: by (sSMTP sendmail emulation); Thu, 13 Oct 2016 14:37:43 +0025
Date: Thu, 13 Oct 2016 14:37:42 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: John Daley <johndale@cisco.com>
Cc: dev@dpdk.org
Message-ID: <20161013133742.GB138296@bricha3-MOBL3>
References: <20161012162442.GI104428@bricha3-MOBL3>
<20161012180935.8366-1-johndale@cisco.com>
<20161013132215.GA138296@bricha3-MOBL3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161013132215.GA138296@bricha3-MOBL3>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
=?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] net/enic: remove assert which causes compile
error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Oct 2016 13:37:47 -0000
On Thu, Oct 13, 2016 at 02:22:16PM +0100, Bruce Richardson wrote:
> On Wed, Oct 12, 2016 at 11:09:35AM -0700, John Daley wrote:
> > Remove an RTE_ASSERT which will not compile if enabled and is not needed.
> >
> > Fixes: a1f7c7b3b5b2 ("net/enic: extend fdir support for 1300 series adapters")
> >
> > Signed-off-by: John Daley <johndale@cisco.com>
> > ---
> > Would have been nice if I caught this yesterday before you applied a1f7c7b3 :(
> >
> Since commit a1f7c7b3 has not been pulled into the dpdk.org mainline, I can still
> merge this commit into the origin one that has the bug. Unless you object, I
> shall do so now.
>
> /Bruce
Done. Fix merged into original commit
/Bruce