From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0084.outbound.protection.outlook.com [104.47.37.84]) by dpdk.org (Postfix) with ESMTP id BD5402B98 for ; Tue, 18 Oct 2016 13:19:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5PTHRSm4c5own4HKp1nG2/AKYYM5brPUTVeX74S90vg=; b=J99e8eVITBsayeXTW1nZfsgTrBpgXSnwvGZ9IZ9OUcMG4AWlXBCRGNnnpjFRHVBN8C7xeaxy0ylnSyLY61/bK9ZhtPluSsc/ZWk//mfVztA+FDqCIpKeqLdF2Hj2roekWJEv1nIukCfw4joD8XRGGoqgScpeyWW59/HiVXcoVJc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (31.216.236.195) by CY1PR0701MB1728.namprd07.prod.outlook.com (10.163.21.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.629.8; Tue, 18 Oct 2016 11:19:37 +0000 Date: Tue, 18 Oct 2016 16:49:26 +0530 From: Jerin Jacob To: "Eads, Gage" CC: "dev@dpdk.org" , "thomas.monjalon@6wind.com" , "Richardson, Bruce" , "Vangati, Narender" , "hemant.agrawal@nxp.com" Message-ID: <20161018111925.GA4745@localhost.localdomain> References: <20161005072451.GA2358@localhost.localdomain> <1476214216-31982-1-git-send-email-jerin.jacob@caviumnetworks.com> <9184057F7FC11744A2107296B6B8EB1E01E179E0@FMSMSX108.amr.corp.intel.com> <20161017041812.GA3543@localhost.localdomain> <9184057F7FC11744A2107296B6B8EB1E01E18A80@FMSMSX108.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E01E18A80@FMSMSX108.amr.corp.intel.com> User-Agent: Mutt/1.6.2 (2016-07-01) X-Originating-IP: [31.216.236.195] X-ClientProxiedBy: DB5PR09CA0044.eurprd09.prod.outlook.com (10.162.34.12) To CY1PR0701MB1728.namprd07.prod.outlook.com (10.163.21.142) X-MS-Office365-Filtering-Correlation-Id: f70b1c32-18db-4cb9-2c24-08d3f748a670 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 2:YoWFCW0sfzid/3iN+kZR7G/F+hEEaPMw8ezH93Rdq59YNWcC6sJtzMaoK8ddjEV3PX99FH1uXrc5ouJAERsFctNlbVB9a2TzdjmHDM4oMvkv1aCdGcEc/CmtAL5og2ALz30ULoLp0xs75fR+KS0oqn1m7yBGVON51Jp/G6JuwwwQoYKibVzhcc9Td2zrSHMF; 3:xtCJEoPXQI46gZvgjR8zDpoZe7Al3nQR4Kff1e+p6L0/qeQYZH53IrMp7jQEP0fFipMCljVUDN2IKWOh23phBwm+I4OgCvZsrLn2dteL807ntQzk8cwGj4IbKjBkmkM3; 25:Atc2l8TpJzMmdNWggUZu+DrgANllORQKMkww+RBqZPj02YCMZRgbQ+qg3AiuEXiwjTVQb42YN6KOQjaaLb3ZYnclA2P+gBph+mtxQX9J+67s1OwPg0glImA4jnB3VsbPaz6ju0nUFyJqV4mLt2K8J9XpewrsjmYpTynEIaOMLSCA+RpHRzGp8pmRR65MryVXmcyd/Ai36auiFAggjvwbOLfmO4NEIN29+E525IdHE6ZfQYw1P+VkkHr2L/q/H7m4LLnFguMXUsOo/lf9s+2mlXQ0DmuqvzaeGlfEI/O6E/WUuWy3i1gDEj0aMQKV99vatZ6hu27QNKeGdLwRcsiMSsQxr3wjauLKpOhQrrKEUhFLLRGF4nYa7pNRG9YhA4853S9zBNdeEZkMu04bS4dcgS4+HX9msyDmSaTLxc8uPXQ= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0701MB1728; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 31:OGk+Yu5f80vxg9cJOL4zzi5ePardZFgrFhWFKyrqydC4YlFgH5y4UhxNu3ZrbJmjpfikyDX5TzxKc+zUuN31InPczYXnnW4Cnsn+sRqO0XINH7loW2vQZ8Rjit8hds5yZxs0FeKOGtE23OHySK2aphyyzsx/QLt56mPITV23MqCgOipE7UnPqZV1Ah7ar8fHUj3bt5s34j36umFEcqsJL5ubzzrQ4KdLDmvYGAOmbeQycqQD6NqPIYqOkBATUEzl; 20:XYUK1rPw4jiHbFD1sLWq5hkyzfw0O6APmuDA6Cg838qRpKXyirwsuWdSKR1twcegeMIvkZ/rseUXlALuut+J45U2TCag7JiBumSJY0+KvkN0FzIjL45DB8u/Ja0W2C97x2AigYg8RoMOAk8GsnuEh4sw3YYc9IApHI4vJlFmr8B3itX1PWNsEdNDBn3dHjhpqe2eGN0oSP+jDE5scs0mpfWTL6s2GDLwUu+4p71kureKKVVjhsoLDPR9Bn1FNSUP4nNS7yR6mekZK2iMkbDmfGmrzFsGN4x1ucHly+uO2ZEHkbHsbRITQKhv3dwNscv69E3dBwil8itrJseO37AnYIT9tz8Js68/mzrK4/ZhRGty31AXRYiiDPryiS936kYSRiR7PR2YYzSlULonf1qju84ASVXdNYACU8BFZGO+tVf+r6HhTVbqIRaChr4hpbS6iUT51hcrkgOarXCXJcvp30v30kubO1gudujWKYoM2doarU0vxGNcFvUtlwyHC8l3WDLfxt8VQkt/hIyLdAWdOuSnh42YlZUuacGDDR/W3RUJT4VsW7fCGOJ9IitU+W8OR2pqcv/7vBvCyQUGlNCu9l6y1l6FQMcFRjSlLbMuYWY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:CY1PR0701MB1728; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0701MB1728; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 4:SdM2bO1GDeIOeptpJHRSL+wgfyrP9JjT/E2NjVXscF+LqzlkL9zXzduJOaAnrlcQU0YR8st6tYynhi1kzj7G5hzY3r6aUFIvIgeUSO1/9GGlhYCAvD6+yk0sAAwKeWtM8OhVNzVX/gPUD04mRYFv3KZcEv4g94icE3YwaduaGS4w///pG5lN9SX0g+tYdBb2Tv8UeOQCjEkMDYOE18GVN+fgNp3l6k3PQBQ7KeEN9XjuamOBjXuGUDyIiyDgdosCoTGvVEPUc7PeOtY6uH0EOBFvkhxQzMF7WHaVKcpXS9jsOoh24r3V2DJWDVxMHPLkiSwmuGE/BKTfi0I8EwbNq6UhVXMpZd58zZetQpDJRK8XbTwztIAB6pkO1jZqMzFoa1X/ztb72UcNt8rUX/7yXOS3DsffVtAIMUesquA/wjIBOFl7giuXrtdZzAPEl7y2OR0TyYZUaGFi0Ce6idGHlw== X-Forefront-PRVS: 00997889E7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(377454003)(13464003)(199003)(189002)(24454002)(76104003)(6116002)(54356999)(42186005)(105586002)(1076002)(8676002)(19580405001)(33656002)(19580395003)(68736007)(4001350100001)(4326007)(9686002)(106356001)(586003)(110136003)(83506001)(81166006)(92566002)(2950100002)(6666003)(6916009)(189998001)(97736004)(42882006)(93886004)(81156014)(50466002)(8666005)(3846002)(46406003)(7846002)(305945005)(76176999)(61506002)(66066001)(50986999)(97756001)(47776003)(101416001)(2906002)(7736002)(23726003)(77096005)(5660300001)(18370500001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1728; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1728; 23:IEGdTb/kwbtlNlxYVRg8Cbt5ZPajA97RvB0r84T?= =?us-ascii?Q?g7Lv5VROWHuoNOW82XzT8/eZftbWLkorlKO4AQVRGGBwigbB6sBo5sA9LFeE?= =?us-ascii?Q?zV6YIHV9YZC/DO3DQb/sdGVeEDvK9QV22nKJFI8alZYqkGnmNnZsxFyi3fPG?= =?us-ascii?Q?fIBbmRti8UCm7QJveFMOeJlGId3ldK15st/15Ta8Kze7ZqBS4RrN8YVuO2aB?= =?us-ascii?Q?yQVWaDtfB7ZEHtZ9FAGEDsQACPNrs4lKyqZTF+3A2rsXZa39dQDOFoIdmVDW?= =?us-ascii?Q?BadwFIoBh8zEKr29CVitHmKTO1XnVZ0NbojMF+f3UmYxW341zzCbmTvKWgD3?= =?us-ascii?Q?5bzTGfakSUQwsg7XBT789x5kLIirPm/CA0Xzz/bo8CIzUKaylB/9Aha9CK30?= =?us-ascii?Q?9E5QG8VDmnwVPqH7pQdwyZIRN1xDT4iZ7Hb6wr5ZcWc+pIt59GEXERjWv22J?= =?us-ascii?Q?7n0Bllt3r+rvBZEYqV0C9RzZhYV67WEqfNx1m3FGaF3e248yPDLXRSmFbsNB?= =?us-ascii?Q?5DOxFJEjKb2wpM3UBjSnl/671GjI0PhgV9tarSuZ8cOUnobjxpWScvHXcO7V?= =?us-ascii?Q?Z1x0SbW6Cq/E4Go0aZ1XrLLGSi/DOXhSISKCkmjdh77ckcjBQ3bGNvKtrlRb?= =?us-ascii?Q?44x+P0VcxzcUhgwXf1gGsHvTh3BPAiCxLIPmeLH7qxddcM2E7fvkOPQu+Fuk?= =?us-ascii?Q?rmdTgsqAexu75xrl/qi1wtpv+F8LtsI9hrQHZNtIfKGUr2jDCAHn5QBGyBoZ?= =?us-ascii?Q?RezQrAg5R/suiobREo8N8e06daAj8/YwjS4aA38vdqnO1Ps35cUfAHyxNXE9?= =?us-ascii?Q?XQ1jAHh17xcIr3IwGIvWkyn7gbT86j/sCMtSbe7atzL87TmzHsb6pSKqGKqE?= =?us-ascii?Q?jCud+reMSQdAjQB+Bcjm3Fs8vNG5+sYfxxI+cbijX1enYm8EA44/BqUqP3Sq?= =?us-ascii?Q?sfokkVqEIMP18R+RtRuXGjne8Ql1KprH6zkS1QRPESBdhEs0a8/JaQvVjoNT?= =?us-ascii?Q?5DFi8frDIXce5c4nWrovrQL+annRxU2Vv4687/7H4yNSvk3SzZXGhzCOjIKQ?= =?us-ascii?Q?wwFtI3+G12CyvwXBE297VNlob9QWxrTdOz4FoZnksXN0kill+MG8urPHsLTA?= =?us-ascii?Q?SOrqJ8u9jIAcYZPF4X3JYHpwhyIVYnNsJEnu5Ofa6z1JupHvLyCxFA46sOX0?= =?us-ascii?Q?la1swKO+nnjuklFN4Y2LT7qFzsKS43HDGmVHhX0ei5Y7IkQRmWOM30UYIH3C?= =?us-ascii?Q?WH6iUbFTkOGLRdRGtZDsxaw8V+W79NZAnMdFwNG0WGAAXcNMex6lepxP2S8L?= =?us-ascii?Q?QZ00dli6Zf5CXt4ntzKHZmPjITWfmojAHCKAC7dUA55KhIa04WpxcdVTN8rv?= =?us-ascii?Q?Conp9u27r14zol1UNREMj06RMC+Y=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 6:PTyqZG0K9y1YOxSRSka6rQXFlxnM8lUrTs4Qan2Bx8eUzUbAe0OYTOj2MDxZa3PQHnb+aWWdOgwShpzX9PaWAk2XI0Xh5mxHR/m/hakviYHCaut0Inld8Oy+TplWN4sTB+SIPRfBm6CEVGfWg+tdlX+/o6CxNMT75IYr/51BVOrQX60V+L+zR5mGET+ChPO1BrIWvI3+tUvx9fO171Synlz4bXsGtkJWoJirI+ohT7XGUZwpPW1KjpDq9rPaK2UqyKxXlxJPUWo+S+2Wzi5I2ew4qCXu2ZXlQyKiGIyTNIw=; 5:aGdrFo9U3D2ksjdCJ8/Hb6sqr0EYGS8/6lfiygl2k1JLhWcvSS4r0KrqMwV4WjRsyYEYDfHFCZpOkJI/BB2PuBe7kz65cKRGtNt2s9S218zszvb/MhGbCqe1DYLBmHxYAo99VxiZMr2WKGnxalbpDw==; 24:t4NbyDoHZpOEVv/K7hn443+d47XQQNXNLgJw1pvhBHAwsG097d/ZRgTMiRTT3QP/d/c9V9Wa9Dk29zfbohtHwhQJyu+XF33liQgRzElxQlQ=; 7:gD0oRMuKEmhPjMaXbbVr9eybfZk4y9bYXFfW0kiZSJHiDDH4XZvcq8c/rgCwuOCH3kjCpqW8jn52s/Ywk+apY2+Ic6lF/1wgg1kEifTxlaElGm/2iK+Ikz4heG1j0z6NeYZ1ZAMSzNxyn6OpfgnvXcNleQaH4Qr+POTJfruaHDYuADvbnpxaYKIdwvOnrog7CpuspY97AZaUSKtByUu5XIRBr1fy/uPG2aShIfRakK9Mb6w68JLr5zTiVxiMuZaOBHCfiCI/xfLsJum1BAjcfOK859oCm9o980pa8uk5HlspoaNBek+qfGtDqW0d27blaDAyaj2CYRaweNW6+MlvMQ== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2016 11:19:37.9117 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1728 Subject: Re: [dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven programming model framework for DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2016 11:19:41 -0000 On Mon, Oct 17, 2016 at 08:26:33PM +0000, Eads, Gage wrote: > > > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Sunday, October 16, 2016 11:18 PM > > To: Eads, Gage > > Cc: dev@dpdk.org; thomas.monjalon@6wind.com; Richardson, Bruce > > ; Vangati, Narender > > ; hemant.agrawal@nxp.com > > Subject: Re: [dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven > > programming model framework for DPDK > > > > On Fri, Oct 14, 2016 at 03:00:57PM +0000, Eads, Gage wrote: > > > Thanks Jerin, this looks good. I've put a few notes/questions inline. > > > > Thanks Gage. > > > > > > > > > + > > > > +/** > > > > + * Get the device identifier for the named event device. > > > > + * > > > > + * @param name > > > > + * Event device name to select the event device identifier. > > > > + * > > > > + * @return > > > > + * Returns event device identifier on success. > > > > + * - <0: Failure to find named event device. > > > > + */ > > > > +extern uint8_t > > > > +rte_event_dev_get_dev_id(const char *name); > > > > > > This return type should be int8_t, or some signed type, to support the failure > > case. > > > > Makes sense. I will change to int to make consistent with > > rte_cryptodev_get_dev_id() > > > > > > > > > +}; > > > > + > > > > +/** > > > > + * Schedule one or more events in the event dev. > > > > + * > > > > + * An event dev implementation may define this is a NOOP, for > > > > instance if + * the event dev performs its scheduling in hardware. > > > > + * > > > > + * @param dev_id > > > > + * The identifier of the device. > > > > + */ > > > > +extern void > > > > +rte_event_schedule(uint8_t dev_id); > > > > > > One idea: Have the function return the number of scheduled packets (or 0 for > > implementations that do scheduling in hardware). This could be a helpful > > diagnostic for the software scheduler. > > > > How about returning an implementation specific value ? > > Rather than defining certain function associated with returned value. > > Just to make sure it works with all HW/SW implementations. Something like > > below, > > > > /** > > * Schedule one or more events in the event dev. > > * > > * An event dev implementation may define this is a NOOP, for instance if > > * the event dev performs its scheduling in hardware. > > * > > * @param dev_id > > * The identifier of the device. > > * @return > > * Implementation specific value from the event driver for diagnostic purpose > > */ > > extern int > > rte_event_schedule(uint8_t dev_id); > > > > > > That's fine by me. OK. I will change it in v3 > > I also had a comment on the return value of rte_event_dev_info_get() in my previous email: "I'm wondering if this return type should be int, so we can return an error if the dev_id is invalid." > > What do you think? The void return was based on cryptodev_info_get().I think, it makes sense to return "int". I will change it in v3. > > Thanks, > Gage > > > > >