From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 7498B2C0C
 for <dev@dpdk.org>; Tue, 18 Oct 2016 15:05:38 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga103.fm.intel.com with ESMTP; 18 Oct 2016 06:05:22 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,362,1473145200"; d="scan'208";a="21213210"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by orsmga004.jf.intel.com with ESMTP; 18 Oct 2016 06:05:20 -0700
Date: Tue, 18 Oct 2016 21:06:15 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jan Blunck <jblunck@infradead.org>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>,
 "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
 dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>
Message-ID: <20161018130615.GK16751@yliu-dev.sh.intel.com>
References: <1472077494-164532-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <B27915DBBA3421428155699D51E4CFE2025CE4E8@IRSMSX103.ger.corp.intel.com>
 <7677934.dvmb0F7Vh7@xps13>
 <CALe+Z01WbAER5uynvnU1PUYj1FWXyhxE3cCPc0ivJCu8v7XfbQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALe+Z01WbAER5uynvnU1PUYj1FWXyhxE3cCPc0ivJCu8v7XfbQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] drivers: make driver names consistent
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Oct 2016 13:05:39 -0000

On Tue, Oct 18, 2016 at 02:50:16PM +0200, Jan Blunck wrote:
> >From my understanding this is a massive API breakage. This forces all
> existing users of the virtual PMDs to change with zero benefit. Even
> if that isn't enough it also makes it impossible to switch between
> releases by recompiling.
> 
> Can we please revert these changes and work on some aliasing support
> for the PMDs to fix it long term?

+1. Aliasing is also something I would suggest before making such renames.

	--yliu
> 
> Thanks,
> Jan
> 
> 
> On Fri, Sep 16, 2016 at 11:58 AM, Thomas Monjalon
> <thomas.monjalon@6wind.com> wrote:
> > 2016-08-24 22:37, Mcnamara, John:
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> >> >
> >> > ...
> >> >
> >> > -    $RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 'eth_pcap0,rx_pcap=/path/to/ file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' -- --port-topology=chained
> >> > +    $RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 'net_pcap0,rx_pcap=/path/to/ file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' -- --port-topology=chained
> >>
> >>
> >> I know that this is an existing issue but there shouldn't be a space in
> >> "/path/to/ file". Perhaps you could fix that (in a number of places) as part
> >> of this patch. You could probably leave out the "/path/to/" part altogether as
> >> it may be clearer, see below.
> >>
> >> Also, could you wrap the long code lines in the sections that you change at
> >> 80 chars using "\" to keep them on the page in the PDF docs, like:
> >>
> >>     $RTE_TARGET/app/testpmd -c '0xf' -n 4 \
> >>         --vdev 'net_pcap0,rx_pcap=/path/to/file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' \
> >>         -- --port-topology=chained
> >>
> >> Or without the path part:
> >>
> >>     $RTE_TARGET/app/testpmd -c '0xf' -n 4 \
> >>         --vdev 'net_pcap0,rx_pcap=file_rx.pcap,tx_pcap=file_tx.pcap' \
> >>         -- --port-topology=chained
> >
> > Applied with above comments fixed and release notes updated, thanks.