From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E3B072C01 for ; Tue, 18 Oct 2016 16:17:43 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP; 18 Oct 2016 07:17:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,362,1473145200"; d="scan'208";a="20831914" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga005.fm.intel.com with ESMTP; 18 Oct 2016 07:17:41 -0700 Date: Tue, 18 Oct 2016 22:18:37 +0800 From: Yuanhan Liu To: Thomas Monjalon Cc: Jan Blunck , "De Lara Guarch, Pablo" , dev@dpdk.org, "Mcnamara, John" Message-ID: <20161018141837.GN16751@yliu-dev.sh.intel.com> References: <1472077494-164532-1-git-send-email-pablo.de.lara.guarch@intel.com> <20161018130615.GK16751@yliu-dev.sh.intel.com> <10195497.iZAVVgVpbs@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10195497.iZAVVgVpbs@xps13> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] drivers: make driver names consistent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2016 14:17:44 -0000 On Tue, Oct 18, 2016 at 03:42:54PM +0200, Thomas Monjalon wrote: > 2016-10-18 21:06, Yuanhan Liu: > > On Tue, Oct 18, 2016 at 02:50:16PM +0200, Jan Blunck wrote: > > > >From my understanding this is a massive API breakage. This forces all > > > existing users of the virtual PMDs to change with zero benefit. Even > > > if that isn't enough it also makes it impossible to switch between > > > releases by recompiling. > > > > > > Can we please revert these changes and work on some aliasing support > > > for the PMDs to fix it long term? > > > > +1. Aliasing is also something I would suggest before making such renames. > > It is a brutal change, yes. > It was announced in 16.07 release notes though. Yes, but it still took me a while (by running git bisect) to figure out what went wrong: I wasn't aware of such note, that I was thinking maybe something is broken. Later I also got quite few same complains. It may also took them a while to know what's happened. Anyway, my point is, for this kind of change, we should have added the alias support firstly. If that's been done, then the announcement is not needed at all? --yliu > > We can try to make this change more progressive by keeping old names > as aliases for some time. > Is there a volunteer to work on vdev names aliases, > with the target of integrating them in RC2 or RC3?