From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id DA6E52A5E for ; Wed, 19 Oct 2016 11:52:07 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP; 19 Oct 2016 02:52:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,514,1473145200"; d="scan'208";a="21160504" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.210.138]) by fmsmga006.fm.intel.com with SMTP; 19 Oct 2016 02:52:04 -0700 Received: by (sSMTP sendmail emulation); Wed, 19 Oct 2016 10:52:04 +0100 Date: Wed, 19 Oct 2016 10:52:04 +0100 From: Bruce Richardson To: "Ananyev, Konstantin" Cc: "Zhang, Qi Z" , "Wu, Jingjing" , "Zhang, Helin" , "dev@dpdk.org" Message-ID: <20161019095203.GJ27816@bricha3-MOBL3.ger.corp.intel.com> References: <1476728982-39985-1-git-send-email-qi.z.zhang@intel.com> <2601191342CEEE43887BDE71AB9772583F0C2B37@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2601191342CEEE43887BDE71AB9772583F0C2B37@irsmsx105.ger.corp.intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.1 (2016-10-04) Subject: Re: [dpdk-dev] [PATCH v2 0/3] net: fix out of order Rx read issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2016 09:52:08 -0000 On Tue, Oct 18, 2016 at 11:33:43AM +0000, Ananyev, Konstantin wrote: > > > > > > In vPMD, when load Rx desc with _mm_loadu_si128, > > volatile point will be cast into non-volatile point. > > So GCC is allowed to reorder the load instructions, > > while Rx read's correctness is reply on these load > > instructions to follow a backward sequence strictly, > > so we add compile barrier to prevent compiler reorder. > > We already met this issue on i40e with GCC6 and we > > fixed this on ixgbe and fm10k also. > > > > v2: > > - fix check-git-log.sh warning. > > - add more detail commit message. > > > > Qi Zhang (3): > > net/i40e: fix out of order Rx read issue > > net/ixgbe: fix out of order Rx read issue > > net/fm10k: fix out of ofder Rx read issue > > > > drivers/net/fm10k/fm10k_rxtx_vec.c | 3 +++ > > drivers/net/i40e/i40e_rxtx_vec.c | 3 +++ > > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 3 +++ > > 3 files changed, 9 insertions(+) > > > > -- > > Acked-by: Konstantin Ananyev > Applied to dpdk-next_net/rel_16_11 /Bruce