From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C781C2E41 for ; Tue, 25 Oct 2016 14:53:45 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 25 Oct 2016 05:53:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,545,1473145200"; d="scan'208";a="893731785" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.210.150]) by orsmga003.jf.intel.com with SMTP; 25 Oct 2016 05:53:42 -0700 Received: by (sSMTP sendmail emulation); Tue, 25 Oct 2016 13:53:42 +0100 Date: Tue, 25 Oct 2016 13:53:42 +0100 From: Bruce Richardson To: Qiming Yang Cc: dev@dpdk.org, jingjing.wu@intel.com, helin.zhang@intel.com Message-ID: <20161025125341.GA57276@bricha3-MOBL3.ger.corp.intel.com> References: <1477369146-63317-1-git-send-email-qiming.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477369146-63317-1-git-send-email-qiming.yang@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.1 (2016-10-04) Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: fix link status change interrupt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Oct 2016 12:53:46 -0000 On Tue, Oct 25, 2016 at 12:19:05PM +0800, Qiming Yang wrote: > Previously, link status interrupt in i40e is achieved by checking > LINK_STAT_CHANGE_MASK in PFINT_ICR0 register which is provided only > for diagnostic use. Instead, drivers need to get the link status > change notification by using LSE (Link Status Event). > > This patch enables LSE and calls LSC callback when the event is > received. This patch also removes the processing on > LINK_STAT_CHANGE_MASK. > > Fixes: 4861cde46116 ("i40e: new poll mode driver") > > Signed-off-by: Qiming Yang > --- Thanks for the V2. Unfortunately, this conflicts with some other changes to the driver, making the patch not apply cleanly, and a manual apply I tried did not compile successfully. Can you please do a V3 rebased on top of dpdk-next-net/rel_16_11. Thanks, /Bruce