From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 0E8055592 for ; Fri, 28 Oct 2016 14:07:36 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id 140so72792290wmv.0 for ; Fri, 28 Oct 2016 05:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zuKhhcCvC3CynsiuesyDdTIYrANkG59+bXNANudoo/g=; b=QM9dXfjKJtUMchgkaYNfAT0oaoQyiOaEid8mcBSxu5riMcEFMOtR9tsK9YBWoceqTQ IZhZYqMgfECqjXbqrhyevIkSSQfnXRDZm3eVVf9kdmQJinJePDaekOV8bYyR8zDOoi1l 5CKzBLlImuPizSpDgtiz7VigudAM5mEZaW/ujj0XApPCp9cci4e6e1JrHhE3tekwzGrz nwyITR2LH7sMo0aeVHBAmrkOPPIW+90ZKYQrO2zOnlZ836SKfV99n3Ow1UV68f3MvJnN nc23g7ao9RVb/BpnT40aUlPVKU2lHTX8VDe7+wlfR7SxRhgEu/aUu1x6C1edHuq+r9Or spxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zuKhhcCvC3CynsiuesyDdTIYrANkG59+bXNANudoo/g=; b=VjolUBYaSm7uD9QzCbv5L1V66o6bqL8IFyCJqi3Ut06C0d/S+gYzevxB10FLk8CmTh iEkYO9l03Xw2ObFUSRV2AdmnXW29P+1KBpFZOaFWU6PiyPQLJMno0wVcTB5niV/ukE17 g9kN+NjSomSTR6axek0UfbXAeQgC/m3SJEZu0bOlpgeBTzOWY2KUDkrVWxD/YQ9qyLox ItaSiWSC79DbMAfS/EbgbYZDBi6wUg2BwG7/oPk7e1iRj8sPhBvdF2Fx1LclttniIkwe 0bD/Pcvupwo5/mDlL6m/pi6ewtC9e2VfU8Axhm8Osi4ucrVRDvjEUQIVCHoY5E9Q5SIk wQtQ== X-Gm-Message-State: ABUngvc9i4VOOZ2XaXpbtn0KIbqYpdWm50lTRYznPVaFd4RYoE1n6I6rZKiuYjzybQtr3ZNO X-Received: by 10.194.80.194 with SMTP id t2mr11039432wjx.75.1477656454072; Fri, 28 Oct 2016 05:07:34 -0700 (PDT) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id p3sm13785887wjr.31.2016.10.28.05.07.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Oct 2016 05:07:33 -0700 (PDT) Date: Fri, 28 Oct 2016 14:07:27 +0200 From: Adrien Mazarguil To: Raslan Darawsheh Message-ID: <20161028120726.GV5733@6wind.com> References: <2c3d48cf2736dcc6824e39c911666521befdd918.1477295827.git.rasland@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2c3d48cf2736dcc6824e39c911666521befdd918.1477295827.git.rasland@mellanox.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix default set for multicast traffic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2016 12:07:36 -0000 On Mon, Oct 24, 2016 at 10:59:14AM +0300, Raslan Darawsheh wrote: > Remove non-IPv6 multicast traffic with destination MAC 33:33:* from the > default set when not in promiscuous or allmulticast modes. > > Fixes: 0497ddaac511 ("mlx5: add special flows for broadcast and IPv6 multicast") > > Signed-off-by: Raslan Darawsheh > --- > drivers/net/mlx5/mlx5_rxmode.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_rxmode.c b/drivers/net/mlx5/mlx5_rxmode.c > index 173e6e8..4ffe703 100644 > --- a/drivers/net/mlx5/mlx5_rxmode.c > +++ b/drivers/net/mlx5/mlx5_rxmode.c > @@ -104,7 +104,6 @@ static const struct special_flow_init special_flow_init[] = { > .hash_types = > 1 << HASH_RXQ_UDPV6 | > 1 << HASH_RXQ_IPV6 | > - 1 << HASH_RXQ_ETH | > 0, > .per_vlan = 1, > }, > -- > 1.9.1 (NACK) While technically correct, looks like this patch sometimes break IPv6 multicast traffic as well, let's drop it until we figure out the reason. -- Adrien Mazarguil 6WIND