From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f177.google.com (mail-pf0-f177.google.com [209.85.192.177]) by dpdk.org (Postfix) with ESMTP id 14F0756A8 for ; Sat, 29 Oct 2016 00:11:51 +0200 (CEST) Received: by mail-pf0-f177.google.com with SMTP id 197so43891662pfu.0 for ; Fri, 28 Oct 2016 15:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=n8baHy9Etk03hTZCP0rvGvedRNue93mTaoawSlHXzfw=; b=0M/F2A4iN5jjaYvtCnM/PzvhgLWeya6kkLFnNXNCVM47DYBuASGEIqwUhJ67tNLFUf uTANaMnSRnlfS+vTRMpqRVyOky9OGlzIiR1daTCMarKP8J6YHpkJp+Ld1Piwk0FLDx5I FfBDHcAxZzHVyL+Y0ButrpQUNiekeiNLmh1KyKCoOj1CquuJOtI/2lF525WCzvDXPe3T /PRqYYFlGystjOouVokW9r5y4G0WSC/nL5MuyEc68K8ZFq+ONhie3AWFF4O5ZgCh6M6W S1xO8TiMkXLxLIKxDiv6TO05aEiIZUw5C9VPe6veeDeVHFq9jwmhWjFa4RJLnhUVj58O zp9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=n8baHy9Etk03hTZCP0rvGvedRNue93mTaoawSlHXzfw=; b=OdoME2ychiiFD/OVIb/flpUbJ6wkIs6cP1vO6T9dd/chX/2wooBQZGr3tEdt2IqsNv izoe/ziLWCynifQ7NY3hEhh++PalaqofS7/Zgq6pTZrj5vr7rf49c0CfDauSnKsSu5pi 1vTxqq8b+zhGZC3y0mxYYmg7UTKVe8kxd5td4Smur9PsifTf5rCcOgWea8m/OA0ELyI5 eXDTTMy0nC2K8gsK+AIMGamBehyV2ewwFci2lUC8P2hNglxar431xvAaIDuS/3dhS+/m lHFCokL3Y4EjJqaH+nbvGX4abB0CZeiFzPwSiA7/Meo2KLCozhPaQgeytJJts3iBotVH V7xw== X-Gm-Message-State: ABUngvcguifhmWmkrp/zCUJUiX0ax8qA7/P81clAx1+QhZngV17inDa3jft2QNQxAHz3Kw== X-Received: by 10.99.49.213 with SMTP id x204mr23545389pgx.92.1477692710176; Fri, 28 Oct 2016 15:11:50 -0700 (PDT) Received: from xeon-e3 (static-50-53-69-251.bvtn.or.frontiernet.net. [50.53.69.251]) by smtp.gmail.com with ESMTPSA id xg4sm21073315pac.39.2016.10.28.15.11.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 28 Oct 2016 15:11:50 -0700 (PDT) Date: Fri, 28 Oct 2016 15:12:03 -0700 From: Stephen Hemminger To: Rasesh Mody Message-ID: <20161028151203.1a47d895@xeon-e3> In-Reply-To: <1477636677-18041-1-git-send-email-rasesh.mody@qlogic.com> References: <4958892.sIoVxbTeGS@xps13> <1477636677-18041-1-git-send-email-rasesh.mody@qlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Dept-EngDPDKDev@qlogic.com, thomas.monjalon@6wind.com Subject: Re: [dpdk-dev] [PATCH] net/qede: fix gcc compiler option checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2016 22:11:51 -0000 On Thu, 27 Oct 2016 23:37:57 -0700 Rasesh Mody wrote: > From: Rasesh Mody > > Using GCC_VERSION to check gcc version and decide whether to include > that compiler option. > > Fixes: ec94dbc57362 ("qede: add base driver") > Fixes: ecc7a5a27ffe ("net/qede/base: fix 32-bit build") > > Signed-off-by: Rasesh Mody > --- > drivers/net/qede/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile > index 39751e4..29b443d 100644 > --- a/drivers/net/qede/Makefile > +++ b/drivers/net/qede/Makefile > @@ -46,11 +46,11 @@ endif > endif > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > -ifeq ($(shell gcc -Wno-unused-but-set-variable -Werror -E - < /dev/null > /dev/null 2>&1; echo $$?),0) > +ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1) > CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable > endif > CFLAGS_BASE_DRIVER += -Wno-missing-declarations > -ifeq ($(shell gcc -Wno-maybe-uninitialized -Werror -E - < /dev/null > /dev/null 2>&1; echo $$?),0) > +ifeq ($(shell test $(GCC_VERSION) -ge 46 && echo 1), 1) > CFLAGS_BASE_DRIVER += -Wno-maybe-uninitialized > endif > CFLAGS_BASE_DRIVER += -Wno-strict-prototypes Does this mean that less compiler checking is done or more? It seems lots of drivers make the excuse: "the base driver comes from another group and is known buggy but can't be fixed" That doesn't reflect well on the quality of the DPDK.