From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0064.outbound.protection.outlook.com [104.47.37.64]) by dpdk.org (Postfix) with ESMTP id 5FAC02BA3 for ; Wed, 2 Nov 2016 14:09:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/nmh5Oh6ueK8S8RcL9VUHTO1/8+fyBNQikT8eZ7C6Ac=; b=TjOyZ0yW7Ol5XSfVVLtnkQ6/TZCbKe9dQpyRda8UZAQgCgUaXAPDpkeXQLTgop8V8uR32xeaSEnXvz1FYZTzFyA1+7ay9PApEkgj3ThFg0SsMWe0oDmpW9bEeqtdrLB1TIOGIog1SYHlOPRbcCi9/lGwNeH0z3+5CaQCRPLc0Gk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.167.46.37) by BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.679.12; Wed, 2 Nov 2016 13:09:46 +0000 Date: Wed, 2 Nov 2016 18:39:27 +0530 From: Jerin Jacob To: Bruce Richardson Message-ID: <20161102130925.GC2564@localhost.localdomain> References: <1476214216-31982-1-git-send-email-jerin.jacob@caviumnetworks.com> <20161025174904.GA18333@localhost.localdomain> <20161026122416.GA21509@localhost.localdomain> <20161026125414.GB33288@bricha3-MOBL3.ger.corp.intel.com> <20161028030140.GA2967@localhost.localdomain> <20161028083646.GA82872@bricha3-MOBL3.ger.corp.intel.com> <20161028090648.GA32750@localhost.localdomain> <20161102112520.GB30658@localhost.localdomain> <20161102113551.GA40328@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161102113551.GA40328@bricha3-MOBL3.ger.corp.intel.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [122.167.46.37] X-ClientProxiedBy: MAXPR01CA0032.INDPRD01.PROD.OUTLOOK.COM (10.164.147.39) To BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) X-MS-Office365-Filtering-Correlation-Id: 18ca6bff-4569-4dbe-2b07-08d403218714 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 2:VMdLdmWx/fJgC2DpVGCBsMRMOTZW2q8nhQIxDLuE7ty3uqsT0itLAA3R/dPvCeYZiNTUwVsdLp9qCx2flbmLlGf69Qa9VKGF7s3wdMj1xdS6yyufSVvvYMRDAva3hIQT87b/ETyG3YGkMUSUr4eDvy8S7iPCzRQeaRstzJ4VAeQKw8KlqR4rIa4uOzVX2bP3c6JKRcMQ2J/E7pToHQMhpg==; 3:dqYxt2esHrqREdVaIaP5qFIajrDRPj3Wis1L7BiFDSiI23UK00MEkhG29ZhHuVPkCC70IZu2bNRTZGB59mFLBgfNqVQfDJh/+Thv2Njdb+s4h4Hw8GEad6sX6dWlAOxFI81lAvru3k6dTABU3RnV4g==; 25:Z9WFxYdVcrkfemlcT+Gm9VQaQj9OTx4K8ivEJaZtCclaJwtPeUH5wbwPiZXpnZ/k7hj1QlXpwt8oMCpz8jG6Yrz8XfGEy/S/P/qv/ieqcOQkCeT3+iDY/bzDsn18uuMEXx/ZMEc/tlKHHsqfb/EsBqJl30mLiLBBztMqUimn6enI9BH1r8PqMi2O65V4tpiOJjRUSepGhOPhwHwTNz6EGeAF9uvOhuPd968n4IfDihtNJq9QXCF9xew5/nrkJsDi89luB0vvRYDbzSNpgS/8LZV4GGJMjbl4EvLnlcmYcg24f6V8xCCmTFQVumi4VNrW5vbi7Q6zPxq7Gbt9g3hLE5CcXqQCfbL7/GDsuKH3IYM3v54LLKnEenMVcTM4BvB9jhfb+OC/x/HzsxArmBluhGnSTaWTwyiGtZKVsw/+7SQdgcO/zJdk8mtSlHUJ9tpg X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 31:VT67q+3OlPllWS1++amhV8zcDt5lG4UiixTeImjc7g2Qkj2aFwEz7cVHWaIqJHTyWkw56CmTJ7aoCSaBzTvUhV2k/woiN6YxZyKKjeHO5Ugk1Hw0xUQDdWaOwJsQtGlZQcs6pWouup9qZ97/xTAYtPQMsOMj3te3xS/ch1dNODk3MHZz5Rj56RoVOOWEzd4AL0jhzG7sopXQ0uyyL3J/lv+iGYjdmfuH1WI48pHuORQhOgjCZqyGiim/OFk5DDCW; 20:Qv0/mQN2UmXdUo6QqzuZjW9NbC92EkPE18TXCBFHCz8p3sLfNJ3NK6b2skCMD/NyfgPE4pwcInCDwDKHw7FRvsS7SQwWmyCAQyOkjPDBLcTDiJ8zfHlnwmfFCjVRDyrQHEUsr0dLJPTQJSUOzpTCbSvaCoDHAsxD8rpAXNI4gEs7vGGtsoyaaSd1MYCaUOgnY4nxQJrYRVudTzceADvC4ShLx2S6+X2wLKgF0I8DzBY2HebhgdLNbphod0jvdpbnLyT+8Qq0W8QivEXTXiJIkNHXhkESz/8SAst/LoQUwfDo75zdWg234j8Xst96HDJ9s1rPx90BXPvWRSgtLYW25DfbAMcVBSBdCuf+t+cNtKsXxMI57FzL06mhyl/RoXSUcO+ASy0dgNDJJJxQ8u4nOUOUh/YwOIay7WoMZ4MnboNaEl/TZHDGgwqlFT6TMhpce60omG0Nxna26GtlJp7LjFLVpNi4mMHhMMMFVonR7l+ddSvCBIJyBe3QmWQoEaNf7KheIDkltiRa4kHkuyvndvrNTeCHMdHv4pR6Q0Bly4FrvWT+U8TbouzzaE/Yr+ZWfAt3zXsFh3Qk1ldfeTTzzf27Mfmev+1d9/U/GpJazHA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:BLUPR0701MB1714; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 4:fzebmNLzFRVaFsp8zXHo4859fEzActi2FqyX13Rk7VTCp2UuCpNLhGeccQ9kRvoLaCrFpaXe+RXIUJQX90D3LICQG5r39jKJok6h/BY/Vt17C2LAb5gSlCBxhFb8URi9P2LrFd/hPMZ8muw65CXAFjUnjbbokcGnl5CwywNseIAeGuU9PpAESEuUO/+t2Zmnf/7vSLXG5AacTItcrDyvYxwrkQPbQCd2oeI51Y1DlH68ftv/qfz5Jk7v4uwYFpG9vvia2PPA//dwjWbp4sjExBJWj3dPFzqJPQF2GK6CQQVvYjQsOCS4duNPIJDj1th1WIJa4qmuNRA0e/jN66PF30DYzG8eRTw+0+P76N12117VEj0GXYEW/0zmBmQHVdkQR3Z08ttnhvDSaHJQNsrVuQ== X-Forefront-PRVS: 0114FF88F6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(189002)(24454002)(199003)(92566002)(42186005)(68736007)(66066001)(106356001)(105586002)(23676002)(575784001)(110136003)(5660300001)(2906002)(6916009)(83506001)(2950100002)(42882006)(4326007)(81166006)(586003)(2870700001)(6116002)(3846002)(1076002)(6666003)(93886004)(50466002)(9686002)(305945005)(7846002)(7736002)(47776003)(8666005)(61506002)(77096005)(81156014)(97736004)(4001350100001)(8676002)(33656002)(189998001)(54356999)(76176999)(50986999)(101416001)(7099028)(18370500001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1714; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjA3MDFNQjE3MTQ7MjM6YWptbHhIazhLbWR3R09pRWJ1Z3czWVIv?= =?utf-8?B?QU1od1RjdEMyYzh4SHpNSTVEWXp5TUVpYk1lMVNobjdmNUpMZFRkSlpIZGR5?= =?utf-8?B?SFpqenE0M3ZjK01Sckx3dGJ2ZkpaSDBCUjVVbHVsaDFWU0pMVHFxeUk0blVX?= =?utf-8?B?UWNhQXo4cE9KTHVGV3ZWNzh1a0wrMnM1aWxYUzlxbk44cEF3dzZodVRjNEUx?= =?utf-8?B?Ync5ZkcxeHlVRVFiMHpjN3QxL2l0dTFsNk9pT0RTVWpCVWJjTlIxN3VOcGRW?= =?utf-8?B?djZjQk9NZEZxWE9NTER5S0d0U0V6NkZSN2UwTWZQUkNMdmdoYVBwNGdvVkRs?= =?utf-8?B?YmcvakIyTUdJcXkyY2VDUGgrRFdtdkMwTEVlYXhFT1dwVC8vL0huTXNob2J6?= =?utf-8?B?U2VMYUl3ZGdjOGNCOUJHNkVKTWFaaWh3eU5Camw4c29xL2N4OGJ6bHVkcmto?= =?utf-8?B?QkJqZFZ6L205bUYyeFRtUWtXcTl6V0ZKV01MWCtQT1VsSms1VmlzMEpDQTc5?= =?utf-8?B?SURKZmp3Q20vZWVPeWRKbzdoN3hsdFNTRnY3QTlwMENNVmVKWVFvNU9aSUxM?= =?utf-8?B?U2RCOWZaeFBRendqeFJNdlJ2anN5cVU0eDdSa004TEJlSk4rWG5LS042aXVr?= =?utf-8?B?dG54QVhlVkZVTHlWTzBkRC9KLzNlSjd3b0RoMmVDbG5TZ0RpU2d4OHdjUlRu?= =?utf-8?B?VzNoeGNFYzdYZ3EzN01yUnRuY2FlWnY0dTNZQ1NlcWFrVjZrRHE1a1dyNytP?= =?utf-8?B?VWI0bkQxWXljMVQwQnJXS3FZT0hFUWc3MVl0VmpvRm16djgxeXJoR0hWTTVq?= =?utf-8?B?SmU4djdpbnF0Z0QwcHEzSTJKcW1qTFNTZlV3Mm4yTzhJbWZ6bTltaHNNRkZz?= =?utf-8?B?M0h0SWh6OGRKZWhueGUzK3JWMjZsb2xhNlY4cy9SbHZkaDJobVFua2NGYlJy?= =?utf-8?B?dkY1UVBQYzJFMDQySkZJQjBMdWh6NTlFejJ2TEZVeGNwdFQxV3pLSU5PV3dC?= =?utf-8?B?WGlsSFN6U21lM3hlK3JYOTJUQVhzeS9SZVV2ajgxQjlKV2xTSVd1dDlsWjNr?= =?utf-8?B?aFpmZUVHa1F0NzExVERYcXZ1SDBadFdYWVg2UllaSUxPa3NXTGoyeWRpWHZD?= =?utf-8?B?SjlQUDBCUEtnTFRwRjU1b0Yra2I3SnBJZE96bDBqOWdrZjBIL2VGZGYyY2xo?= =?utf-8?B?Ty9XZ2JJS3VMR2EwcGRydnI2WFlMMVRXNkNGMHZVK0h0SUwxZFI2LzZ1Z2Rh?= =?utf-8?B?NEt0S0VNdVoySWNRSU1VbWQ2emVnQm03ajlGdGthbTJpZ0RGdGFHWFdrUVAz?= =?utf-8?B?UDNSM3c4djhCdHpKajV4OVcwY1FhWThOSXlpNE1zWHROZFR4MWxDVFQzdWlq?= =?utf-8?B?dDc1NHQ3aWVxRVltdUV0SmxUREwvTzQ0cWYzTVg5ME54YTgxalpZK1RJbWU1?= =?utf-8?B?cUt2ZXV5ajhUU2FscGtHL1Y1OGd6OUVYbk1pNmFhY2p4dU0rQ1haK2dYZjhz?= =?utf-8?B?VHpEeXVJWjE2d0tFWDB2b3pTS1Z2c2doZVpjVS93N0czZlpiMXVhRHMzMm5x?= =?utf-8?B?UzZRTmhDdXVlRHJQamVxa2JCeXR0YVRYRVN6OXdhbjlWbXRmSEd5WHdDVHFl?= =?utf-8?B?emVLd0YwNFI4bUhEU1dvMzZCd2pKM3ZKWGxoY05mcXBzdXpMWGN2b1BCY01E?= =?utf-8?B?RnlRelJ5TU9kTkN3cDlSN2ZGTFp2N28wQXNhQXlzT0U4VjR2V0prOCtpcWxO?= =?utf-8?B?OXZoSWJOeG42MXlPQ25qYTR3PT0=?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 6:AzPkqNYP0mHIGST7FJRT4TtjvG2LHmMMqpbasJpRkgB9VFtGw6CaSzYlqKK9QR1+Nfx7ORaGFWVRsBeUqdy1AGpOh1gSXbfr4nbQFT2tuq/zAQv68o6qoOBzgiTVWJZyxMilYaYqmpx2oM9gIERVmJcGqVPSJxvRdQHe3n3VGATTFxOKnzj7e5BNTOP1hwAHJR0KB8RlBKOjMuuzgZZSOH+ssNc3czDb3Z9qP4loknNjXSc+uQfuiltJxOiQpjFPFXkGeKGy81Q2QBc2vADMcr0kIES3ddwlkq1Af5qFrykxt6pIJiw6MDes6J8ycbSr; 5:y8yYhTRj5gvDj/UEiaGTL3hAHJ2z+x4TV7kvO7GYVoDTyOgst9yaKuewjwQzSNfs7EMzS1uFxKLeGUW+pfqTOVCV1u0MFpEQn0e1asJvznDlUQ7jRO5YP4ZVoli1/IbzIZsPdf1vbMZdyhaYxo71lwX0xO3SVpKZMnMCqE5io6k=; 24:INtxT6tKFThtJAIVAhjK8szPXK6obvEdFzQuRCVTHNHWUcQ0V/W1ox6w1LHUw3otv4toNpfMV5bycwCnmcbQIZm+2lUT2exGKnBjpLwUkOA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 7:OiVBP4gCBOp33tHvkHw2aUZzyVnDajMJwGEnqwX3ykUrflcz3cEr+4zZcRmMIVrddwPkVb2kum78vtTYhcLn2i4zjmg+nR5a9VK22oc8SQ2uuRvEqFjTcVG4jcpo83Up9D9VRWaQgQmJLGUPtTKVB6SkmeZhitLvyNkTLE8axr+dc11PGOCLbWCrEzGyaZnG8c3xP0g0D0DNEcfKAhjtItpMLQKpEA9WLxx2wP69p+O5TVjKSe2D6QCfsMWDNV5z3KO+o/IChkLhPTrat2fD4nUYK0kAO+xu1e6z9QRLAFGhHV4+1Q3SbMEH58RFtCrZ4YK70/757+m2bezBVxNiW1KHfaWjw99Nzn2EQn2mjm4= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2016 13:09:46.7692 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1714 Cc: "Vangati, Narender" , "dev@dpdk.org" , "Eads, Gage" Subject: Re: [dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven programming model framework for DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2016 13:09:52 -0000 On Wed, Nov 02, 2016 at 11:35:51AM +0000, Bruce Richardson wrote: > On Wed, Nov 02, 2016 at 04:55:22PM +0530, Jerin Jacob wrote: > > On Fri, Oct 28, 2016 at 02:36:48PM +0530, Jerin Jacob wrote: > > > On Fri, Oct 28, 2016 at 09:36:46AM +0100, Bruce Richardson wrote: > > > > On Fri, Oct 28, 2016 at 08:31:41AM +0530, Jerin Jacob wrote: > > > > > On Wed, Oct 26, 2016 at 01:54:14PM +0100, Bruce Richardson wrote: > > > > > > On Wed, Oct 26, 2016 at 05:54:17PM +0530, Jerin Jacob wrote: > > > > > How about making default as "mixed" and let application configures what > > > > > is not required?. That way application responsibility is clear. > > > > > something similar to ETH_TXQ_FLAGS_NOMULTSEGS, ETH_TXQ_FLAGS_NOREFCOUNT > > > > > with default. > > > > > > > > > I suppose it could work, but why bother doing that? If an app knows it's > > > > only going to use one traffic type, why not let it just state what it > > > > will do rather than try to specify what it won't do. If mixed is needed, > > > > > > My thought was more inline with ethdev spec, like, ref-count is default, > > > if application need exception then set ETH_TXQ_FLAGS_NOREFCOUNT. But it is OK, if > > > you need other way. > > > > > > > then it's easy enough to specify - and we can make it the zero/default > > > > value too. > > > > > > OK. Then we will make MIX as zero/default and add "allowed_event_types" in > > > event queue config. > > > > > > > Bruce, > > > > I have tried to make it as "allowed_event_types" in event queue config. > > However, rte_event_queue_default_conf_get() can also take NULL for default > > configuration. So I think, It makes sense to go with negation approach > > like ethdev to define the default to avoid confusion on the default. So > > I am thinking like below now, > > > > ➜ [master][libeventdev] $ git diff > > diff --git a/rte_eventdev.h b/rte_eventdev.h > > index cf22b0e..cac4642 100644 > > --- a/rte_eventdev.h > > +++ b/rte_eventdev.h > > @@ -429,6 +429,12 @@ rte_event_dev_configure(uint8_t dev_id, struct > > rte_event_dev_config *config); > > * > > * \see rte_event_port_setup(), rte_event_port_link() > > */ > > +#define RTE_EVENT_QUEUE_CFG_NOATOMIC_TYPE (1ULL << 1) > > +/**< Skip configuring atomic schedule type resources */ > > +#define RTE_EVENT_QUEUE_CFG_NOORDERED_TYPE (1ULL << 2) > > +/**< Skip configuring ordered schedule type resources */ > > +#define RTE_EVENT_QUEUE_CFG_NOPARALLEL_TYPE (1ULL << 3) > > +/**< Skip configuring parallel schedule type resources */ > > > > /** Event queue configuration structure */ > > struct rte_event_queue_conf { > > > > Thoughts? > > > > I'm ok with the default as being all types, in the case where NULL is > specified for the parameter. It does make the most sense. Yes. That case I need to explicitly mention in the documentation about what is default case. With RTE_EVENT_QUEUE_CFG_NOATOMIC_TYPE scheme it quite understood what is default. Not adding up? :-) > > However, for the cases where the user does specify what they want, I > think it does make more sense, and is easier on the user for things to > be specified in a positive, rather than negative sense. For a user who > wants to just use atomic events, having to specify that as "not-reordered > and not-unordered" just isn't as clear! :-) > > /Bruce >