From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id EC346100F for ; Wed, 2 Nov 2016 14:56:31 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP; 02 Nov 2016 06:56:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,583,1473145200"; d="scan'208";a="26904157" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.210.137]) by orsmga004.jf.intel.com with SMTP; 02 Nov 2016 06:56:28 -0700 Received: by (sSMTP sendmail emulation); Wed, 02 Nov 2016 13:56:27 +0000 Date: Wed, 2 Nov 2016 13:56:27 +0000 From: Bruce Richardson To: Jerin Jacob Message-ID: <20161102135627.GA42352@bricha3-MOBL3.ger.corp.intel.com> References: <20161025174904.GA18333@localhost.localdomain> <20161026122416.GA21509@localhost.localdomain> <20161026125414.GB33288@bricha3-MOBL3.ger.corp.intel.com> <20161028030140.GA2967@localhost.localdomain> <20161028083646.GA82872@bricha3-MOBL3.ger.corp.intel.com> <20161028090648.GA32750@localhost.localdomain> <20161102112520.GB30658@localhost.localdomain> <20161102113551.GA40328@bricha3-MOBL3.ger.corp.intel.com> <20161102130925.GC2564@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161102130925.GC2564@localhost.localdomain> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.1 (2016-10-04) Cc: "Vangati, Narender" , "dev@dpdk.org" , "Eads, Gage" Subject: Re: [dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven programming model framework for DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2016 13:56:32 -0000 On Wed, Nov 02, 2016 at 06:39:27PM +0530, Jerin Jacob wrote: > On Wed, Nov 02, 2016 at 11:35:51AM +0000, Bruce Richardson wrote: > > On Wed, Nov 02, 2016 at 04:55:22PM +0530, Jerin Jacob wrote: > > > On Fri, Oct 28, 2016 at 02:36:48PM +0530, Jerin Jacob wrote: > > > > On Fri, Oct 28, 2016 at 09:36:46AM +0100, Bruce Richardson wrote: > > > > > On Fri, Oct 28, 2016 at 08:31:41AM +0530, Jerin Jacob wrote: > > > > > > On Wed, Oct 26, 2016 at 01:54:14PM +0100, Bruce Richardson wrote: > > > > > > > On Wed, Oct 26, 2016 at 05:54:17PM +0530, Jerin Jacob wrote: > > > > > > How about making default as "mixed" and let application configures what > > > > > > is not required?. That way application responsibility is clear. > > > > > > something similar to ETH_TXQ_FLAGS_NOMULTSEGS, ETH_TXQ_FLAGS_NOREFCOUNT > > > > > > with default. > > > > > > > > > > > I suppose it could work, but why bother doing that? If an app knows it's > > > > > only going to use one traffic type, why not let it just state what it > > > > > will do rather than try to specify what it won't do. If mixed is needed, > > > > > > > > My thought was more inline with ethdev spec, like, ref-count is default, > > > > if application need exception then set ETH_TXQ_FLAGS_NOREFCOUNT. But it is OK, if > > > > you need other way. > > > > > > > > > then it's easy enough to specify - and we can make it the zero/default > > > > > value too. > > > > > > > > OK. Then we will make MIX as zero/default and add "allowed_event_types" in > > > > event queue config. > > > > > > > > > > Bruce, > > > > > > I have tried to make it as "allowed_event_types" in event queue config. > > > However, rte_event_queue_default_conf_get() can also take NULL for default > > > configuration. So I think, It makes sense to go with negation approach > > > like ethdev to define the default to avoid confusion on the default. So > > > I am thinking like below now, > > > > > > ➜ [master][libeventdev] $ git diff > > > diff --git a/rte_eventdev.h b/rte_eventdev.h > > > index cf22b0e..cac4642 100644 > > > --- a/rte_eventdev.h > > > +++ b/rte_eventdev.h > > > @@ -429,6 +429,12 @@ rte_event_dev_configure(uint8_t dev_id, struct > > > rte_event_dev_config *config); > > > * > > > * \see rte_event_port_setup(), rte_event_port_link() > > > */ > > > +#define RTE_EVENT_QUEUE_CFG_NOATOMIC_TYPE (1ULL << 1) > > > +/**< Skip configuring atomic schedule type resources */ > > > +#define RTE_EVENT_QUEUE_CFG_NOORDERED_TYPE (1ULL << 2) > > > +/**< Skip configuring ordered schedule type resources */ > > > +#define RTE_EVENT_QUEUE_CFG_NOPARALLEL_TYPE (1ULL << 3) > > > +/**< Skip configuring parallel schedule type resources */ > > > > > > /** Event queue configuration structure */ > > > struct rte_event_queue_conf { > > > > > > Thoughts? > > > > > > > I'm ok with the default as being all types, in the case where NULL is > > specified for the parameter. It does make the most sense. > > Yes. That case I need to explicitly mention in the documentation about what > is default case. With RTE_EVENT_QUEUE_CFG_NOATOMIC_TYPE scheme it quite > understood what is default. Not adding up? :-) > Would below not work? DEFAULT explicitly stated, and can be commented to say all types allowed. #define RTE_EVENT_QUEUE_CFG_DEFAULT 0 #define RTE_EVENT_QUEUE_CFG_ALL_TYPES RTE_EVENT_QUEUE_CFG_DEFAULT #define RTE_EVENT_QUEUE_CFG_ATOMIC_ONLY (1<<0) #define RTE_EVENT_QUEUE_CFG_ORDERED_ONLY (1<<1) .... /Bruce