From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0054.outbound.protection.outlook.com [104.47.37.54]) by dpdk.org (Postfix) with ESMTP id 6BA7E1023 for ; Wed, 2 Nov 2016 15:56:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kv2ZJb31aeU8HoGA4Hd2XBBWh7iJa1EpyH0njfxoqs4=; b=nz0LDpRqusjktxJg1Hy9bmzRk70ncmywgzPxGb60iLtaWsUMVmamPUbPvdprJXfVvMjoWLGC3eA7z0zyuHO4enPFqRPmQ6q/JFS0KyNXnsvWqSuB81XwSC0X7f2d0JaZMwwgDmSAO2SFwVeegl1iOevLciFlW+vQfUPav9nv/Ao= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.167.46.37) by BY1PR0701MB1722.namprd07.prod.outlook.com (10.162.111.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.693.12; Wed, 2 Nov 2016 14:55:02 +0000 Date: Wed, 2 Nov 2016 20:24:42 +0530 From: Jerin Jacob To: Bruce Richardson Message-ID: <20161102145440.GA8552@localhost.localdomain> References: <20161026122416.GA21509@localhost.localdomain> <20161026125414.GB33288@bricha3-MOBL3.ger.corp.intel.com> <20161028030140.GA2967@localhost.localdomain> <20161028083646.GA82872@bricha3-MOBL3.ger.corp.intel.com> <20161028090648.GA32750@localhost.localdomain> <20161102112520.GB30658@localhost.localdomain> <20161102113551.GA40328@bricha3-MOBL3.ger.corp.intel.com> <20161102130925.GC2564@localhost.localdomain> <20161102135627.GA42352@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161102135627.GA42352@bricha3-MOBL3.ger.corp.intel.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [122.167.46.37] X-ClientProxiedBy: BM1PR01CA0002.INDPRD01.PROD.OUTLOOK.COM (10.163.198.137) To BY1PR0701MB1722.namprd07.prod.outlook.com (10.162.111.141) X-MS-Office365-Filtering-Correlation-Id: b1884548-2061-43dc-edcb-08d403303c41 X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1722; 2:J/nMadssU9UaeaNpDgU5hQnH87c+cTDYZivKCS4xhk0lEXsynifDbAXeF2JfG+q2OBUAbopRUn7G3tdGQrLd6GsgQCUV/C57CVrys6vG1hykjlfZvgwVasHNy/nYVpqQNIkVCqotHh3NAX1zXsoPhbStO/L539wViJMD5mbGmAdJaV3TOIh8l+vKesIYrjiDwjN62van7eEdEozEDQJjuA==; 3:OWQyvn6wKpBWmFNMduYo2uCJVigIl2DyuHAwzuP2Y+TY/3QdO+0B0+dKWDF1vN6AYmgldnfQ0ykaZBfWUqCip41HdxEL1KhTRyPFgbVy3NPtNXi2juB3hnUv2nql3SSeB2D/EKyU8OoHRBAhKwwhvA==; 25:9EW5iDA96eWvcnk40slgVzMcht38x3ZyZppJQOhhhnBqv52kt9ReZ5/Fr30B5oM9KWKyP3my8jCooirc7R4t+FqA+HHoBfyc6dDK1mW/clxJK7SxPGSKMEZN3Pnrp1S8iASHN1Kc3hz9rTLof7MC10ypXkjH2An0d3otzJ/BH/HA32L/7rogF0PT/TkmSLDXUQLVJIQmBnUhKN11XALv+Byharc1oJggqPWOPvc523BrHPB8uMwX/e+NFs2WtBSB0196GNBEjTQztTsBzw0IutaBQKbEy+zk3D858g0W7lQg1Ry/NLI4pUvMrWEOAuehbQibVCvuvaueF1v1IrJVkbqwkhWNp4dQyFIp79UKU9fe9jgtaV33KNJtmfowvdJHdvwuoQEWUCqnKWBtmIYO7K/t9u2HCo/Xeu3jFcAJhiA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0701MB1722; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1722; 31:StuSRNv7ABUNNRZTPnDAwwdFVwDyUkItyxxJqMIM8OeiBpl2WxccG+PhQU/Gdw+sd/5INsh4LMTbJb7id7oG5bHTbVRFrZZCAVfcRW5WIHvcu2Oyc3Inbrb4xsZO86RvTmSmTfeb6snF8anmrX9qpXvcMSd2YXeh90V7E4WM/F72JZsN3uq+XyzJW/dIRLJL42LKnq1lLenMy/ZV32BhxaEeQR/kPzINMwlZzgnLloXNfxaHGOlFktGcj6thj/TG; 20:TvzZkkaypLAB9jJ5/l8uCz+q1XMuqvr82+RY8BN8IMcK8evvE13CtihmdcDW6IBXeTnvOzy/fmoytMtPbwqsF/3OGXNiuR7Sxi4LxbxQTKAKMWapQROxGHHZwN3jt5FUMzum5SUAUVDdvpri7BT8QunFXUMColgnoDwmirjfZImjFb4nXyVCxJ8SfjlDfQOO3atOkrQgsBYzu5vKMPRrRpODm/Z4uL8VcY43JeXVv6zk/kzd4IzpYty5OMhKNGKloVNsSkJV5QVNTFXX2TnEikaex4hdiLfL4qwL4WUJVeGjeRklcvQcYICDkBQF17q2d5z7pxybJHe/G/aM12DHJd8o4ITPlf4r5a6whkz2HHEblodcKRmQqp3mhaNAy5+iWWtQWaVdgfUN/6S/ZrbcYcVgiyRBNTKEibI4PKLAlcuWJHk0XMddbG0ecgjK8AOyGdF7imYQ9/4ysNk7FxlYzQ/J7AktUkJIVsioaMJla35TLl6uRCAPdtvznpkWa2JrB3nyNLMk00Df2FEQuX2rdno9GXIHwcqLIKfKOEhJwGb1ktWbn7DLMzMx2FcqdmD9HPAJCm1OYxWDJxkcBfAib162AuFLGO1E/suPTn4XbN8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:BY1PR0701MB1722; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0701MB1722; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1722; 4:VvnCRSjkGHJizSfenpkKS/m0BBUCGuI9R+qLHAHxwi7yg4AmGPEqj/PzarRsuNmISUju2yHGKHBqOMmGe6IgYCTEQ5WpphoIhMV0SrBxYf9ad1/GBCutkU4YVV5SybmUQfuDotz0fSZnbsc1cHPMVt6J0NltQbBLnh2YpgixQlJM3bgdBDg8edUEjhvjK78Avf2y26FZXwodBHfRDsUBEQ3XByeCwhpMC8qChB75Vm+Xg66L4uX1tu/xUQWu/AC7I+Hy237rZty8bS+eJYDigk1J95F9zKfUR/2ZBI8ZhigAct4UsJJdcM2R1ph1D90xAgTxVKtS4vrbHn7nv29fAcoeg71ThJ8nlSs3BmIDQ1o/XXBGhf+ZyXSkVbZLGpWj+G4n0vYri7NmGIiD7yospg== X-Forefront-PRVS: 0114FF88F6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(24454002)(199003)(189002)(47776003)(50986999)(4326007)(81156014)(97736004)(3846002)(83506001)(2906002)(4001350100001)(66066001)(50466002)(6116002)(61506002)(93886004)(23676002)(575784001)(68736007)(2950100002)(6666003)(8666005)(2870700001)(105586002)(92566002)(7736002)(42882006)(42186005)(1076002)(189998001)(586003)(77096005)(7846002)(6916009)(76176999)(305945005)(8676002)(101416001)(54356999)(33656002)(106356001)(81166006)(9686002)(5660300001)(110136003)(7099028)(18370500001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1722; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjA3MDFNQjE3MjI7MjM6WFlOR2gzS25QNFlNbjZaNDlOL3FYZzdO?= =?utf-8?B?bjV4QnB0MDdHdkhhRzRXRnRJdGd0TEZYaDFuSkt2UTFCV2N6eG5QTDhGYVQy?= =?utf-8?B?c3orMmZHNWVqeVNHdStQeDFCZUUwTjRPQkdlUmdEM2hMVEpXTlZzR0NQdE1P?= =?utf-8?B?TjdQU29aYjB4bXZBZFExUThVNXJhMVBkVno5VTFBSFNjVkR0alBUWHUzMzJ2?= =?utf-8?B?ajkrN2tKUkZVUXk4STNCRHU0UldyditMTkpkSzNYZElKNmFNTGxyaHlCMDdO?= =?utf-8?B?YlFUNDZuVTJxOVVXcXRKaEpBcUc3QlVWZXE4ek01akNpdDlXNjlqNTRzWjdk?= =?utf-8?B?WlY2TnFZeGNPWlA0L0pXWjJ3eE4rcUtQZS9ybS82aVNsckp6R1FQWFVPWU1Q?= =?utf-8?B?NDNxLzZqOXlxTE5uMDZIK3pxS2RQYUxqQi9tSittQll6cHFpdkQydGN3ZTR3?= =?utf-8?B?SmxTWWRPU2o3UlV2am5MU1BUV29SYnRqbi92c0IrV1ZYTzJ3SnVaNmMzaWF6?= =?utf-8?B?eXBTUDRBamJSWkpFc0tnSFQ3dEpiaHNzMXlkTWlEZVk1RGE2MDAyZExaTDdQ?= =?utf-8?B?eEVNVzU0cXAxS0F6eEtsOUFGS1M5YkpOVExGNExtT2dRTElBSTBsRjBUL1Vj?= =?utf-8?B?enlmRFRRUm5Hai8rSFN1RDcycngxTC94NHhvRGVvaFVGL2xzQTV2VVpteDVy?= =?utf-8?B?cVZiOUJRNCtEdWM4Nk5ZVnJsUnB1dktrR1FxdHhJeThtS3l5RFBJZ3ZXTlc1?= =?utf-8?B?K00zeFFZVnh6Mm1aR2wvNFljRDhXT2ZRUms3MTVoMVVwZGMwK05IMDFJakJh?= =?utf-8?B?R3FNTGZEZitFeWpadTI2WXhpL0g0bVVYYVhiblo5ZEtwMXVMYlBLSTd4QUVS?= =?utf-8?B?Q2ROcWVBS0ZMb2hGbWpWTnV4M3JVd3NRR29zbG9Sc3F3Z1JzbTRsTnRHWkoy?= =?utf-8?B?UzMwU2k5MEVMWThzNFlrdzZ0Wkl2ZzdzdmRjc3ZickNxUjI5ZWdmNHd0b2Rm?= =?utf-8?B?Ry9lSGdrZWN1ZVc3dCs5SEJYMDVZbXEwclZPdFg4dlhpUU9BU2FzbDdVcHk4?= =?utf-8?B?MGJUWERING9iN1dtMjFJYjBxU3p2MVpTejBSVjBJRHhCV0dyZEE3aWo5ek5i?= =?utf-8?B?QVJpZUtrQkNjK241VmRpWVllaTVPQUJDSWFWcWJhMnRNZDE2ZlZhSUgrWWZy?= =?utf-8?B?SFJuNnd2SEtTSmYrRzdCQWRzbkFkdFFaNEk2VEZndEoyRkUvUGIxZEpxbDV6?= =?utf-8?B?UnBXQ2dmOEl1c3BjZGpFRlN4c3FoR3ZrU3QrTUk5RzZRS2l3R1Zqd0pZUldn?= =?utf-8?B?bWdxSTVmT1ZXYUhOV2RuelNpdnhvdnRxeFg3ZFNPQlFsQlA1Z3h0TlRTUldt?= =?utf-8?B?NVI1VGdxMkxIY1FzTTZ5SU41elkwNE9UdnJKR0t5ZitDeU41a0ZLa084cklC?= =?utf-8?B?dnBrOUltbHF3S2lxeWhnOTlqdlcwZU5SV2pDUTNZTGRBRjM1YmdiaENMT1Jt?= =?utf-8?B?WTBYL3d2OVVEYWRpSm5nOFI0RzdvcFRGeHFkWmVZWlBUTmM4djZMTlNOZS8v?= =?utf-8?B?YlpQTG5RQVdXdmVRWkprYllKbTQ3WGFPcCtrT3BKNmtNOGpsWlljZUFjTnBs?= =?utf-8?B?ZXVSb0hjZmkxTG02T3hZQUVycXVpMmZ0QStXN21EbkJsT1V0aUQrejBubnFK?= =?utf-8?B?ZU9uWU9zSzRXejA4ZHQ0NEFYYjdWazFpR25oWEN6VDJjY3ZJWlpPVlhJcEYx?= =?utf-8?B?cmRmU0t6Q1U3SGxPcEovSDVRPT0=?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1722; 6:AQpWjp3/x9KkGbJ32GMIswlngihjs3y2wz+pDsQLEP4EhJ4TOhaZK7oqnZ9Z2UCiMWwFx0z9lrEDVC0ibXD5VVxUEin6ftqNvOk0c96HWNPRR0i/hdJWtXk+dKnUsrEa359mB7uB5YsFd0XAy2Dx8QWET9emcFlrovSpLiYv6QlHh/+DaQhYPOQReE83q9seIOkLOpOCR2U/1lLXGC+2XKqlou0lNJVLChQyb8rEaYE2bUKmnjOWYULNLWSp5B7PpQd5rHGHdDFXU5IaB/GaomMy6M0+FoDbBC2usuf69bA6fuRYrGoavtmppAbx2duY; 5:uc3shIFaFrvh2F+YobnQlwhab6cNB+00mo0x0u3w7Wrf0F9qpKeNIe1lcZvYehHYpCMgUihjdvBlL+xCm/db2TRZqYPlPSZ0y52SFDFg/ZJSp66dyOCMNDsrjzbYio5qeeaB82nJU/JcRwURB8ibsQ==; 24:VXl+5CRZxrUvh1KOd45RdBqy6twyZhzGrlzfOP76Rj+0icklcTN6qVbeRVXAZLEHHPjEWgurXHiKGlm2P6PJKSt+Qw8EuO96Kee9qm6kZmo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1722; 7:xrvU+79En0/vkFZJC2kvSeHVL0lKWHNE7pgg4Yd6q9vE+WujCxCAil3utccHLXIIryqWLik6ISJTqpj9umFOkH68bVDUk5r9686bG7+O1xwmiAufndh10NY1Rpum8VEQIKXNdobzAMkaBJxmu6QPaclhKOKil4BIXQ203quMIXPY74KlrDVeydsrlyS+f76PTmhX9bTYkhRy8p9MrIX4HCOwabtfgR5J/CKdsXOSs6kqiiJlgxEjhAZYu9Vz220PgEX1eEaKPwjAjLiLVkj5Z24NnY6ByjjBhFZRdJdhYA3orX0sKCb3XMzbROjJ14ncYwZ5tWjAI0pEq8t/l1drkXoYu0zNPf7SoiOCiwWZjVg= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2016 14:55:02.6714 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1722 Cc: "Vangati, Narender" , "dev@dpdk.org" , "Eads, Gage" Subject: Re: [dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven programming model framework for DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2016 14:56:18 -0000 On Wed, Nov 02, 2016 at 01:56:27PM +0000, Bruce Richardson wrote: > On Wed, Nov 02, 2016 at 06:39:27PM +0530, Jerin Jacob wrote: > > On Wed, Nov 02, 2016 at 11:35:51AM +0000, Bruce Richardson wrote: > > > On Wed, Nov 02, 2016 at 04:55:22PM +0530, Jerin Jacob wrote: > > > > On Fri, Oct 28, 2016 at 02:36:48PM +0530, Jerin Jacob wrote: > > > > > On Fri, Oct 28, 2016 at 09:36:46AM +0100, Bruce Richardson wrote: > > > > > > On Fri, Oct 28, 2016 at 08:31:41AM +0530, Jerin Jacob wrote: > > > > > > > On Wed, Oct 26, 2016 at 01:54:14PM +0100, Bruce Richardson wrote: > > > > > > > > On Wed, Oct 26, 2016 at 05:54:17PM +0530, Jerin Jacob wrote: > > > > > > > How about making default as "mixed" and let application configures what > > > > > > > is not required?. That way application responsibility is clear. > > > > > > > something similar to ETH_TXQ_FLAGS_NOMULTSEGS, ETH_TXQ_FLAGS_NOREFCOUNT > > > > > > > with default. > > > > > > > > > > > > > I suppose it could work, but why bother doing that? If an app knows it's > > > > > > only going to use one traffic type, why not let it just state what it > > > > > > will do rather than try to specify what it won't do. If mixed is needed, > > > > > > > > > > My thought was more inline with ethdev spec, like, ref-count is default, > > > > > if application need exception then set ETH_TXQ_FLAGS_NOREFCOUNT. But it is OK, if > > > > > you need other way. > > > > > > > > > > > then it's easy enough to specify - and we can make it the zero/default > > > > > > value too. > > > > > > > > > > OK. Then we will make MIX as zero/default and add "allowed_event_types" in > > > > > event queue config. > > > > > > > > > > > > > Bruce, > > > > > > > > I have tried to make it as "allowed_event_types" in event queue config. > > > > However, rte_event_queue_default_conf_get() can also take NULL for default > > > > configuration. So I think, It makes sense to go with negation approach > > > > like ethdev to define the default to avoid confusion on the default. So > > > > I am thinking like below now, > > > > > > > > ➜ [master][libeventdev] $ git diff > > > > diff --git a/rte_eventdev.h b/rte_eventdev.h > > > > index cf22b0e..cac4642 100644 > > > > --- a/rte_eventdev.h > > > > +++ b/rte_eventdev.h > > > > @@ -429,6 +429,12 @@ rte_event_dev_configure(uint8_t dev_id, struct > > > > rte_event_dev_config *config); > > > > * > > > > * \see rte_event_port_setup(), rte_event_port_link() > > > > */ > > > > +#define RTE_EVENT_QUEUE_CFG_NOATOMIC_TYPE (1ULL << 1) > > > > +/**< Skip configuring atomic schedule type resources */ > > > > +#define RTE_EVENT_QUEUE_CFG_NOORDERED_TYPE (1ULL << 2) > > > > +/**< Skip configuring ordered schedule type resources */ > > > > +#define RTE_EVENT_QUEUE_CFG_NOPARALLEL_TYPE (1ULL << 3) > > > > +/**< Skip configuring parallel schedule type resources */ > > > > > > > > /** Event queue configuration structure */ > > > > struct rte_event_queue_conf { > > > > > > > > Thoughts? > > > > > > > > > > I'm ok with the default as being all types, in the case where NULL is > > > specified for the parameter. It does make the most sense. > > > > Yes. That case I need to explicitly mention in the documentation about what > > is default case. With RTE_EVENT_QUEUE_CFG_NOATOMIC_TYPE scheme it quite > > understood what is default. Not adding up? :-) > > > > Would below not work? DEFAULT explicitly stated, and can be commented to > say all types allowed. All I was trying to avoid explicitly stating the default state. Not worth to have back and forth on slow path configuration, I will keep it as positive logic as you suggested :-) and inspired from PKT_TX_L4_MASK #define RTE_EVENT_QUEUE_CFG_TYPE_MASK (3ULL << 0) #define RTE_EVENT_QUEUE_CFG_ALL_TYPES (0ULL << 0) /**< Enable all types */ #define RTE_EVENT_QUEUE_CFG_ATOMIC_ONLY (1ULL << 0) #define RTE_EVENT_QUEUE_CFG_ORDERED_ONLY (2ULL << 0) #define RTE_EVENT_QUEUE_CFG_PARALLEL_ONLY (3ULL << 0) #define RTE_EVENT_QUEUE_CFG_SINGLE_CONSUMER (1ULL << 2) > > #define RTE_EVENT_QUEUE_CFG_DEFAULT 0 > #define RTE_EVENT_QUEUE_CFG_ALL_TYPES RTE_EVENT_QUEUE_CFG_DEFAULT > #define RTE_EVENT_QUEUE_CFG_ATOMIC_ONLY (1<<0) > #define RTE_EVENT_QUEUE_CFG_ORDERED_ONLY (1<<1) > .... > > /Bruce