* [dpdk-dev] [PATCH 1/2] arch/arm: fix file descriptors leakage when getting CPU features
@ 2016-11-04 6:29 Jianbo Liu
2016-11-04 6:29 ` [dpdk-dev] [PATCH 2/2] arch/ppc: " Jianbo Liu
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Jianbo Liu @ 2016-11-04 6:29 UTC (permalink / raw)
To: dev, chaozhu, viktorin; +Cc: Jianbo Liu
Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
---
lib/librte_eal/common/arch/arm/rte_cpuflags.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/arch/arm/rte_cpuflags.c b/lib/librte_eal/common/arch/arm/rte_cpuflags.c
index 23240ef..79160a6 100644
--- a/lib/librte_eal/common/arch/arm/rte_cpuflags.c
+++ b/lib/librte_eal/common/arch/arm/rte_cpuflags.c
@@ -148,6 +148,7 @@ rte_cpu_get_features(hwcap_registers_t out)
out[REG_PLATFORM] = 0x0001;
}
}
+ close(auxv_fd);
}
/*
--
2.4.11
^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH 2/2] arch/ppc: fix file descriptors leakage when getting CPU features
2016-11-04 6:29 [dpdk-dev] [PATCH 1/2] arch/arm: fix file descriptors leakage when getting CPU features Jianbo Liu
@ 2016-11-04 6:29 ` Jianbo Liu
2016-11-04 7:26 ` viktorin
2016-11-04 7:24 ` [dpdk-dev] [PATCH 1/2] arch/arm: " viktorin
2016-11-04 9:46 ` [dpdk-dev] [PATCH v2 1/2] arch/arm: fix file descriptor " Jianbo Liu
2 siblings, 1 reply; 10+ messages in thread
From: Jianbo Liu @ 2016-11-04 6:29 UTC (permalink / raw)
To: dev, chaozhu, viktorin; +Cc: Jianbo Liu
Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
---
lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c b/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c
index a8147c8..fcf96e0 100644
--- a/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c
+++ b/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c
@@ -116,6 +116,7 @@ rte_cpu_get_features(hwcap_registers_t out)
else if (auxv.a_type == AT_HWCAP2)
out[REG_HWCAP2] = auxv.a_un.a_val;
}
+ close(auxv_fd);
}
/*
--
2.4.11
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] arch/arm: fix file descriptors leakage when getting CPU features
2016-11-04 6:29 [dpdk-dev] [PATCH 1/2] arch/arm: fix file descriptors leakage when getting CPU features Jianbo Liu
2016-11-04 6:29 ` [dpdk-dev] [PATCH 2/2] arch/ppc: " Jianbo Liu
@ 2016-11-04 7:24 ` viktorin
2016-11-04 9:20 ` Jianbo Liu
2016-11-04 9:46 ` [dpdk-dev] [PATCH v2 1/2] arch/arm: fix file descriptor " Jianbo Liu
2 siblings, 1 reply; 10+ messages in thread
From: viktorin @ 2016-11-04 7:24 UTC (permalink / raw)
To: Jianbo Liu; +Cc: dev, chaozhu
Hello Jianbo Liu,
thank you, a good catch!
Can you please git blame for the commit introducing the issue and add
the "Fixes:" tag as described in [1]?
Same for ppc.
Regards
Jan
[1] http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body
On Fri, 4 Nov 2016 11:59:08 +0530
Jianbo Liu <jianbo.liu@linaro.org> wrote:
> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
Acked-by: Jan Viktorin <viktorin@rehivetech.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH 2/2] arch/ppc: fix file descriptors leakage when getting CPU features
2016-11-04 6:29 ` [dpdk-dev] [PATCH 2/2] arch/ppc: " Jianbo Liu
@ 2016-11-04 7:26 ` viktorin
0 siblings, 0 replies; 10+ messages in thread
From: viktorin @ 2016-11-04 7:26 UTC (permalink / raw)
To: Jianbo Liu; +Cc: dev, chaozhu
Please, add the Fixes tag.
On Fri, 4 Nov 2016 11:59:09 +0530
Jianbo Liu <jianbo.liu@linaro.org> wrote:
> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
Acked-by: Jan Viktorin <viktorin@rehivetech.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] arch/arm: fix file descriptors leakage when getting CPU features
2016-11-04 7:24 ` [dpdk-dev] [PATCH 1/2] arch/arm: " viktorin
@ 2016-11-04 9:20 ` Jianbo Liu
0 siblings, 0 replies; 10+ messages in thread
From: Jianbo Liu @ 2016-11-04 9:20 UTC (permalink / raw)
To: Jan Viktorin; +Cc: dev, chaozhu
Hi Jan,
On 4 November 2016 at 15:24, <viktorin@rehivetech.com> wrote:
> Hello Jianbo Liu,
>
> thank you, a good catch!
>
> Can you please git blame for the commit introducing the issue and add
> the "Fixes:" tag as described in [1]?
>
> Same for ppc.
>
I will send v2 soon.
Thanks!
> Regards
> Jan
>
> [1] http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body
>
> On Fri, 4 Nov 2016 11:59:08 +0530
> Jianbo Liu <jianbo.liu@linaro.org> wrote:
>
>> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
>
> Acked-by: Jan Viktorin <viktorin@rehivetech.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH v2 1/2] arch/arm: fix file descriptor leakage when getting CPU features
2016-11-04 6:29 [dpdk-dev] [PATCH 1/2] arch/arm: fix file descriptors leakage when getting CPU features Jianbo Liu
2016-11-04 6:29 ` [dpdk-dev] [PATCH 2/2] arch/ppc: " Jianbo Liu
2016-11-04 7:24 ` [dpdk-dev] [PATCH 1/2] arch/arm: " viktorin
@ 2016-11-04 9:46 ` Jianbo Liu
2016-11-04 9:46 ` [dpdk-dev] [PATCH v2 2/2] arch/ppc: " Jianbo Liu
2016-11-04 11:19 ` [dpdk-dev] [PATCH v2 1/2] arch/arm: " Jan Viktorin
2 siblings, 2 replies; 10+ messages in thread
From: Jianbo Liu @ 2016-11-04 9:46 UTC (permalink / raw)
To: dev, chaozhu, viktorin; +Cc: Jianbo Liu
close the file descriptor after finish using it.
Fixes: b94e5c94 (eal/arm: add CPU flags for ARMv7)
Fixes: 97523f82 (eal/arm: add CPU flags for ARMv8)
Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
---
lib/librte_eal/common/arch/arm/rte_cpuflags.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/arch/arm/rte_cpuflags.c b/lib/librte_eal/common/arch/arm/rte_cpuflags.c
index 23240ef..79160a6 100644
--- a/lib/librte_eal/common/arch/arm/rte_cpuflags.c
+++ b/lib/librte_eal/common/arch/arm/rte_cpuflags.c
@@ -148,6 +148,7 @@ rte_cpu_get_features(hwcap_registers_t out)
out[REG_PLATFORM] = 0x0001;
}
}
+ close(auxv_fd);
}
/*
--
2.4.11
^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH v2 2/2] arch/ppc: fix file descriptor leakage when getting CPU features
2016-11-04 9:46 ` [dpdk-dev] [PATCH v2 1/2] arch/arm: fix file descriptor " Jianbo Liu
@ 2016-11-04 9:46 ` Jianbo Liu
2016-11-04 11:18 ` Jan Viktorin
2016-11-04 11:19 ` [dpdk-dev] [PATCH v2 1/2] arch/arm: " Jan Viktorin
1 sibling, 1 reply; 10+ messages in thread
From: Jianbo Liu @ 2016-11-04 9:46 UTC (permalink / raw)
To: dev, chaozhu, viktorin; +Cc: Jianbo Liu
close the file descriptor after finish using it.
Fixes: 9ae15538 (eal/ppc: cpu flag checks for IBM Power)
Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
---
lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c b/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c
index a8147c8..fcf96e0 100644
--- a/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c
+++ b/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c
@@ -116,6 +116,7 @@ rte_cpu_get_features(hwcap_registers_t out)
else if (auxv.a_type == AT_HWCAP2)
out[REG_HWCAP2] = auxv.a_un.a_val;
}
+ close(auxv_fd);
}
/*
--
2.4.11
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v2 2/2] arch/ppc: fix file descriptor leakage when getting CPU features
2016-11-04 9:46 ` [dpdk-dev] [PATCH v2 2/2] arch/ppc: " Jianbo Liu
@ 2016-11-04 11:18 ` Jan Viktorin
2016-11-06 21:44 ` Thomas Monjalon
0 siblings, 1 reply; 10+ messages in thread
From: Jan Viktorin @ 2016-11-04 11:18 UTC (permalink / raw)
To: Jianbo Liu; +Cc: dev, chaozhu
On Fri, 4 Nov 2016 15:16:43 +0530
Jianbo Liu <jianbo.liu@linaro.org> wrote:
> close the file descriptor after finish using it.
s/close/Close/
Please include my ack (below).
Jan
>
> Fixes: 9ae15538 (eal/ppc: cpu flag checks for IBM Power)
>
> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
Acked-by: Jan Viktorin <viktorin@rehivetech.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/2] arch/arm: fix file descriptor leakage when getting CPU features
2016-11-04 9:46 ` [dpdk-dev] [PATCH v2 1/2] arch/arm: fix file descriptor " Jianbo Liu
2016-11-04 9:46 ` [dpdk-dev] [PATCH v2 2/2] arch/ppc: " Jianbo Liu
@ 2016-11-04 11:19 ` Jan Viktorin
1 sibling, 0 replies; 10+ messages in thread
From: Jan Viktorin @ 2016-11-04 11:19 UTC (permalink / raw)
To: Jianbo Liu; +Cc: dev, chaozhu
On Fri, 4 Nov 2016 15:16:42 +0530
Jianbo Liu <jianbo.liu@linaro.org> wrote:
> close the file descriptor after finish using it.
s/close/Close/
>
> Fixes: b94e5c94 (eal/arm: add CPU flags for ARMv7)
> Fixes: 97523f82 (eal/arm: add CPU flags for ARMv8)
>
> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
Acked-by: Jan Viktorin <viktorin@rehivetech.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v2 2/2] arch/ppc: fix file descriptor leakage when getting CPU features
2016-11-04 11:18 ` Jan Viktorin
@ 2016-11-06 21:44 ` Thomas Monjalon
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Monjalon @ 2016-11-06 21:44 UTC (permalink / raw)
To: Jianbo Liu; +Cc: dev, Jan Viktorin, chaozhu
2016-11-04 12:18, Jan Viktorin:
> On Fri, 4 Nov 2016 15:16:43 +0530
> Jianbo Liu <jianbo.liu@linaro.org> wrote:
>
> > close the file descriptor after finish using it.
>
> s/close/Close/
>
> Please include my ack (below).
>
> Jan
>
> >
> > Fixes: 9ae15538 (eal/ppc: cpu flag checks for IBM Power)
> >
> > Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
>
> Acked-by: Jan Viktorin <viktorin@rehivetech.com>
Applied, thanks
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-11-06 21:44 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-04 6:29 [dpdk-dev] [PATCH 1/2] arch/arm: fix file descriptors leakage when getting CPU features Jianbo Liu
2016-11-04 6:29 ` [dpdk-dev] [PATCH 2/2] arch/ppc: " Jianbo Liu
2016-11-04 7:26 ` viktorin
2016-11-04 7:24 ` [dpdk-dev] [PATCH 1/2] arch/arm: " viktorin
2016-11-04 9:20 ` Jianbo Liu
2016-11-04 9:46 ` [dpdk-dev] [PATCH v2 1/2] arch/arm: fix file descriptor " Jianbo Liu
2016-11-04 9:46 ` [dpdk-dev] [PATCH v2 2/2] arch/ppc: " Jianbo Liu
2016-11-04 11:18 ` Jan Viktorin
2016-11-06 21:44 ` Thomas Monjalon
2016-11-04 11:19 ` [dpdk-dev] [PATCH v2 1/2] arch/arm: " Jan Viktorin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).