From: Jean Tourrilhes <jt@labs.hpe.com>
To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>,
David Marchand <david.marchand@6wind.com>,
Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] mempool: Add sanity check when secondary link in less mempools than primary
Date: Fri, 18 Nov 2016 08:39:34 -0800 [thread overview]
Message-ID: <20161118163934.GA7779@labs.hpe.com> (raw)
In-Reply-To: <e451c41b-6773-975e-9145-2f386237ab49@6wind.com>
On Fri, Nov 18, 2016 at 04:11:12PM +0100, Olivier Matz wrote:
> Hi Jean,
>
>
> Do you mind if we put back this conversation on the ML?
Oh, I forgot to do it ? I intended to. Bummer. Please do so.
> I think your example shows that there is no linker magic: you just
> need the same linker flags for dpdk libraries than in the dpdk
> framework. I suppose we need something in the build framework
> to provide these flags externally,
Good luck integrating that in all foreign build system (I'm
looking at you, Snort).
> but I don't think we need to patch mempool for that.
This sanity check is just that, a sanity check. I don't
understand what's bad about a sanity check, it does not change
functionality, it does not fix anything and just warn users about
those issues.
Please look at the patch itself at face value.
> Regards,
> Olivier
Regards,
Jean
prev parent reply other threads:[~2016-11-18 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 18:37 Jean Tourrilhes
2016-11-08 13:59 ` Olivier Matz
[not found] ` <20161110223241.GA18422@labs.hpe.com>
[not found] ` <f3c4a810-1de1-6165-5c5b-25eca42c11bd@6wind.com>
[not found] ` <20161115232722.GA18961@labs.hpe.com>
[not found] ` <e451c41b-6773-975e-9145-2f386237ab49@6wind.com>
2016-11-18 16:39 ` Jean Tourrilhes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118163934.GA7779@labs.hpe.com \
--to=jt@labs.hpe.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=jean.tourrilhes@hpe.com \
--cc=olivier.matz@6wind.com \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).