From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nelio.laranjeiro@6wind.com>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id B34E82BAC
 for <dev@dpdk.org>; Mon, 21 Nov 2016 10:23:22 +0100 (CET)
Received: by mail-wm0-f49.google.com with SMTP id g23so135090014wme.1
 for <dev@dpdk.org>; Mon, 21 Nov 2016 01:23:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-disposition:content-transfer-encoding:in-reply-to
 :user-agent; bh=MP2/DNyIYJ0hF1L/BKSI+N4G6UOMhIMAQJidVXeF41I=;
 b=pm1jHL9asjwC1BWCvmsaGKN9feTPLNVTdNof0dcmCB/u/Z6LGJFySsPFlGxSJF3/JE
 gDwvK9DC8CBK0V5aeH3XYraYDR1orAVM2PJ72VX1uvSpTfSxK+NugQ6IJlBaBecN+CNv
 zSH3PoqMam/+ycyKzQ73a1D/IhHtsb9dpMLfM40MAbtghWFmm7JVGJWBXSbtTbDrRz7C
 tTzRcB/o7QeJSy0Q7l6rB8dQFDm/eQDOpvec6CW0yi7ae9fBFICP32jXeQkKVLLwCQOH
 RO6cRprM9CCPMc+ii27vPBcbWPoKNk7tZBq0zR1NpmDgPVMlCzSvjGORB/0Xle5JfFOf
 BsSg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:references
 :mime-version:content-disposition:content-transfer-encoding
 :in-reply-to:user-agent;
 bh=MP2/DNyIYJ0hF1L/BKSI+N4G6UOMhIMAQJidVXeF41I=;
 b=l/M9n105VGbMjUwOdFn1o5zsP5alnh+WncfyojLe0dX4nGya2ycNC81TNBwBREECg3
 m3oQk6zZ1lbBeg2rglL3ymqEOO/OxTtUwTyOLuC0XnJKTAifW2xh4hLaT13up12QB6yt
 p05UsO8+/Z4noTuiBjIVh1+fIhfJHVH0UAP6eAbnGBUW8xfChw/VbzLkufwYkGWh3EY6
 rnP5bw4zN9hG3JkNng58XzlJS5s++k8M3J4Kvy4JWenzjNrQudieyw7N03Tsw3pZuCHJ
 ugBlCY+eEHMjWCRavQruIwP0g3Wyxy6zz1JTvoRRaLMEC1stMT2kYGuWg94QI6iqhEoK
 CYoA==
X-Gm-Message-State: AKaTC01/Q9n7H1sEId2plOiGk5ifAqMa/5wGRoTztAetx3IXpBBNGqwqu1sN5F32GYq1wKe/
X-Received: by 10.28.60.5 with SMTP id j5mr14183904wma.119.1479720202459;
 Mon, 21 Nov 2016 01:23:22 -0800 (PST)
Received: from autoinstall.dev.6wind.com
 (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177])
 by smtp.gmail.com with ESMTPSA id m9sm18336002wma.0.2016.11.21.01.23.21
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 21 Nov 2016 01:23:21 -0800 (PST)
Date: Mon, 21 Nov 2016 10:23:12 +0100
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas.monjalon@6wind.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 Olivier Matz <olivier.matz@6wind.com>
Message-ID: <20161121092312.GO11613@autoinstall.dev.6wind.com>
References: <cover.1471632644.git.adrien.mazarguil@6wind.com>
 <cover.1479309719.git.adrien.mazarguil@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cover.1479309719.git.adrien.mazarguil@6wind.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH 00/22] Generic flow API (rte_flow)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Nov 2016 09:23:22 -0000

Hi,

I found some small issues:

 - In rte_flow_error_set(), *cause argument should be const to avoid a
   compilation error when we implement it.

 - In port_flow_create(), the flow is not stored in the pf structure
   which ends by providing a null pointer to port_flow_destroy()
   function.

Regards,

-- 
Nélio Laranjeiro
6WIND