From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f182.google.com (mail-wj0-f182.google.com [209.85.210.182]) by dpdk.org (Postfix) with ESMTP id 25370201 for ; Mon, 28 Nov 2016 14:25:21 +0100 (CET) Received: by mail-wj0-f182.google.com with SMTP id qp4so115879637wjc.3 for ; Mon, 28 Nov 2016 05:25:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MQNIQSNCOuw1y+3yTle9Kuxg/SQc1wzfbJZjMoT+BzQ=; b=LcEpHj+4JokEp29lfzJ5g4b3GOzNjjrBkI515a3+Ql9asHyJrcSEhIWg6DIZeNh1FC ABGqcPz104sVBIqxPXdUy+7dxf3b1LlkwkXFXAkP8l9hLFMrvzyz1SZ19jcrIgpngnAM QnOIzMqU2JkdiU3w0aWRC3y/Xgjb/v+P12FUdNdWxG2A6CXIuQXWW2z73fphQGb0fZBV 1N91akq02xdmFqBCpiSf5nzb4danIZGOyH2pi5Ra8OfoPszClhvZw2MgBoRM5UD2PEAa eZikAq8Z1IP+f1FUFibcCYnj4sgd4RKKBxkNyhmz7q4qBbgFR3oDDPMTscy1U3n4bkMY vUYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MQNIQSNCOuw1y+3yTle9Kuxg/SQc1wzfbJZjMoT+BzQ=; b=Xadvy+rwayz98jrTBtswkRPvr4Tl5jVtj0UJSjuDNJfnEBJn/zWxaeABno+NdkBgH2 GCrAdqHVav6F2RSQyhcyE8QFqahdd0mmN75TBdQaXH3A9+wlDmSFfaw5T1+6wnrAndTi YZtPI88g85pBss5LXq+zRoRtS1pHN6pHZ/Az0Ht7BMWsAfHUH0XSJUeQOxzU7iNNrA0S jiquZ5uwp2+u8DmG4ksOrhRVrI28ihEJBeEyhI/yQZDsPSJ2SC/+qqt5kCDHFimF+n42 S0EtMgqaltQMYXjqcfJjVoAwkRCgJNXwg+m9JNb0EnVCAv07G4dB5Xy8HZXg3TKp+ri7 iU6g== X-Gm-Message-State: AKaTC02WI+w92Qf2LgsU1V5hh0fKD4FNTqwjGX4dxFPPUGSSceL2vfei3sBiuzSUMdaFCfkV X-Received: by 10.194.191.201 with SMTP id ha9mr18811651wjc.205.1480339520821; Mon, 28 Nov 2016 05:25:20 -0800 (PST) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id k11sm28840910wmb.18.2016.11.28.05.25.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Nov 2016 05:25:20 -0800 (PST) Date: Mon, 28 Nov 2016 14:25:18 +0100 From: Olivier Matz To: Wei Zhao Cc: dev@dpdk.org Message-ID: <20161128142518.6ed7b6e0@platinum> In-Reply-To: <20161128094212.135ce16c@platinum> References: <1480214627-27666-1-git-send-email-wei.zhao1@intel.com> <20161128094212.135ce16c@platinum> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] mempool: remove a redundant word "for" in comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Nov 2016 13:25:22 -0000 Hi Wei, On Mon, 28 Nov 2016 09:42:12 +0100 Olivier Matz wrote: > Hi Wenzhuo, First, sorry for the mistake in your name my previous mail. Please find below some other comments about the patch (on the form). > On Sun, 27 Nov 2016 10:43:47 +0800 > Wei Zhao wrote: > > > From: zhao wei > > > > There is a redundant repetition word "for" in commnet line of the commnet -> comment > > file rte_mempool.h after the definition of RTE_MEMPOOL_OPS_NAMESIZE. > > The word "for"appear twice in line 359 and 360.One of them is Missing space after '"for"' and after '360.' > > redundant, so delete it. > > > > Fixes: 449c49b93a6b (" mempool: support handler operations") We should have an empty line after the 'Fixes:' tag. The check-git-log.sh can help you to notice these errors. Also, it is important that no spaces are added in the title of the commit. You can get the exact line with: git log -1 --abbrev=12 --format='Fixes: %h (\"%s\")' > > Signed-off-by: zhao wei The name in your .gitconfig should be the same than in you mail: Wei Zhao > > Acked-by: John McNamara > > Acked-by: Olivier Matz > Please, could you also check the same comments in the other patch? Last thing: when doing another version of the patch, you should add a changelog that describes what was modified. They take place after the 3 dashes. Thank you for contributing. Regards, Olivier