[dpdk-dev] [PATCH v2] mempool: remove a redundant word "for" in comment

[dpdk-dev] [PATCH v2] mempool: remove a redundant word "for" in comment

[Wei Zhao]

From: zhao wei <wei.zhao1@intel.com>

There is a redundant repetition word "for" in commnet line of the
file rte_mempool.h after the definition of RTE_MEMPOOL_OPS_NAMESIZE.
The word "for"appear twice in line 359 and 360.One of them is
redundant, so delete it.

Fixes: 449c49b93a6b (" mempool: support handler operations")
Signed-off-by: zhao wei <wei.zhao1@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
---
 lib/librte_mempool/rte_mempool.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
index 440f3b1..911102b 100644
--- a/lib/librte_mempool/rte_mempool.h
+++ b/lib/librte_mempool/rte_mempool.h
@@ -357,7 +357,7 @@ void rte_mempool_check_cookies(const struct rte_mempool *mp,
  * Prototype for implementation specific data provisioning function.
  *
  * The function should provide the implementation specific memory for
- * for use by the other mempool ops functions in a given mempool ops struct.
+ * use by the other mempool ops functions in a given mempool ops struct.
  * E.g. the default ops provides an instance of the rte_ring for this purpose.
  * it will most likely point to a different type of data structure, and
  * will be transparent to the application programmer.
-- 
2.5.5

Re: [dpdk-dev] [PATCH v2] mempool: remove a redundant word "for" in comment

[Olivier Matz]

Hi Wenzhuo,

On Sun, 27 Nov 2016 10:43:47 +0800
Wei Zhao <wei.zhao1@intel.com> wrote:

> From: zhao wei <wei.zhao1@intel.com>
> 
> There is a redundant repetition word "for" in commnet line of the
> file rte_mempool.h after the definition of RTE_MEMPOOL_OPS_NAMESIZE.
> The word "for"appear twice in line 359 and 360.One of them is
> redundant, so delete it.
> 
> Fixes: 449c49b93a6b (" mempool: support handler operations")
> Signed-off-by: zhao wei <wei.zhao1@intel.com>
> Acked-by: John McNamara <john.mcnamara@intel.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Re: [dpdk-dev] [PATCH v2] mempool: remove a redundant word "for" in comment

[Olivier Matz]

Hi Wei,

On Mon, 28 Nov 2016 09:42:12 +0100
Olivier Matz <olivier.matz@6wind.com> wrote:
> Hi Wenzhuo,

First, sorry for the mistake in your name my previous mail.

Please find below some other comments about the patch (on the form).

> On Sun, 27 Nov 2016 10:43:47 +0800
> Wei Zhao <wei.zhao1@intel.com> wrote:
> 
> > From: zhao wei <wei.zhao1@intel.com>
> > 
> > There is a redundant repetition word "for" in commnet line of the

commnet -> comment

> > file rte_mempool.h after the definition of RTE_MEMPOOL_OPS_NAMESIZE.
> > The word "for"appear twice in line 359 and 360.One of them is

Missing space after '"for"' and after '360.'


> > redundant, so delete it.
> > 
> > Fixes: 449c49b93a6b (" mempool: support handler operations")

We should have an empty line after the 'Fixes:' tag. The
check-git-log.sh can help you to notice these errors.

Also, it is important that no spaces are added in the title of the
commit. You can get the exact line with:
  git log -1 --abbrev=12 --format='Fixes: %h (\"%s\")' <commitid>

> > Signed-off-by: zhao wei <wei.zhao1@intel.com>

The name in your .gitconfig should be the same than in you mail:
Wei Zhao <wei.zhao1@intel.com>

> > Acked-by: John McNamara <john.mcnamara@intel.com>  
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> 

Please, could you also check the same comments in the other patch?

Last thing: when doing another version of the patch, you should add a
changelog that describes what was modified. They take place after the 3
dashes.

Thank you for contributing.

Regards,
Olivier

Re: [dpdk-dev] [PATCH v2] mempool: remove a redundant word "for" in comment

[Zhao1, Wei]

Hi, olivier

> -----Original Message-----
> From: Olivier Matz [mailto:olivier.matz@6wind.com]
> Sent: Monday, November 28, 2016 9:25 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v2] mempool: remove a redundant word "for" in
> comment
> 
> Hi Wei,
> 
> On Mon, 28 Nov 2016 09:42:12 +0100
> Olivier Matz <olivier.matz@6wind.com> wrote:
> > Hi Wenzhuo,
> 
> First, sorry for the mistake in your name my previous mail.
> 
> Please find below some other comments about the patch (on the form).
> 
> > On Sun, 27 Nov 2016 10:43:47 +0800
> > Wei Zhao <wei.zhao1@intel.com> wrote:
> >
> > > From: zhao wei <wei.zhao1@intel.com>
> > >
> > > There is a redundant repetition word "for" in commnet line of the
> 
> commnet -> comment
> 
> > > file rte_mempool.h after the definition of
> RTE_MEMPOOL_OPS_NAMESIZE.
> > > The word "for"appear twice in line 359 and 360.One of them is
> 
> Missing space after '"for"' and after '360.'
> 
> 
> > > redundant, so delete it.
> > >
> > > Fixes: 449c49b93a6b (" mempool: support handler operations")
> 
> We should have an empty line after the 'Fixes:' tag. The check-git-log.sh can
> help you to notice these errors.
> 
> Also, it is important that no spaces are added in the title of the commit. You
> can get the exact line with:
>   git log -1 --abbrev=12 --format='Fixes: %h (\"%s\")' <commitid>
> 
> > > Signed-off-by: zhao wei <wei.zhao1@intel.com>
> 
> The name in your .gitconfig should be the same than in you mail:
> Wei Zhao <wei.zhao1@intel.com>
> 
> > > Acked-by: John McNamara <john.mcnamara@intel.com>
> >
> > Acked-by: Olivier Matz <olivier.matz@6wind.com>
> >
> 
> Please, could you also check the same comments in the other patch?
> 
> Last thing: when doing another version of the patch, you should add a
> changelog that describes what was modified. They take place after the 3
> dashes.
> 
> Thank you for contributing.
> 
> Regards,
> Olivier

Thank you for your nicely guide to me,  I have found that I miss using check patch tool  last time.