From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f176.google.com (mail-wj0-f176.google.com [209.85.210.176]) by dpdk.org (Postfix) with ESMTP id CAB7F2BAF for ; Tue, 6 Dec 2016 11:45:01 +0100 (CET) Received: by mail-wj0-f176.google.com with SMTP id v7so315193142wjy.2 for ; Tue, 06 Dec 2016 02:45:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uS58rowrjXJ8NNaLw/UaI0P5NJO+j2V6CnAQxl3Q9Dw=; b=GPcIjAOKVG+AnNkfAHq3VrDFQk4zGPagY+rGm6KNlG/hubCmMRR/UgyUE6oNnjPEqr 8tFUYpnZpicfp8gUKjQ1g+ISokRyWP6zkdisB/gRpOA3312aTtLX3yyayRdTVWsoE1yC /PMn91yW6KIo5a8SFd6rcUExjONxbnPq8J5SGfQYDRL478zZBdeu4at4iJ8B28h5NE9L jSSMS/WeYnjZ7hliJcR7lkU9ooFpXYs85xSbkwnH0kdAF2qllElxo2hjjiFU3ZsPJgNn zLS44WhPA8VPrZ8TE6TLxAoFowi9u9rmK2ClRN7Nah7LILN4ilVmT5xKRvI0YBIgokfV nMgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uS58rowrjXJ8NNaLw/UaI0P5NJO+j2V6CnAQxl3Q9Dw=; b=QDHa4/lxI73ojQYjcNhAH8LBvbEO2ssC9dUfO2KncOMPuZopAADLeDeaEDq3zXrswT BnWE1lOIbtvkuBOlOuS59EX0anMOUfo9tNThFIGYGoVIFE0NX2YJKUYvz1G/yJfZlJ8E M04bbSm9EEHsTqzp1vPbu4BNq08X9GU4YskR9DHsl03RtAuZZDjDV03+YxKmDE2Dmqrp NdQf+YHZ1szzcFedVcS3ztP51VFO1+KH+ceV0lGujUpKuK+8h/kkKMYuYZi63QEVwDXp M60fagVvt3LJQXkaQ+HKMox0jPwMA4L4etL1+2RUUZ735xxmA3MDuHV2FDrnThcjLHtT KPSw== X-Gm-Message-State: AKaTC031Q/aS0M0lsSrO8SdkoIxqm2OpWr/4MmEn+/xsKr7raOj49DqYLg3WtB/gFlfAF1U5 X-Received: by 10.194.10.165 with SMTP id j5mr53024902wjb.119.1481021101467; Tue, 06 Dec 2016 02:45:01 -0800 (PST) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id i15sm25098245wjs.16.2016.12.06.02.45.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Dec 2016 02:45:01 -0800 (PST) Date: Tue, 6 Dec 2016 11:44:59 +0100 From: Olivier Matz To: Wei Dai Cc: david.marchand@6wind.com, dev@dpdk.org Message-ID: <20161206114459.0a05cbe0@platinum> In-Reply-To: <1479365235-134903-1-git-send-email-wei.dai@intel.com> References: <1479264047-67966-1-git-send-email-wei.dai@intel.com> <1479365235-134903-1-git-send-email-wei.dai@intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] eal/linuxapp: fix return value check of mknod() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Dec 2016 10:45:02 -0000 Hi Wei, On Thu, 17 Nov 2016 14:47:15 +0800, Wei Dai wrote: > In function pci_mknod_uio_dev() in lib/librte_eal/eal/eal_pci_uio.c, > The return value of mknod() is ret, not f got by fopen(). > So the value of ret should be checked for mknod(). > > Fixes: f7f97c16048e ("pci: add option --create-uio-dev to run without > hotplug") > > Signed-off-by: Wei Dai Acked-by: Olivier Matz Thanks