From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <Jerin.Jacob@cavium.com>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
(mail-dm3nam03on0059.outbound.protection.outlook.com [104.47.41.59])
by dpdk.org (Postfix) with ESMTP id A9CE82B8E
for <dev@dpdk.org>; Wed, 7 Dec 2016 18:03:46 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=KShyygx15qE9tzuUi1I1RA5hnbk6/MgXrtHatddv5B8=;
b=lC2Ick/xh9ue2d/k+rtoUkeznTpLp3WJ7xFt713e59D1owkSqvOZkz7xM9sciO0nr5klR8ShwUeepEqpAJFiUOYTsWPETmz+0HI3GUM8DLsPSnh+TGsPL6DDq75oaB7xcIMF93pAPkDYG8K0ZlOTgMpH5y61JoQa4AlRfJP0YkM=
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=Jerin.Jacob@cavium.com;
Received: from svelivela-lt.caveonetworks.com (50.233.148.156) by
BN3PR0701MB1719.namprd07.prod.outlook.com (10.163.39.18) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id
15.1.693.12; Wed, 7 Dec 2016 17:03:01 +0000
Date: Wed, 7 Dec 2016 22:32:56 +0530
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Bruce Richardson <bruce.richardson@intel.com>
CC: <dev@dpdk.org>, <thomas.monjalon@6wind.com>, <hemant.agrawal@nxp.com>,
<gage.eads@intel.com>, <harry.van.haaren@intel.com>
Message-ID: <20161207170256.GA4930@svelivela-lt.caveonetworks.com>
References: <1479447902-3700-2-git-send-email-jerin.jacob@caviumnetworks.com>
<1480996340-29871-1-git-send-email-jerin.jacob@caviumnetworks.com>
<1480996340-29871-4-git-send-email-jerin.jacob@caviumnetworks.com>
<20161206171712.GC22224@bricha3-MOBL3.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20161206171712.GC22224@bricha3-MOBL3.ger.corp.intel.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-Originating-IP: [50.233.148.156]
X-ClientProxiedBy: DM5PR2001CA0018.namprd20.prod.outlook.com (10.172.43.28) To
BN3PR0701MB1719.namprd07.prod.outlook.com (10.163.39.18)
X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719;
2:yOGAB0lg6zgtMwnSNd8hcjwg7hwv8eLcOYnPAlh0N1q34BhMBCuP5999KNJyXMgUsUeiB0PUFjLqAu/Dy72ZBO6mehDjXRwd9iK2i7OLn2dKSnLUNwRm0dF7GLXv17D8iwYzuNzkaZWFWQP8q+9aEzR/IxSEUEtaQkn1rH4QGso=;
3:tDsqpvKzCkeocv8jCiEeNpknLEVkrLVLmvVh2WH1ZZzouQPuZaSGad51nbAnqGBCi+GKOWSaQ6eEYhV/amBz+Lhr3+qPK18l1gCj/CjaesMBdE5/PcZ2tTJi1PJcmIYmEsp2YWbMYL/0I3ZCPRRWg/gQ4+SKjtWZoHSLVUgk6NQ=
X-MS-Office365-Filtering-Correlation-Id: 52fb3f34-9785-4ba7-da23-08d41ec2e737
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001);
SRVR:BN3PR0701MB1719;
X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719;
25:Ul02gcy1CCCMpcHgJkPeOvxyO+8/aubp1O7fvucoKrHH8TvcKJJ0TWhc5W4M7Zpl/QDWKsoE//5HSC9ruC65oHxNa5/2ooVko5d48syaRJkC+Yk/iKf1G3oQpF8rifmCGKVdDXokvvz1BC8BtruYUHOr96509u0gkKrH1lqgNNW9ZeEfpgvwP4TP+2MmuN9LPRLBRLNPk1WPIONvNh+Pwgs+uNv95JEIHKKu+5R2+vU9LVqTi3m918fKc5BM/202az/JDco8HXCym2cuh8aD7RSxIQeFbT+EQ1mQYNIFnxbKGNGxXtyNemMEe/+Tr13N6n+ofZMQ/i6vlZ0ae+N8jBcjUYx5/k1h4gBOSQgndXuojujoFEGcPgVWgN5dW0ItUhtvenV/0dcmuxkHn42x2K6HFbNnFldh+Gx5t7Aic+lUf0ZHqpjROPTr+OzEAVC3LC+1iebfl+UWkD40Idm3eQq9WZSA0cMTRDW2bYsHMCHozTT9jRk/T+/C8IaEyHHl1eMroglsdCRprdgPuwBqlkzuHPl7PPvBkKlJMNivDJ+NyxxAbDLKclAVCP+qZ8jA+IO0BSsrhQUz4bCkPQUF9Q3TtfMeNRB7ln3zJDLEjzD6w7Wio6XaYRAOsK32wKtgTUYFVurUGLWVt7a2NtGXNfZ6DeuIFtNtynv0y0R3Fs5ijMFzKMdx7FrNVMYhjyvPBMlGdENRThDASf/JmfZGFM4H3TUHEo/solWtZVkNGPQbL10jDYl7CaVsGwE2Xt0kT1UsTsivN5SDUVFE2uHsVw==
X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719;
31:B8owouJZZwuf90DpdjsJaJuBi5guWoZDq0UGbMIclKj5hRopeBB9UNIUQnSOl/Vv1wTG2K4ZnBdAGVcABcJJDRH6NTkXPTS380pCIGVYOwLuiLtUv5btRkAoZKSU/WqiTYVJUvyKIIgEMdcRHscdNlLudoZcpPw+oNjumozg8ECrZskuboWwWq0oOScng0RnWqfkv/7F0slyNsmcoRK/pXEqyL5adPY7oLnLF9h4cxfalHwjB82ruqjsLgZW4oGTXb8nTgfkXETQdc5OtyNGTg==;
20:dUMzmB3bcf4qqdUO1cDOlY3llFy9doYkx9Njyk2f8ncRcDS2StOeuVXt6sgtFVulsv1ArvUrBOnPHntsbU+mRSixnKmgAtmcxaFdyXmaZuu5ZnE3+OOVzTcqs7da7XlXvO0XZ9VbAMFvMMYhxGo5299YqEFUrk5UJr1gNuWdFjF5aOveRjm4d6cqx2IPkiOeLwobf8QdTs1ZxFoCDFErtbbWffAK56XLzesCDz7LIAo7fCeLsD9WWSTqhR6p9poTuj5nEnSxabcGoYfZ0uxZcLsI8ZMini+LHetrenRQv/5CAGJQ+NytJSZqFO+IyzqLB+Zn7bCz2Se+qNLTKi78PfJKWrdavgXS9YaVsSYqNPvQu8S8zgZ7k9Hovd6SfRyjpd1yA5U/IK/VVcku1VnZnR/ANsRohUS0KZ+Cz9pthJgBwP69kzHiWM3rMUYySynmpbxkcchGTfKtGqd++cv5nqD6YnYqvh7fdPFPlU+gOJ6QX6D+5wrenCx274m7GSgYOIVQO190LkD1PVVtXxX6z73eUIUyWjMBqRO4X3mcMgCE7HK/fCpXc84F7wupscqiJhbpFzkuKzLGLrTkeDVQ2fUYtqa8DL5A7/X/CT9JUCU=
X-Microsoft-Antispam-PRVS: <BN3PR0701MB171913ABCF5AC098CD62421481850@BN3PR0701MB1719.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(6072148)(6042181);
SRVR:BN3PR0701MB1719; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0701MB1719;
X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719;
4:T+4+HbKRjC/6RqKZhEH9wke3dkMO0UcMkCOdw/Fh4v8fAnjlXVqg5QV1s2j0BbVvH9y8nFOzLGb3incMWG8jfsP3bpry+uyOA4BC2GCHQmjjkLyQVNaamRIbqXXFvlnf9nv/ZNZC/oLGit932rJcFiz/pju/QdGDHJ+cEaV8+8ftDRmc+d7nrfEwectMPkND9djZ6oYe92pNGMOJnCU6el2XGYxUNqNYJxd7W4erYmAMgsLG4ZRDnshsQdkDXk5qTJW7rTqBo5BblXhzoFbKAJUcPP6U55cCLfKSkwVS9G5QXK5crTR362iWggCNx15fk4fVwYsIJFJgxsXYAr4a5nMBMqLtYYTdKzNW+JMg9ZqnrC7PXMSbSqQs7ZUHrKJGgWZ1Gr4ZM8TMX+z5QjQj5KgoA564RYrdpuQyHpHEci/EyBTSV3z30yVnemqS9vDlt5R37yQexBm+7FTHjYqJM3E9Iol5qJRKUOwj+0evjwnBMr4JTjnnMKNsLQLrFv6C5HUGumkL7P3L1oB/of26SVT9mzv+HnB+35qs6u+2UOO+pv4kv5+9JnFU6rg46s0C/ZWzr/YCxXkZ+yyoj46wJW09VaITL4r1vmzp91EyCl4=
X-Forefront-PRVS: 01494FA7F7
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(4630300001)(6009001)(7916002)(24454002)(199003)(189002)(47776003)(2950100002)(42882006)(69596002)(66066001)(6916009)(110136003)(92566002)(1076002)(68736007)(733004)(8666005)(7846002)(6666003)(50466002)(229853002)(83506001)(97756001)(7736002)(6506006)(97736004)(4326007)(2906002)(4001350100001)(50986999)(305945005)(33656002)(38730400001)(76176999)(105586002)(106356001)(54356999)(5660300001)(8676002)(23726003)(93886004)(6116002)(3846002)(101416001)(46406003)(81156014)(81166006)(9686002)(189998001)(42186005)(53416004)(18370500001)(7059030);
DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0701MB1719;
H:svelivela-lt.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1;
LANG:en;
Received-SPF: None (protection.outlook.com: cavium.com does not designate
permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0701MB1719;
23:NFZoxwc9gMl6o9Q3sP9QV3mOun2TeamaeyFuwzS?=
=?us-ascii?Q?cFi3evQOMT03cZzHMGIotfyOcJiCAiUXyyhpGVXPBWH5wozEokY4rg22E2LV?=
=?us-ascii?Q?yT6yGISR87UV6PXIlQqHb2WMHzH31Tek0iK7dprZOeqKfqtX3xejq9jdwSDv?=
=?us-ascii?Q?fGuDhfi7d2l5GTwH1h/9TgODjqgYY1E1/Ktmei9fKsn7urEqA5NL2RWGio4o?=
=?us-ascii?Q?AEs/3DRuPGugaxaKns/zOkPFYmghAErKu1VzZDbPRcuSsJgMod0NMpdacFZE?=
=?us-ascii?Q?XkajMrg0l1hgM0p9w5wo0o9DmUw29FWHR8BLXWSYMQGGzIzgt9Ot2SzmVWVC?=
=?us-ascii?Q?RivbEZRRj7H0p5SmYz8P2gHO8K2eefs3sItFN6ou8w3sOThqFovIEMti8bn9?=
=?us-ascii?Q?h04Ui1i15xguo3xIOZVioyi88wzwGOSB9HKwPEDc9UIw5Xey8nwx0M8CEJ9y?=
=?us-ascii?Q?5005jgK264XeXpNV88qnbGf2YKfuy+0AktK2xK86xER49ICFk/V/VFPApzh4?=
=?us-ascii?Q?x4GFJ3WwVRptqqDhQbYlXxbPCmsgCOdchjBL1wdgI8rUyWNuBpCrkIP8Bbt2?=
=?us-ascii?Q?32e++hFa6obyKxQcpejo6DZfgCcX9gIXJ6gXpVmXivJs2/lZCxDU93wums0u?=
=?us-ascii?Q?KwaDYCEvu90nL/od6iRybXvh2iShKJFSZRi6FH7CTVBXFAlolEMO0zfqd4P1?=
=?us-ascii?Q?yXC5uwnyYlGjqXtvYviB8/UzCEmNHxg0Ssisyr+MyHjF2KsCc7KwlBlmAAla?=
=?us-ascii?Q?tjPFtWJcrdwbC7Wjm6d+0bS1L6+9VwZ50iM4yjubDokdWTlNTzNR+mqYDc4G?=
=?us-ascii?Q?hbiqmVte1tz2nEVzaFToyO3s9O8hZb6QfI5NxWsO2mNfX4YLkBn7U5NkIhWK?=
=?us-ascii?Q?8vGGCheOcD1kCsusGF7MDi5mtMG4iJVtwXD4CZgi8NE4riaG0/Nr/85PzVc8?=
=?us-ascii?Q?KNwuaHTrOTTP31Q3ymtxlNC9nmomjMil8xYH82YDje7Bby+UEHmJZnoJBBL1?=
=?us-ascii?Q?wO/u1XvB61ouO7AbFLgC5qhK1SDKMbKQqGNhSCb41TgpqjUgWjoWWpeiGF1w?=
=?us-ascii?Q?mKFavkPS8Ei6DEVeS83/E4uWtaTkLeFowAoxyoVjoDKq8P5jtYU2i7g1B0PR?=
=?us-ascii?Q?gSEx7X0sOOAzCuXhC2t1txDQ73yYUm3r7HB29F9KAgoJu6BdjjbkRVa3r/yl?=
=?us-ascii?Q?SkBp8xyUn76y3a2LnZK60byon0GB4DOMTN90VF4YFM908i5C7s/aRfMvRA3k?=
=?us-ascii?Q?Lm7g8/h0iSJ9Q1YN7I30A5sh7eybO4+d2MaKWbEkTctzp/uyyadHqydvWb6O?=
=?us-ascii?Q?Tk5RoJD70n4Kcp2NoDUpsVwg=3D?=
X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719;
6:zr9z1AbiO8u9/eHTuhDFodL4N7l6eT4h0pZBvcBAfNvowX2d2dUgOenslHQQCoRkmG5ZeaoVErtacF2eeIBDebSnflTPQHOHIHnhrNE76eQIBqwEykNOVSfW9rjUodkkONQ5BbPZ0Jh94u+8Ayj/WgIuRyixbKA5yqICCB+DY6sD/bWxyVBwsZoqmeg4sCa1kyru5CzE9Eqb7bC0jSwPSAAF6H9tGjCKcItRHqXlHd6yDiQHRSd+NR2aj12G2n6i28ivJiO+efTsx6HJqjXW6BctpyskVHe00yX+rGEOCxYPoyyFa+93n2TBqVGRPfgJzLToQKvbH28hi5uEmjll3wOlf2uTuSbSgTELxSZBkuM=;
5:cmbCGutL2dq49qln9kJAxCbABIHtE1KPq1NjD671cJtRVomeig+7dqHoxHExHcXBL+PWG/I4cWwkB7lad7k6NJPACuOYoUUY6dlYEq40tzMCgVfoLBJDMQvuSuqsfHKatk3yopmW1FrvS/7cQCT2kW+oWP3azmE+87MqVeN0ftQ=;
24:En4t+AkeCXRq4fQ1l6abxq/YEqZ5KgMP7Sk3ZsOZWnso9RQzF4Ur9RSGinZwiN0MtbRkN5EIW3k7nmFxsuPln5BC2hycMWluy1vW+d8TYd4=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719;
7:O1mPGMKaYw5you2olX3Wpx7avUIyAa+mHsYgaI/zuiTa08Ghxq2aogoQosYv+dSIt1LjJf0tDFQ44N8raq4/eaMLL+K0PKqi7zoentjSiN5WTm19RkAr6r/PLPJuDbV43lA9RtcQ1/gXC0reds3ZR+00KN/BNOThNVzNznIhfgJAUeZY5F32/YdPsbL+EdKaq7qYU9XT1IFnHYr4LSZofn7CqNTT5MXagQGrmh2cHCB7gqBJ0iMhD04wRRC4DHEKWzjpF4WtuqS82HU4ML2vrsuRsvbYiDkggEC11VPcwLhZDmE6cVsfNoHv4VQXLtFKSgNobnfqW61bgMjwXLB4zUCGgNRCYU9VK9MuhDkeHl8=
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2016 17:03:01.0522 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1719
Subject: Re: [dpdk-dev] [PATCH v2 3/6] eventdev: implement the northbound
APIs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Dec 2016 17:03:47 -0000
On Tue, Dec 06, 2016 at 05:17:12PM +0000, Bruce Richardson wrote:
> On Tue, Dec 06, 2016 at 09:22:17AM +0530, Jerin Jacob wrote:
> > This patch implements northbound eventdev API interface using
> > southbond driver interface
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> > + /* Re allocate memory to store queue priority */
> > + queues_prio = dev->data->queues_prio;
> > + queues_prio = rte_realloc(queues_prio,
> > + sizeof(queues_prio[0]) * nb_queues,
> > + RTE_CACHE_LINE_SIZE);
> > + if (queues_prio == NULL) {
> > + RTE_EDEV_LOG_ERR("failed to realloc queue priority,"
> > + " nb_queues %u", nb_queues);
> > + return -(ENOMEM);
> > + }
> > + dev->data->queues_prio = queues_prio;
> > +
> > + if (nb_queues > old_nb_queues) {
> > + uint8_t new_qs = nb_queues - old_nb_queues;
> > +
> > + memset(queues + old_nb_queues, 0,
> > + sizeof(queues[0]) * new_qs);
> > + memset(queues_prio + old_nb_queues, 0,
> > + sizeof(queues_prio[0]) * new_qs);
> > + }
> > + } else if (dev->data->queues != NULL && nb_queues == 0) {
> > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->queue_release, -ENOTSUP);
> > +
> > + queues = dev->data->queues;
> > + for (i = nb_queues; i < old_nb_queues; i++)
> > + (*dev->dev_ops->queue_release)(queues[i]);
> > + }
> > +
> > + dev->data->nb_queues = nb_queues;
> > + return 0;
> > +}
> > +
> While the ports array makes sense to have available at the top level of
> the API and allocated from rte_eventdev.c, I'm not seeing what the value
> of having the queues allocated at that level is. The only time the queue
> array is indexed by eventdev layer is when releasing a queue. Therefore,
> I suggest just saving the number of queues for sanity checking and let
> the queue array allocation and freeing be handled entirely in the
> drivers themselves.
I thought it would be useful for other drivers. I agree, If something is not
common across all the driver lets remove it from common code.
I will remove it in v3
>
> /Bruce