From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f171.google.com (mail-pf0-f171.google.com [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id A2C962B8E for ; Thu, 8 Dec 2016 03:27:30 +0100 (CET) Received: by mail-pf0-f171.google.com with SMTP id 189so80629448pfz.3 for ; Wed, 07 Dec 2016 18:27:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:mime-version :content-transfer-encoding; bh=fl4hujs7164PgELtjkAiEd1e2yzkZO3kus8LAt5iD7M=; b=wrqTD83XEU9c5l1/bi+nAB7MDV5wQDnLhRI74nTrKBbPpPpEzIS4e66jb1VX91npoH CAvHuGstAgDOxD4YwkP3ob4K1UvktoaN7yX6z2pc1jqz46D6ghUMxN/P2y9OjKEnW5Ff RP6NrpqULE3bWqVdQXEYORlNw/8tIQCWCkks/a4ixSpuRU7AL0I6IzfAQ6PORmAqyGWv siT2YypiJGxSqqAKzaTeAn9zp0A2DndP9HZlFn1Rq9Zk6IZ68ZjtHijCTfJJfkKSyG7u ZQvqqH4+uLoUCvlf/Ehwia4iuOhs+7jx9+D3QCVyuFfH4n/szghPatRi433vJ+UU+CiV QMYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-transfer-encoding; bh=fl4hujs7164PgELtjkAiEd1e2yzkZO3kus8LAt5iD7M=; b=Fvx5aIgiFVfrL7+XQUyhjgbebAzFfAybu8GAcVWr6rG+lKh1SeNVNomHVCBVdrq1xR ZH9+uCnQPftW+VSQzzCj+TfQEIyiabErtSzwSj9zL5Ij3XNYlWTuNky0jXrODI9rQFAT A1ZyNQhKx5VJE9R/Ho+5xxCXg5WOAJUwiDX4Pl4aeecqpMwgYcdGgpKx62Nznlp8FEzu OkwZx3bJn4szUzCaI8I+F3MXFWJL2AKhiuM3QwQMilkTKHwk0VfWN3iV5PHqoNIVl/bp 3Zgsgn+HTi/OYduhAoyX5nMrS4UmIcymiWgCzSXj9jLaqmRIOpfK9/AsbodWMdDW/2W+ TX0w== X-Gm-Message-State: AKaTC03jwESYKw0REXy0aB6aFFb5/STKKDwKJcQmFEdGqu7ONePyRiqZL/21wJ6Mzhs1IA== X-Received: by 10.84.173.195 with SMTP id p61mr153700910plb.158.1481164049609; Wed, 07 Dec 2016 18:27:29 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id p13sm45567993pgf.47.2016.12.07.18.27.29 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Dec 2016 18:27:29 -0800 (PST) Date: Wed, 7 Dec 2016 18:27:17 -0800 From: Stephen Hemminger To: dev@dpdk.org Message-ID: <20161207182717.1fdb0851@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [dpdk-dev] [RFC] ethdev: expand size of eth_dev_name in next release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Dec 2016 02:27:31 -0000 This came up while revising earlier work on Hyper-V. The current versions of DPDK does not have enough space to support a logical device name in VMBUS. The kernel exposes the VMBUS devices by GUID in a manner similar to how PCI is expressed with domain:host:function notation. In order to support Hyper-V in a direct fashion, the eth_dev name needs to be expanded. The standard format for text representation of GUID is 36 bytes (plus null). See uuid_unparse(3). The other alternative is to use base64 encoding, but this worse for humans to read, and isn't directly handled by lib uuid. --- doc/guides/rel_notes/release_17_02.rst | 4 +++- lib/librte_ether/rte_ethdev.h | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_17_02.rst b/doc/guides/rel_notes/release_17_02.rst index 3b65038..52c97c6 100644 --- a/doc/guides/rel_notes/release_17_02.rst +++ b/doc/guides/rel_notes/release_17_02.rst @@ -116,7 +116,9 @@ ABI Changes Also, make sure to start the actual text at the margin. ========================================================= - + * The macro ``RTE_ETH_NAME_MAX_LEN`` used in rte_eth_dev_data will be + increased from 32 to 40 characters to allow for longer values such + as GUID which is 36 characters long (plus null character). Shared Library Versions ----------------------- diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 9678179..68cb956 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -1652,7 +1652,11 @@ struct rte_eth_dev_sriov { }; #define RTE_ETH_DEV_SRIOV(dev) ((dev)->data->sriov) +#ifdef RTE_NEXT_ABI +#define RTE_ETH_NAME_MAX_LEN 40 +#else #define RTE_ETH_NAME_MAX_LEN (32) +#endif /** * @internal -- 2.10.2