From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 3C0602934 for ; Thu, 8 Dec 2016 15:50:28 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id t79so29106993wmt.0 for ; Thu, 08 Dec 2016 06:50:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xvnQeURHUvd66tdawmshyvlVQRQFaom9tDB9cvGjlsI=; b=WE1C7UtS6r30jAY0E4iLOL9cAfYkeil+nk+sS9jzSvdVsKX/O33Lc2A4/zyloHokw7 g8zJBuVAT+mWGPZlh14q2Gk5J0ZykW9R2C4fLUFD++XVJLZOYwRXcWQmRV6sfHFxPNws wzpzm7azsgKDWho2tCqn2N/SJXKdvz8QxIRONtVlbgrqiYOt6ZIKRawXMKBiuOsBpSyp 1AVWxjjL68zoo8IhShoaPYQ6fsXtVhcznCGSh0I7PueE4nM82s2ukmFMf/dM8fRAxFdX 4lshJO8xA5TeiSdrUKBV7mbhSgvPJlNFFUoUxgJ5mRUkYZesUyzVALkdezZdt6t30xcb +r/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xvnQeURHUvd66tdawmshyvlVQRQFaom9tDB9cvGjlsI=; b=fUNa7NBYSK4i3VKEJ9LvB31zpZ4wMuYzbHkL7IAU67xSImXyD/c3YG2CfcSeLEE3V8 t0iybRK0h5kXHAwy8wo2ZzCUzb2Av0+JNY9eyLnky7VJxMtW0+eau0V4JSWcXBXTrYGH bSJYq/8M6FOTWhC0X+n5eu3AiQdFMQVTOc46f0GHqvWTBr8w1WfHJLNVf8PgdbeLirXy 1Ij8Y2bHsNo0jK8Mh7CWpexhyLryvYACOvbws2V3daMjSes2WrOOD9u14lfIge6ZGsQE l4jv2JgnabR4BLahKfT7OUTGY39TdDIqI+0lapDeiyWpeIPPpNNlllatJi7dW7iAbUXz JoBA== X-Gm-Message-State: AKaTC019Fuebh0n+x1hhDt0St9h5NfSiSVBKSfa4scR3u10aSWhR/qSc9bwPD+LS8kcPzDBB X-Received: by 10.28.39.5 with SMTP id n5mr2507345wmn.54.1481208627972; Thu, 08 Dec 2016 06:50:27 -0800 (PST) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id c187sm15618876wmd.13.2016.12.08.06.50.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Dec 2016 06:50:27 -0800 (PST) Date: Thu, 8 Dec 2016 15:50:20 +0100 From: Adrien Mazarguil To: "Xing, Beilei" Cc: "dev@dpdk.org" , Thomas Monjalon , "De Lara Guarch, Pablo" , Olivier Matz Message-ID: <20161208145020.GI10340@6wind.com> References: <1c8a8e4fec73ed33836f1da9525b1b8b53048518.1479309720.git.adrien.mazarguil@6wind.com> <94479800C636CB44BD422CB454846E012EA36991@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <94479800C636CB44BD422CB454846E012EA36991@SHSMSX101.ccr.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Dec 2016 14:50:28 -0000 Hi Beilei, On Thu, Dec 08, 2016 at 09:00:05AM +0000, Xing, Beilei wrote: [...] > > +/** > > + * RTE_FLOW_ITEM_TYPE_ETH > > + * > > + * Matches an Ethernet header. > > + */ > > +struct rte_flow_item_eth { > > + struct ether_addr dst; /**< Destination MAC. */ > > + struct ether_addr src; /**< Source MAC. */ > > + unsigned int type; /**< EtherType. */ > Hi Adrien, > > ETHERTYPE in ether header is 2 bytes, so I think "uint16_t type" is more appropriate here, what do you think? You're right, thanks for catching this. I'll update it in v2 (soon). -- Adrien Mazarguil 6WIND