From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <Jerin.Jacob@cavium.com>
Received: from NAM03-BY2-obe.outbound.protection.outlook.com
(mail-by2nam03on0048.outbound.protection.outlook.com [104.47.42.48])
by dpdk.org (Postfix) with ESMTP id 88F062C4F
for <dev@dpdk.org>; Wed, 14 Dec 2016 07:29:05 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=tpiu8xlWZIZNxaFMDSFE+uTFHRF4xxuZsK0cE7rSUtc=;
b=c5vAA6vADLhHcVgTOhiVWE7Cd6rpxD94JCJNMkDkm4JmM19ULyQVHEmR3QY7z+9roHSa0eACxsxtEqFD2Xus9UZlmI7K0kBxfAkdga1FZ24EM7Ddnntg7Q8SUqXo6wioj9Q0u74GrhMrutzZtG5a3tk70BVIo9YFjTGqT8yRZ7k=
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=Jerin.Jacob@cavium.com;
Received: from localhost.localdomain (122.166.153.127) by
BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id
15.1.707.6; Wed, 14 Dec 2016 06:28:59 +0000
Date: Wed, 14 Dec 2016 11:58:37 +0530
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Bruce Richardson <bruce.richardson@intel.com>
CC: <dev@dpdk.org>, <thomas.monjalon@6wind.com>, <hemant.agrawal@nxp.com>,
<gage.eads@intel.com>, <harry.van.haaren@intel.com>
Message-ID: <20161214062836.GA21135@localhost.localdomain>
References: <1479447902-3700-2-git-send-email-jerin.jacob@caviumnetworks.com>
<1480996340-29871-1-git-send-email-jerin.jacob@caviumnetworks.com>
<1480996340-29871-4-git-send-email-jerin.jacob@caviumnetworks.com>
<20161206171712.GC22224@bricha3-MOBL3.ger.corp.intel.com>
<20161207170256.GA4930@svelivela-lt.caveonetworks.com>
<20161208095937.GC55440@bricha3-MOBL3.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20161208095937.GC55440@bricha3-MOBL3.ger.corp.intel.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-Originating-IP: [122.166.153.127]
X-ClientProxiedBy: MA1PR01CA0063.INDPRD01.PROD.OUTLOOK.COM (10.164.116.163) To
BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140)
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714;
2:TstVI0F/2/sWb7gKyR5YzPrkP1k5ye+yB8ccHWkSjWMMNmmJnjMPX2FgJi9RUlpSuemkt/Fz+LlYv9vHEuD+6T7VlIXBaklG63GAKqrP63zlWaUv60BTq4cbUi6ABcKwZz/P9vq9Dvv98wz/kOQfWRoWjal+7OBEGg/NO5i5eNc=;
3:rrG+PIwyKtNQ8qZeSIj3KVQ6W0f1+hdhNNzzP2lOWF9U4j5W5zq/npB1VDhn1A5QcjwcqF7WhHvg4g3w+BIeoAdIAyh1dUg6g1h5jXafNts1Bs7NWEGtlyfKFHQ6xa0enHtWXgoEjV4Ul/2yn8zitnRgT7vNo1hCvXsrTc3jtsk=;
25:3IS+o4+06jXoABnyHaJpMezGWI282rXHeqMZa5J0Fw7S5XCKsQTPniT5ELVPOV/hOGZ+4ilkLCdwQ3Vvo8O16Ekc0ayazoTEinAMCe8evfwxoC1I9m9OXpH/bVoI5HJkj4T4brzBsxxlU67zEWnfsmf0mwX3CUlbKclPqVMipiLHQhjxMJRCJYhfZhf6C/JkOq03H8lv8tB9EMCkgOvVuBSZ5PQuEm096bf805PeZbTNrybCuHLe2u64RbFvR1vaYjXk88guKXiacuBS5zd1ssHFFRI7us1odGB7/9qG+ws77/7Kaht4iUHI2RuNW0sDY78GJSsX2V2smO6vJA3cLEITIlrO0+idd34TDx3tlR5y+lSXSAXlVXHg90S9rbJqqapez4JjWVD+X2Rd6Py6cjM7wYELQ4LnCs1SLvgG4bYxiXghwrFfNry9HDxedNFncA9UbP6EQvNLi8Fj2usa2g==
X-MS-Office365-Filtering-Correlation-Id: f52e8ea5-79a7-4eb6-a1c5-08d423ea7e9b
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001);
SRVR:BLUPR0701MB1714;
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714;
31:OxHdYM5GspK1BGa86l/BxXNlw42nIy+IchIEc3zIBo4DLsXyZUrbOqbKvllJYcCXq3v4f7XEBxO+ZS6GPssMVomEZ79YUSkUznKTSqlr59+INaDAWltsKaV02UO98HJv6y/F8dYk7oF4XdGqefPERdqUsio88H38e1D1V5hCgIVfRNYRg2F3tKsoNFtkYWZmiL/MeihDnZeJSwMv8d+2HktzzNK54R1mMwOVMb98AIBb0B3P8apH5E3uCb+jE+0G4DqmgOBclHerCgyC2KHOFA==;
20:jN5vtAgSj1lOPcL7USAAjzUEZp3IFVV2vWSpa5Og5pWcKIZh93x+tlXts6pDh+J6p4jhQbwb+3arNiR7rkYg7jKLQfRayP4Baqf9io/GfUgAds1QOGpINz0Pqk9PVYsOY0dQPPdxapEr/lDYeugDlG1x6KnmnT1UvZ1N06tnqsO7d6CTaY/d9fJmkDkHsucp27uCuwXqEWyEbihgcQW5DOeREcTSXOADpLVlU6Hq8A9fsQmC4n0ZgB3ERmmHIjdjEUF26lCK4S4Y3FeqlVZdWm3R7Lw2n2TTq8mVOOUV3ihjdsYqTek/eBF1UEHw7iLgTqr/jEe+ahr0q4otywoPtY3BavPbBIQboqlqvJ0Jf2D08S1J3gsxIGa8Kej7+xoKfjOc1rJ0oi81ZrkSKXZGick1qiW27bhFPxgBpDy+AHBLXkee3Cr1OUX4XglCAwymBn2VJmgeLqTFWZ2D6KIQl1gTNGGsf/yCn1c1Lg+ikLAsg0yJujGxRgLHILhXbvNfmCuUSQNbb+GCejxzrq8zywuLIwTS78cgO4toCJ+yCICDmnuPhGDtkK8E3hdcnMt7vJ//C8fbAl980AeKIXsLfZXP8sCm5kxpveVwKhuIoUY=
X-Microsoft-Antispam-PRVS: <BLUPR0701MB17143DE47D220FDF00F3ADD1819A0@BLUPR0701MB1714.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(6072148);
SRVR:BLUPR0701MB1714; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1714;
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714;
4:BZP0K31g0+IJ7pBpZC6O0dY75xOt+hCdBe1c7gI7TORltB0fG/dEup7Soz9Ys27TL3cikrUNzSAZpEJRK0Q97pOTPn2pkPDAxz9cFhPmm60V+x8a5aeEJS3I8BWcMvDhGGpOpDkNlLeNKthxUsk4IDqi9AOiikWKoISFWnmpUorecYP6dmsY11aBB8GY2fDZEHwrXKuzVFcmmtQwmUWGpyFZbC3Tf/AYs6UoWVbP2FrtsCs32SvILbnJcoL+rliCOxukmgaX4I8yqH0+IUgXU5/20slq+0fiKBTexVVVIhlAKJ45YRa+igxBTTGesMRVXagoND9S4pJGy9G+jvmwhQ/i9Kg4X6GAtxqcQ67maitiddDVpfDOZDYdfdEwidQt1hxkUy96fGGbWU4P5tunqTFP2OA3vEmQLbRnjqiBZVzjfui85cQYp3L+hEuLVXPBZ6RaCW7IR20Lj0wq4gke1RmQ2kPUYb3kAFIjlzmcOuIiKwgOT/lgXAVjH7AgeanM22XrrMiw1ePfNRAAgmAWCGmyfFcOUURRmqbiGVbvJzNVhU2wlFBby2Mn6YcCHnBmsuU2nZbMeyhXgIgEUbmNOw==
X-Forefront-PRVS: 01565FED4C
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(39410400002)(39840400002)(39450400003)(199003)(24454002)(189002)(33656002)(189998001)(42882006)(5660300001)(81156014)(6506006)(8676002)(23726003)(54356999)(92566002)(4326007)(97736004)(81166006)(229853002)(83506001)(7736002)(50986999)(305945005)(2906002)(2950100002)(66066001)(38730400001)(76176999)(50466002)(97756001)(47776003)(8666005)(110136003)(4001350100001)(93886004)(6666003)(46406003)(42186005)(9686002)(106356001)(61506002)(105586002)(101416001)(6916009)(3846002)(68736007)(1076002)(6116002)(18370500001)(7059030);
DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1714; H:localhost.localdomain; FPR:;
SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
Received-SPF: None (protection.outlook.com: cavium.com does not designate
permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1714;
23:xK3LDB2cangL+zuMqyNTSG04qqGcSk8q6JjNzHh?=
=?us-ascii?Q?iZWADyLj6fn6VETSX9GKkKz84qwLYN29BEt7H5VvjU13G7MrWkSLNn7elWgk?=
=?us-ascii?Q?9gwT7rbpSvGXoM74P0FSNEHmpHLjw/p5Y5wTNnSkWi+vEympzSx9bImYBUBD?=
=?us-ascii?Q?9/h4dZavaxzUgxgPtiS/ULdyjb1LpS2t1q62V+Uke41yj8ByMKv9v87t0/Jd?=
=?us-ascii?Q?J8Amug38fPCQgPUD6LB5NzuzoyKieygA4m2+O2du88hkt/ylQQ300UxjWi2W?=
=?us-ascii?Q?KVEJkHEw6kZ+UNlr63vT3rLz45fc/DRgMXHceuQ8a0XdxeUYEqhZe0Y3Ga8l?=
=?us-ascii?Q?qhzvII1HdOThfdXJdNKYK20/B25yfdUF4XJabwKgOrs3frG0nDPNw09/P6Eq?=
=?us-ascii?Q?ECb/kDfcfARZ2EFxKuDNPE2rBA+gc/wOY6Z0OkhlvnMx9WQYkqY/aS9qKRCi?=
=?us-ascii?Q?u4ZDg5OtQEZddo5zQCagKkmykDkZOsro9gkMCv96N5wBdZSEvoAmUqN+wfph?=
=?us-ascii?Q?Cyj9VoDvO0fsQbw+qMV74MSww+VXH6tVyu2IW9ijcxKoC+LHm6vm6wZrAgUG?=
=?us-ascii?Q?S7aSucQTa74JXQ7j0uGXh3cDkoYzdReoLPrnjXc/8KaUkY9ooH9wNM9+6Qvl?=
=?us-ascii?Q?1QgNT2nylXoWW4eLI71CU9ingK7+WOt5bg+PlsTicERbqwHKFLpg7vW4q3ZD?=
=?us-ascii?Q?ZeHkh247EhRMfTVXl2BVWuoeN9dn7r9R+c8Qi/CCzHC6UVM28mADe0/Vb7Vy?=
=?us-ascii?Q?kBKAY/dCIaPuZucfivqOsAI88jM9I7MofZSH/U4bw0oQ1k2ByOT2tCxiXyJ9?=
=?us-ascii?Q?S20BkM65mzj+5Km1Rg1cGrlO8No35pUKGQdvn7h9KDumdBX0yn5V69UJCp3x?=
=?us-ascii?Q?iGKO775FG3nRgR8jVP/YxWxFxYwO3HpO3SGwY8Gk/AktVSd+W9gEVC/XOW8z?=
=?us-ascii?Q?IVbKfuA7Dz8YNkqNZ4yNE8ZwOTv4oHCUpZG6OT+FiUdRlAGVLWw+9Uz6H+EH?=
=?us-ascii?Q?ZuQezJWwLYU+PpXoW1p9KiEOemsWNsqXj43tTZm3Kcup1xMwVPkFg++UTspy?=
=?us-ascii?Q?DNZLNymYB+PKAbxmNx7AMk5UOZOtMZaKzuZKblR4+mSRw8eApsqE3JSD36oC?=
=?us-ascii?Q?7Ygq3mLgpGCGViQPLDU6XqUpDiy7xo+CvzpsTGYM5NS3TJN51qfgoBbtP6AF?=
=?us-ascii?Q?gq5savvD1awD1C29BDc/2DP2l/oZ/WTe51MN1KE8k4pmY/tbIpF0iwGElVXH?=
=?us-ascii?Q?/M1of39NQREhY6+5BVvH8gqKjqgiWou5RoGauuhpAZ7sPpP1ysBei6V1jzrU?=
=?us-ascii?Q?PxkQ0a3F2owUhAO0EnxgpxXeXIqIAUconTcTKjIsUUfhhFIW1wnVpcezIXiq?=
=?us-ascii?Q?mG1PBKQ=3D=3D?=
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714;
6:IhKQADaxRj9GcZSzKc4U+Xo8Ei6ugl67BT7z50GQ0RyV50OsSLhhnJRztpQxBh87X01u5gPkNDNd1pKnO+TbNYItCpkKi/8yXxaRswCRWmTk6AZ1xoiNCrB1+dIDTZ1KZHWLS/1o0H57sBh5UV7iP9+Zctd7ELkDs0/5KV/JeHvK0Xjg8uAl1UY5V9gFLb7cpDY3t0oXnBWwx/LoibmIw8rghSNCW87bewwQ27ufK4M/YDf+XU2YwFaYroNzz3t5ppQ5bLkQ9Gwzv4x5Ns56xc9dEuotwRzlJqH+KngbY5/Iz/i2K708H3efu0E/v5M7KfXKQVUKaeD/jBzXXQ1OrxVI1WD1uVAX2QtfZTapZog=;
5:jD257Iy0ZjiPLKR/MAY29yQrYtsvniulcfkUN0N9+UABMk8HlDDIeZWbyR9C3A5fVu0GyG2bx+mYWzdkHhhg25yKfNL1Xh+rX15HGxBvvfDUkl85SmZbOfO5ablvlJMmYBes5THsnH2AXqBej3mbzlB2gnxdpw9ltzzBQ5d0OCU=;
24:0mtxVMr1L7ZZM/ztCK3+BiS4JgKO8MYNvvuaBNR0YtMinOheaG+cxznJXs+zm8XbImH+Rfxhb4tqt3Xzo9tBm29ATbEj2DossgBu+AETxhk=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714;
7:6R/bUKM9Q+jwWyggT+TaggdJmjBrlOFqLnkEZXN8Tru971/5YckBGI4/r/iUf/PbFKBXGaNHcq6YNheRbQMbGf+zbHp1L8ojVpcYVfaTeRnp0TJ5SGjGZFNeyFMSD7m5QpDFRQ3Ex4QUdyqJx98aSYjoiwduG6WqrmCjLN0gemOWLYPuxEzAh7wD3DzIURKWVvlXR3Uf568aJf0r61zlPrXaWIz8UCoP3TFDc47J7RbnsNDx9NCALlVLvnhTUzGtulYblzejJ7hiFWuQJwmkGbq75HzT0QMXtD6Diy+H8n8RtfRII+sDIWJJOv+UzJLaD4I+XstDOu3Gl7QpitM2xZc+TX3VRpPgm//oBO/+CNE=
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2016 06:28:59.3406 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1714
Subject: Re: [dpdk-dev] [PATCH v2 3/6] eventdev: implement the northbound
APIs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Dec 2016 06:29:06 -0000
On Thu, Dec 08, 2016 at 09:59:37AM +0000, Bruce Richardson wrote:
> On Wed, Dec 07, 2016 at 10:32:56PM +0530, Jerin Jacob wrote:
> > On Tue, Dec 06, 2016 at 05:17:12PM +0000, Bruce Richardson wrote:
> > > On Tue, Dec 06, 2016 at 09:22:17AM +0530, Jerin Jacob wrote:
> > > > This patch implements northbound eventdev API interface using
> > > > southbond driver interface
> > > >
> > > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > > ---
> > > > + /* Re allocate memory to store queue priority */
> > > > + queues_prio = dev->data->queues_prio;
> > > > + queues_prio = rte_realloc(queues_prio,
> > > > + sizeof(queues_prio[0]) * nb_queues,
> > > > + RTE_CACHE_LINE_SIZE);
> > > > + if (queues_prio == NULL) {
> > > > + RTE_EDEV_LOG_ERR("failed to realloc queue priority,"
> > > > + " nb_queues %u", nb_queues);
> > > > + return -(ENOMEM);
> > > > + }
> > > > + dev->data->queues_prio = queues_prio;
> > > > +
> > > > + if (nb_queues > old_nb_queues) {
> > > > + uint8_t new_qs = nb_queues - old_nb_queues;
> > > > +
> > > > + memset(queues + old_nb_queues, 0,
> > > > + sizeof(queues[0]) * new_qs);
> > > > + memset(queues_prio + old_nb_queues, 0,
> > > > + sizeof(queues_prio[0]) * new_qs);
> > > > + }
> > > > + } else if (dev->data->queues != NULL && nb_queues == 0) {
> > > > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->queue_release, -ENOTSUP);
> > > > +
> > > > + queues = dev->data->queues;
> > > > + for (i = nb_queues; i < old_nb_queues; i++)
> > > > + (*dev->dev_ops->queue_release)(queues[i]);
> > > > + }
> > > > +
> > > > + dev->data->nb_queues = nb_queues;
> > > > + return 0;
> > > > +}
> > > > +
> > > While the ports array makes sense to have available at the top level of
> > > the API and allocated from rte_eventdev.c, I'm not seeing what the value
> > > of having the queues allocated at that level is. The only time the queue
> > > array is indexed by eventdev layer is when releasing a queue. Therefore,
> > > I suggest just saving the number of queues for sanity checking and let
> > > the queue array allocation and freeing be handled entirely in the
> > > drivers themselves.
> >
> > I thought it would be useful for other drivers. I agree, If something is not
> > common across all the driver lets remove it from common code.
> > I will remove it in v3
> >
> It's not a big deal for us - just an extra assignment we need to do in
> our code path, so if it provides benefit for your driver, leave it in. I
We don't use it either. I will remove it in v3
> just found it strange that that array was never really used by the
> eventdev APIs, which is why I thought it might be better as internal
> only.
>
> /Bruce