From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7DE5D370 for <dev@dpdk.org>; Wed, 14 Dec 2016 11:12:48 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 14 Dec 2016 02:12:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="scan'208";a="1081661638" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.64]) by fmsmga001.fm.intel.com with SMTP; 14 Dec 2016 02:12:45 -0800 Received: by (sSMTP sendmail emulation); Wed, 14 Dec 2016 10:12:44 +0000 Date: Wed, 14 Dec 2016 10:12:44 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Yuanhan Liu <yuanhan.liu@linux.intel.com> Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org, konstantin.ananyev@intel.com, thomas.monjalon@6wind.com, jianbo.liu@linaro.org, viktorin@rehivetech.com Message-ID: <20161214101244.GA94040@bricha3-MOBL3.ger.corp.intel.com> References: <1481680558-4003-1-git-send-email-jerin.jacob@caviumnetworks.com> <20161214025357.GF18991@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161214025357.GF18991@yliu-dev.sh.intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.1 (2016-10-04) Subject: Re: [dpdk-dev] [PATCH 00/28] introduce I/O device memory read/write operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 14 Dec 2016 10:12:50 -0000 On Wed, Dec 14, 2016 at 10:53:57AM +0800, Yuanhan Liu wrote: > On Wed, Dec 14, 2016 at 07:25:30AM +0530, Jerin Jacob wrote: > > patchset 14-28: Replace the raw readl/writel in the drivers with > > new rte_read[b/w/l/q], rte_write[b/w/l/q] eal abstraction > > Instead of rte_read[b/w/l/q], there is another typical naming style: > rte_read[8/16/32/64]. Any preferences? If you ask me, I'd prefer the > later. > I think I prefer the latter too, as it aligns with our naming of atomic functions and our use of uint16_t etc. types. /Bruce