From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg0-f45.google.com (mail-pg0-f45.google.com [74.125.83.45])
 by dpdk.org (Postfix) with ESMTP id B16D3370
 for <dev@dpdk.org>; Thu, 15 Dec 2016 00:41:00 +0100 (CET)
Received: by mail-pg0-f45.google.com with SMTP id 3so13009471pgd.0
 for <dev@dpdk.org>; Wed, 14 Dec 2016 15:41:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:subject:message-id:mime-version
 :content-transfer-encoding;
 bh=MF6Ns0DeDnlkYmfkyIM2gexRH+opyIXYRKm97j9fyvE=;
 b=yRQyp+sbKoybMb45ga64Yrs0EuG3/MmlghsoZt4pZS1X2wMnhaS+qKD3kiaC3lvozB
 3dULPGHSA7hnsJOOJt00muk5fSdlvpXIa/9tUZ1vR8iYfYK5D188ZV5w9jKojycXBXEC
 tRhKsu0el7XSziUddSdRKH9g2eDf/59ks3vxW908BkHGs5QnkKsIXWxvgA3LttpbPhj2
 +QYwmP1vArQifkstyu28Hn5055RNSu9R9uLNN7rF7PZ/MFX1MdjO+PtyyfN4euSVez6q
 hyiknbuwxIyyfieXUgdPlGSKBvhg2HMx8nHT1LJbuQNXY+3tF8sJzPSvGwS0f6igdhWf
 ZthQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:subject:message-id:mime-version
 :content-transfer-encoding;
 bh=MF6Ns0DeDnlkYmfkyIM2gexRH+opyIXYRKm97j9fyvE=;
 b=gf8eSkuKpetObaIKJkqQvB9b9wcoy+sFCvuv217rFK83WA1BXGTyb/Z1IINKd2Qt+2
 UHRJPs6QodcOGCrR4oi/2GSlzNySGKM1c0bvk+mpMtYVL+42bCx3BT6KUkJu9MfneovY
 pf2Thbg64j4GI8YJWhJvy8baUkshjsimKCZ6AnP0/GzoUuG/zIf4/RmaibfkN0eqS7v5
 8bE20z5i/hP58pDvdqh3573ogKbXKZnhw4yoVLEoYwSBXcXixYDOAqq9TzVJ+ENW2QT/
 ThhQjvIwAqMZr3l0DNBKo4FNgD+CsAcH1FEi4GJv1I/0iI9ug4vrTxjy4cKmaF0k+OhZ
 EUuA==
X-Gm-Message-State: AKaTC03FkWGk04q9TMT5lTsYMR2oH7gUsy2opF9tuNLYWgaWZ+jdPgVKYlcEt/J5Tl7Xvw==
X-Received: by 10.99.176.14 with SMTP id h14mr190511655pgf.22.1481758859580;
 Wed, 14 Dec 2016 15:40:59 -0800 (PST)
Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65])
 by smtp.gmail.com with ESMTPSA id i124sm90334008pgd.15.2016.12.14.15.40.59
 for <dev@dpdk.org>
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 14 Dec 2016 15:40:59 -0800 (PST)
Date: Wed, 14 Dec 2016 15:40:49 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Message-ID: <20161214154049.698de2e8@xeon-e3>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [dpdk-dev] KNI broken again with 4.9 kernel
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Dec 2016 23:41:01 -0000

/build/lib/librte_eal/linuxapp/kni/igb_main.c:2317:21: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .ndo_set_vf_vlan = igb_ndo_set_vf_vlan,
                     ^~~~~~~~~~~~~~~~~~~

I am sure Ferruh Yigit will fix it.

Which raises a couple of questions:
 1. Why is DPDK still keeping KNI support for Intel specific ethtool functionality.
    This always breaks, is code bloat, and means a 3rd copy of base code (Linux, DPDK PMD, + KNI)

 2. Why is KNI not upstream?
    If not acceptable due to security or supportablity then why does it still exist?

 3. If not upstream, then maintainer should track upstream kernel changes and fix DPDK before
    kernel is released.  The ABI is normally set early in the rc cycle weeks before release.