From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0049.outbound.protection.outlook.com [104.47.34.49]) by dpdk.org (Postfix) with ESMTP id 983BE36E for ; Thu, 15 Dec 2016 09:21:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3LLvSPGi3nyPpJajjEWvrBfcn42pOuKwok0fwiMbLzE=; b=ZElrieJLtaXFiZMURDt21aXfFXDbCY2JLanK8/2wS9Cp2pQ0B7Ix/7S0mAztXJMd8cs6VuC/2wS7VvkhcZNqsa+H5liAifdZq8eiqNR2j209fjvRENa8znLw6MkmwT5PFqB3fjrcd/lbfHvDabPfbVdRfOl4CBk+FvVk3IHuHD8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.166.153.127) by BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.707.6; Thu, 15 Dec 2016 08:20:59 +0000 Date: Thu, 15 Dec 2016 13:50:43 +0530 From: Jerin Jacob To: Jianbo Liu CC: , "Ananyev, Konstantin" , Thomas Monjalon , Bruce Richardson , Jan Viktorin Message-ID: <20161215082042.GA30792@localhost.localdomain> References: <1481680558-4003-1-git-send-email-jerin.jacob@caviumnetworks.com> <1481680558-4003-9-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [122.166.153.127] X-ClientProxiedBy: PN1PR01CA0010.INDPRD01.PROD.OUTLOOK.COM (10.164.137.17) To BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 2:sy872DEnw1p0uY/j++c2wkzK7M+uwTSmh3mWXbhWXXLZLGmNvCSQbB58HMhQPA6iIzYkR3ik+q+ZBUbyuRMemuVktGxPk5K+UnSqu/19YZnnRIywv9HbitjbpIgPay2I7uV2FzlOM3LOBpujWsOJjBd0YrlAj45GLSnLxnE46tg=; 3:+yjTtT7PjtbbQABVoO4EQcNNqk5iJ2HsJrqAjhl/pjh9fqxbFJ4KBvVT14PmeIkrLfBtmhNCvnNRU3n5AjQQpoTojx/ZZusw0KkuHljRqoP4n+MdV44KESO5FRmYQ48oyUEGSrtbqTYtA+vz/fs7TLHj4sIRVVpUijywvAlVPG0=; 25:HasCMAccspbS0v8878MX4BTSNUnPq4DnuoTwW1sIZvvcOg58i8Dszp1voM5jsR05ZlwVnf3CkAfV3HzabW6S7PRWBpHpGCCChqa2JjKwRd6tKWCUCqbeFsfxYK1JnXxc4V3K5RIKmR/3xF5phdDuLeRtQto6HHVRnaxyjpN+RJ6uree63Pc5UNJt1SpOoodsoxdl9XHgcd+o6igxK99vzh9EA7YgmFCTCPU138PpeEEL8ZZLWHlyM6t7HOvcPYOXrsbI1x9EWwA7O9MS69NDCuymoQz1Zd8qSymO+A8wqKXSXteFyIIH5z0z5bWilkoNdIPe1luL2mrPHtCma+dfggHo/jBFhiGbWBbMo8UvBdKsXB1+mwJ8T3rd1BJykq77GDbhWlysNmNiWDD+d9yUzVDgDaiqDhDfVnok1ZdYydpE6Buqi6R2bzulBlHtus2P0XKH+vGEruBO+WT7YeT9bg== X-MS-Office365-Filtering-Correlation-Id: 2f3fd02f-8fec-41f8-8028-08d424c34e2f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 31:mbgm/qTCKLhT8hZYofGNiXoQ3FBM/drOIaNIK7bJWVNzCSXfdcbmwzf9gNCgZMkmdM/JzYeFF7NcsyXiBj58bG6mm6OjplMC0vyCVepS3doS4vjR/Z/UxpHP8m2u33i81o4GV+SQrP9Rw+AdPVVKuAln376LIf7/8DaLv1hPuK01xxFQj8p4LKr+B6FCMw7hARWftPhI4XbVrkoi9K48kwvz4brkYkFbu06VgSYQr+0d/mQoh5gyP6QLKZoxI8amwj4FbGoCoxgOYYUeXNNT8g==; 20:PfqDiZKAOn6tPXgJOwz5CvM6zQTmvipCG0BRNJ9b1dlc69Z6a1T/u7qmkb8xvLcf4oI1j/EaT5I9t+2f+1ef18/SErTJ8LXJJY1daV2+QNa0J0boDBfKDYBnFLuz7nNskiSL2EbXJ4Z2/fM7s95v2LlxGSy2UUqePteuw893Di/Wa1jn/Nxij+bMQ2T2sT/J8ABtDGD5nfhpgCdplMmFm36QpFGK2CHnS7xLJoFPybK5XcOeqJrs1zzlKBaZuX60MWd8AKzxxLu+sCuVRn42rKZfhd56k7JmUAukbFrXLcxBH6UYxAkPae9EpjfhpDtFWIYwbIUjqsd/wS0CMXQczSFB/5WHModaz8ZNUqmYeaOoHHeyWthO+KvG+j95AytL+tAe03OpPo8XfMYoHD6jAWg50ZJSgNd5x9wuzbbgmIwxtjwjmYCXdpAtIhikA1Ng1Li36YQJMTZTh/iuj+5DGcPo6t/jb5qVyKUDbb9CZ3oP8770VNWOpkhGF5+cdDtt4Ck7P1gY4Jwh70DODGrm4YS7cKm4LFFId408hgRqBmBCBIry8Iy2oJa2F/yFlIVzcCZL9oo9DExW7IFr5EoGp2+Awq6Mk0MuJt3EEelPi3k= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123562025)(20161123560025)(20161123564025)(20161123555025)(6072148); SRVR:BLUPR0701MB1714; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 4:aJ/xQtFo311VClVu/+2Noy1ojgKpniclizo3D2BQJ4XcIdV8DYtsHTPf5RRqWa94Y19NzbALc+xhGQh7s+WGkEplKTBmwzv2rl+n2OApwJDG2fC7MsGmPIkCZjs2KCiCy4wz3NYuD9nGqDqhJlij8HHxw99VyW7ylILMxqi6ORRh3jzr8gQyfXdkqsSLWBMYA3XkaU83QXfPpOKoAWeM6KS2ezvYHRHkbWXcw9jrTA0YhIwfSgV32k2/ach2Rha1VLGGb3pqbuI9s6dIMgezs3KI/LBnsb/Nmb+OKPsar4o895nXcdcTknNchsZ3ZMcVwhavuxjTatMTu3DozAvzsfJyiBBOIvWIHHkCmpXwUCmrTeyEdr+l2Fz8+WT+RfNO5CLUNqeeQOhoQD928VDhxxt26793HpCFvxCAzCycfMCPdcJI66gBkQgOAe+8t5Zmz8RcqwBgQj6l7DnefoLP/M/CX0siPvyAPQCzErptU6khcmRBtUEgQCxvdgw9iSyt23B//3Q9W7H86HdzEvPH+JYyqQxWyd4yLbsUKZ59yWgnfXFRmttbJ1QU6d0buzos X-Forefront-PRVS: 0157DEB61B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(39840400002)(39450400003)(39410400002)(189002)(24454002)(199003)(229853002)(4001350100001)(97756001)(110136003)(47776003)(2950100002)(66066001)(76176999)(38730400001)(61506002)(105586002)(68736007)(3846002)(6916009)(101416001)(1076002)(9686002)(46406003)(42186005)(6666003)(50466002)(106356001)(92566002)(4326007)(54356999)(189998001)(6116002)(42882006)(8676002)(33656002)(5660300001)(6506006)(81156014)(305945005)(2906002)(83506001)(81166006)(7736002)(50986999)(97736004)(25786008)(23726003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1714; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1714; 23:sNpMRIAxtVVK3gI8GyLhSh2TsTUEpPMvUGXqLJS?= =?us-ascii?Q?dYmGLZkxhFryOxvcpELxu27iLbq8UjZdWGNH28MC04uSMXPomDg4DLAReQ7j?= =?us-ascii?Q?yE/EnjEXdpaoARRY896UeFZPCf0TSsVhpnRTKcU5mSFHyvQtYJ+eErMTw9Er?= =?us-ascii?Q?yNNsx9d52YDhWHAFoqa4575zklxNYKCeqVmjkW4JrISSKFh5f31zgjhSLaMi?= =?us-ascii?Q?Qi+Bt+bHm3rKHxZhlb3hKUdGTPp7lQ8jtJWqA7aOo2aaWOCiRK2KZCg5nx43?= =?us-ascii?Q?JoHo+6odJQLKiCg2RxVuz7CbWrNo3dVXLicEZbSCsgVVeyEDKHvU0fKlwJTv?= =?us-ascii?Q?1M7wCY98nqoPEIP9gyzNO6/Rrg9nqrL9vAT7gcD5v00kumAR2jukpgRPU3uC?= =?us-ascii?Q?2stnTKU0r8I5UTdx2vIY7T96qsGm6GVAOKdwQBaVNYcsJtIeDxqBmpXDiToi?= =?us-ascii?Q?LdMvIy2CenISCzxSM7mTO/JrU7JfMgfdfNPBAH5RszSFAGhWPofZvLvsri4p?= =?us-ascii?Q?IOO45/HrThG0shFjfgOig3RWHP9eTGJ/JYJN3O76QwtB754yyg7N3QBdDp+W?= =?us-ascii?Q?+xNr4gRJl5XtYoFC6WI0YCK095Cd1YysKvNK06nGYgPRlEJjJhW8RI3iqpyj?= =?us-ascii?Q?NcgN+DHlIVTTdZO9nWQfNLITPdTmtpPD+OQ23g65BXFZu47v760YWoUUBvzo?= =?us-ascii?Q?UWipMGNzgANwqG6/GFOL7ScvQ+Y1PL5LELya6VMU3vl8ocqyCNrEVcTCpvEN?= =?us-ascii?Q?Umc+zJCXLmqz5RWLX4VGnrjwpIBKPxrR/V5RZn3KsmRYfFUY+tQ+zh0aHuXP?= =?us-ascii?Q?QxWZjqydvnHV34essQWs5MqqNU0settL8eE8QDlpRnezMCrex6kjT/Py7sB7?= =?us-ascii?Q?JVhXAqilfuNpWVNnV2wNQQIVm4GPLYl0FZDFfTHfr48/4q2hWdH0fK1MTga9?= =?us-ascii?Q?Ae5DTfI6z+XDY6YKSSH/IDUTCc3//eWzUkyUHTucM/FsY6gQ54SDmxpgoGhu?= =?us-ascii?Q?fcwiOHcQ3ArvcK0o30QI6f3oB17qxr0rE1lEoSZOJ//XrJZU+1YHK+BAXrXR?= =?us-ascii?Q?fxAzZq4TH2bfB0vC0tmGoS9g4KGYPLQB/+IwQdY5Gn8AN+z7o8a/7op5eAzA?= =?us-ascii?Q?RnQU+fbBzsZNasnO3h/Vyvr29j0eFJJDSU3AmRZxN2hbXu1t4rCtDcGkeEx2?= =?us-ascii?Q?VRW+gAiV3bldSNS7HNMQjJ8fHIl3blLx9LWynrkZ0vUR1NPfMJui2RNV0Rrw?= =?us-ascii?Q?K8JGF97v8huvArCQ30wr6AAIV1ju0BiHKVVdVY6IhIRsVps/36SEhWO6sJDS?= =?us-ascii?Q?rU77ThDV5mfmvtxYz87Y1Y2I=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 6:rh4dVgZ+M+t0xnR8GWpq/FQys9jNfmGLin9C1eLiXgUdAHybDrTqkwl1M1b885Bfpg9BT2wbZ6/nT7NyTUZo/jzrmgG1py+KXG6gFmuhOmdzWQ95z7NEK5efD0qxjrZKNnAYuN2SpD5q0qAl0In+QyIEoJDXWDxZDOBGwnHS4Jy/6/55tjxfFb2cTs3I8B7/9SBeWDapZ1Lzxg7/NWkIOhwF2IAXzD3xgwydV7wcr+YuLihHpKSP4o3aBgW0J4/XvkTY526IqFF3FLKZNG7lPp5lpLKryt5cUeFMc0bnV4+/OeOXsi6ka/I9XdPR8VEYtE2c44hUx9eUqrB7jVzB8w==; 5:u0RN0397XCZC3k6u7Bf9/5Oih+mssGRQ056U78jV2b1F4e9uePnhIbGinhi89HEn9qRz/mP374ZToZdLsoITf9w7TdpMRUiEI/7C38bSUByCnMoXGq+nuWgr9Z6T4p4MjHl6LShjZsLnFkolgkxg2A==; 24:h2ll1uZ7oQeZPIr8n0TX/3aAjKsplngchltNXJ7NfSgME3OjBHcIskHRpIYb3uEf01NBdeqJKF4uYgw27FWj6cQh0yZYH0GwtuJ0tTK7VBQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 7:gQFkqVD3j42hCTrzrkNOrFV5NJDp4T+ODPKVmlGGYyE5ca2Do8d6xqvGW0VlVFJSHa0J+O0hMZFEqcKaivmrD05CoELCX/YpBDUoDYeCcS/67s2jEi/RhbAXiqCl1pE6G5EZD6ejhcYW3FhSsf2juW+ISOJhiTdhyh+GE68I756xd5Hi0DB+Wk35kzsHiGbIShjh1E+57S+JzJPcCZii5h2nOInAStcawYWsw0l9raUo48WcjhNgoXoAaqGA/db9jwy3KpvybzgNR+GUnEzuaQeXQ6n+VuakPIzf0U7gwJbtOx6BVRgO/vQAMjO+/GzuL/0VkOv9+AJN7Esb/w98qUaE954J/5pCdRf5nKLCal8= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2016 08:20:59.4182 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1714 Subject: Re: [dpdk-dev] [PATCH 08/28] eal/arm64: define smp barrier definition for arm64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Dec 2016 08:21:07 -0000 On Thu, Dec 15, 2016 at 04:13:33PM +0800, Jianbo Liu wrote: > On 14 December 2016 at 09:55, Jerin Jacob > wrote: > > dmb instruction based barrier is used for smp version of memory barrier. > > > > Signed-off-by: Jerin Jacob > > --- > > lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h > > index bc7de64..78ebea2 100644 > > --- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h > > +++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h > > @@ -82,11 +82,11 @@ static inline void rte_rmb(void) > > dsb(ld); > > } > > > > -#define rte_smp_mb() rte_mb() > > +#define rte_smp_mb() dmb(ish) > > > > -#define rte_smp_wmb() rte_wmb() > > +#define rte_smp_wmb() dmb(ishst) > > > > -#define rte_smp_rmb() rte_rmb() > > +#define rte_smp_rmb() dmb(ishld) > > > > rte_*mb are inline functions, while rte_smp_*mb are macro. As they are > all derived from dsb/dmb, can you keep them consistent? OK.I will add a separate patch in v2 series to change existing inline to marco to keep consistent. > > > #ifdef __cplusplus > > } > > -- > > 2.5.5 > >