From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f44.google.com (mail-pg0-f44.google.com [74.125.83.44]) by dpdk.org (Postfix) with ESMTP id AFD534CC5 for ; Thu, 15 Dec 2016 18:22:15 +0100 (CET) Received: by mail-pg0-f44.google.com with SMTP id p66so22027566pga.2 for ; Thu, 15 Dec 2016 09:22:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=N/EZeqCNlafpHctbBz9aSIE+mGv2A24xxuUG86Du6o0=; b=BSvuQmw83PdmoBfP9fQ8znKoLHBNdjpceXCNQFIoK5p3ud2jlfVK+PU68qZWc6VzEX NyPIoveMkhvPN32fC+yzGsRzSbfw92Hi553biOWiHIWiIlLCDaetlT/sKe05VcZ6K2L6 8tGCuCC2rKBiOX2UgvgEhlcy6p72G8Nlj2UiFRjzvBR563J1BRBt0RFEcBng6VBsnyr7 evDfaMcI2AdbUIRtWuncVbq+QiDoBpXN3cYffq7ESLSlM0xqQAcqd+7rKIRm9LWIo+Lg nIFGK2vT88SPlvu9vHqw1NOFhrAzESrw/S6ViSB1RHhalk0Q8ODYndjNkNUsnIuXgpex YzbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N/EZeqCNlafpHctbBz9aSIE+mGv2A24xxuUG86Du6o0=; b=X83Ok5OM66jElGh4UsBv/ssdKzJfVBma7Dvs3Jm7oyooUfBaGffYdRuzQWkK4+FamY oboeOXPBQ2e9FpgZnnEL+HchViolG8wPSsj1x8qskUCXAcEHt1LJh7Cc6lv3vIH33Wst WMmWKUCIVadakmVKtrN/YwRAvjfakL5H/yiEZrX70FAK1I2Q37A6pTKhkpCeTMe9MR08 EhqTfiA3pqV3XagojxogIGT8A2Rf5ug3smuM4nrd9xKdEkDFg/SVTIxS1iVO/uT4fBfo r7u8cJdQ1tQwLzvMHg/9CD4I5P8bhhxLlaPvegis5wZobmt8yOlS3FlX8yEbBT8rQ9xF I8nw== X-Gm-Message-State: AKaTC00qcE3AzSnKnXJDA7H5v1xvtWo0cOqsLgFijovqGcPlsoV3cVo2006Il2xQMODOTw== X-Received: by 10.99.42.80 with SMTP id q77mr3960460pgq.170.1481822534960; Thu, 15 Dec 2016 09:22:14 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id y189sm5941162pfy.32.2016.12.15.09.22.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Dec 2016 09:22:14 -0800 (PST) Date: Thu, 15 Dec 2016 09:22:07 -0800 From: Stephen Hemminger To: Neil Horman Cc: Olivier Matz , dev@dpdk.org, thomas.monjalon@6wind.com, vido@cesnet.cz, fiona.trahe@intel.com, adrien.mazarguil@6wind.com Message-ID: <20161215092207.168ba141@xeon-e3> In-Reply-To: <20161215160912.GA4450@neilslaptop.think-freely.org> References: <1479808257-8725-1-git-send-email-olivier.matz@6wind.com> <1481809599-27896-1-git-send-email-olivier.matz@6wind.com> <20161215160912.GA4450@neilslaptop.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] drivers: advertise kmod dependencies in pmdinfo X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Dec 2016 17:22:16 -0000 On Thu, 15 Dec 2016 11:09:12 -0500 Neil Horman wrote: > On Thu, Dec 15, 2016 at 02:46:39PM +0100, Olivier Matz wrote: > > Add a new macro RTE_PMD_REGISTER_KMOD_DEP() that allows a driver to > > declare the list of kernel modules required to run properly. > > > > Today, most PCI drivers require uio/vfio. > > > > Signed-off-by: Olivier Matz > > Acked-by: Fiona Trahe > > --- > > > > v2 -> v3: > > - fix kmods deps advertised by mellanox drivers as pointed out > > by Adrien > > > > v1 -> v2: > > - do not advertise uio_pci_generic for vf drivers > > - rebase on top of head: use new driver names and prefix > > macro with RTE_ > > > > rfc -> v1: > > - the kmod information can be per-device using a modalias-like > > pattern > > - change syntax to use '&' and '|' instead of ',' and ':' > > - remove useless prerequisites in kmod lis: no need to > > specify both uio and uio_pci_generic, only the latter is > > required > > - update kmod list in szedata2 driver > > - remove kmod list in qat driver: it requires more than just loading > > a kmod, which is described in documentation > > > > buildtools/pmdinfogen/pmdinfogen.c | 1 + > > buildtools/pmdinfogen/pmdinfogen.h | 1 + > > drivers/net/bnx2x/bnx2x_ethdev.c | 2 ++ > > drivers/net/bnxt/bnxt_ethdev.c | 1 + > > drivers/net/cxgbe/cxgbe_ethdev.c | 1 + > > drivers/net/e1000/em_ethdev.c | 1 + > > drivers/net/e1000/igb_ethdev.c | 2 ++ > > drivers/net/ena/ena_ethdev.c | 1 + > > drivers/net/enic/enic_ethdev.c | 1 + > > drivers/net/fm10k/fm10k_ethdev.c | 1 + > > drivers/net/i40e/i40e_ethdev.c | 1 + > > drivers/net/i40e/i40e_ethdev_vf.c | 1 + > > drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ > > drivers/net/mlx4/mlx4.c | 2 ++ > > drivers/net/mlx5/mlx5.c | 1 + > > drivers/net/nfp/nfp_net.c | 1 + > > drivers/net/qede/qede_ethdev.c | 2 ++ > > drivers/net/szedata2/rte_eth_szedata2.c | 2 ++ > > drivers/net/thunderx/nicvf_ethdev.c | 1 + > > drivers/net/virtio/virtio_ethdev.c | 1 + > > drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 + > > lib/librte_eal/common/include/rte_dev.h | 25 +++++++++++++++++++++++++ > > tools/dpdk-pmdinfo.py | 5 ++++- > > 23 files changed, 56 insertions(+), 1 deletion(-) > > > Its odd that all devices, regardless of vendor should depend on the igb_uio > module. It seems to me that depending on uio_pci_generic or vfio is sufficient. > > Neil > Yes it seems just a special case extension for Mellanox drivers.