From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 30E1758EC for ; Fri, 16 Dec 2016 16:25:34 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id a197so36910596wmd.0 for ; Fri, 16 Dec 2016 07:25:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IW86BgGTrKGRMWY0RKL6coWkjFT3c/xqZmqm1tCesLM=; b=Q6DHdnGy3DaqHxq+WUTbLiT1nuCTfsPgfxy6SfRKvXaeNlx/k4yCpXE/es0rhIheUP g4QGJHEALXdxrx0JRVhjfnuGpfTdX+u+gcgw6Q9cfcdwx4xii0zfVPYnUGf4NbfZl7ra vEbbiu8WwTHi3aYKTDvA/65BzXwBa/AZnrXsdB4XYyq8Kh6ebo+zwZ1La0ZzTghpQthC G7kLRoBdzF+VR5TeXNy6FrC6HxITEE84MQ5yPtypaFn3/XMJjVVcVKiVC7FUA0YpuAzT HcN1pJ82lg7zHo+gxgWnfhfbQiIKEL+RRC1hEX8wLjDutRBl6k2hRrTcR76ff6St7Tyl 1ABA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IW86BgGTrKGRMWY0RKL6coWkjFT3c/xqZmqm1tCesLM=; b=fTBH+MTMJ6P9tWMNOEMlT/fU1tI7yYu7W5HMb0pwIcoOR6jkujxtws7Qj6CjsiSkj1 YjXTU5k44GNJ9RZM6f1MUe2ryr/fQHNSWjvT7gL38l2KiyJ8lCMACJv1DhuVX43CA23x 2POGbwKQPZJjnx+QXQssNB1uXoaozLASj+gZNiKMTjGdxJF7lA1GLkrrK6ss+LiDoY2I wUhDoVC+4O1sY0b4Hb1D+9kt0p3KmJ2NLn51PlKVVgREVza0MnA/cYIAPnvfOf/YNoF+ W7QU4i7w3mVe0Lof9fYd1R86vDZNbGEUQpx32905p6zMBYZZw41P0YsJ/W9cpkVE+zvm 4MfQ== X-Gm-Message-State: AIkVDXLUSHyXWVQPbu22YKz1UBHhIEemyrVhL/R/tKL9qIqSjiTOvEtuMGKxazTmwXXJp0+E X-Received: by 10.28.17.20 with SMTP id 20mr3090019wmr.99.1481901933846; Fri, 16 Dec 2016 07:25:33 -0800 (PST) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id d17sm7240378wjr.14.2016.12.16.07.25.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Dec 2016 07:25:33 -0800 (PST) Date: Fri, 16 Dec 2016 16:25:25 +0100 From: Adrien Mazarguil To: "Xing, Beilei" Cc: "Pei, Yulong" , "dev@dpdk.org" , Thomas Monjalon , "De Lara Guarch, Pablo" , Olivier Matz Message-ID: <20161216152525.GF10340@6wind.com> References: <2d37e8ee1c613557e94acef94e381b72b2a535ce.1479309720.git.adrien.mazarguil@6wind.com> <188971FCDA171749BED5DA74ABF3E6F03B6625B9@shsmsx102.ccr.corp.intel.com> <20161216091746.GC10340@6wind.com> <94479800C636CB44BD422CB454846E01315717A4@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <94479800C636CB44BD422CB454846E01315717A4@SHSMSX101.ccr.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH 12/22] app/testpmd: add rte_flow item spec handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Dec 2016 15:25:34 -0000 Hi Beilei, On Fri, Dec 16, 2016 at 12:22:52PM +0000, Xing, Beilei wrote: > Thanks Adrien. > > I have two questions: > 1. when I set " / vlan tci fix 10" with testpmd, I find the mask of tci is 0xFFFF. > Actually tci includes PRI, CFI, and Vlan_id which holds 12 bits, so is it possible > to set the mask to 0xFFF? > Our driver will check the mask only covers vlan_id instead of the whole tci. Right, I'll work on a method to do that. TCI remains 16 bit either way so the current approach remains accurate, although not convenient because a 10 bit mask must be specified manually. This change won't be included in v2 though. > 2. When we test destroy function, we find the pointer provided to PMD is NULL > instead of the pointer PMD returned to RTE during creating flow. Could you > please have double check? Thanks. There is indeed a bug [1]. It is fixed in v2. Thanks. [1] http://dpdk.org/ml/archives/dev/2016-November/050435.html -- Adrien Mazarguil 6WIND